odysa commented on PR #373: URL: https://github.com/apache/iceberg-rust/pull/373#issuecomment-2236795680
@sdd `JoinHandle` in `Tokio` and `async-std` have different return types. In [Tokio](https://docs.rs/tokio/latest/src/tokio/runtime/task/join.rs.html#324) ```rs impl<T> Future for JoinHandle<T> { type Output = super::Result<T>; ``` In [Async-std](https://github.com/async-rs/async-std/blob/b7be2183d55a6bd62907cac0b10732f377d39fe2/src/task/join_handle.rs#L79) ```rs impl<T> Future for JoinHandle<T> { type Output = T; ``` `crate::runtime::spawn` is consistent with async-std, so you may remove the `?` to resolve this issue. However, we can still make it to behave like Tokio apis. We may need to discuss it further. cc @liurenjie1024 @Xuanwo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
