zeroshade commented on code in PR #108:
URL: https://github.com/apache/iceberg-go/pull/108#discussion_r1683521368
##########
table/metadata.go:
##########
@@ -156,6 +166,42 @@ type commonMetadata struct {
Refs map[string]SnapshotRef `json:"refs"`
}
+func (c *commonMetadata) Equals(other *commonMetadata) bool {
Review Comment:
hmm, shouldn't that get handled in an `__eq__` method in pyiceberg on the
metadata objects? Because I'm not seeing that handling in pyiceberg anywhere
unless i'm missing something. If this is sufficient for now, then I'm good with
leaving this until we have a clear example where it is insufficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
