Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

nk1506 commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1411677311 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -328,6 +346,14 @@ private void setHmsTableParameters( Set obsoleteProps,

Re: [I] spark purge iceberg table hung [iceberg]

FANNG1 commented on issue #9180: URL: https://github.com/apache/iceberg/issues/9180#issuecomment-1835550418 There're there types of tasks: 1. prefer NODE_LOCAL with executor IP, like 192.168.xx 2. prefer NODE_LOCAL with hdfs IP, 127.0.0.1 3. prefer NO_PREF the task request NODE_LO

Re: [PR] Spec: Clarify partition equality [iceberg]

emkornfield commented on PR #9125: URL: https://github.com/apache/iceberg/pull/9125#issuecomment-1835537324 > Not for this PR, but the same principle also applies to schemas and sort-orders. @Fokko could you clarify what you mean by schemas? I thought for sorting the following

Re: [PR] Core: Suppress exceptions in case of dropTableData [iceberg]

nk1506 commented on code in PR #9184: URL: https://github.com/apache/iceberg/pull/9184#discussion_r1411662284 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -91,7 +90,12 @@ public static void dropTableData(FileIO io, TableMetadata metadata) { Set manifest

Re: [PR] Core: Add param to limit manifest parallel reader queue size [iceberg]

Heltman commented on code in PR #7844: URL: https://github.com/apache/iceberg/pull/7844#discussion_r1411654195 ## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ## @@ -67,10 +70,13 @@ private ParallelIterator( try (Closeable ignore

Re: [PR] Core: Implement equals/hashCode method for RESTResponse [iceberg]

liurenjie1024 commented on code in PR #9049: URL: https://github.com/apache/iceberg/pull/9049#discussion_r1411655908 ## api/src/main/java/org/apache/iceberg/Schema.java: ## @@ -507,4 +508,25 @@ public String toString() { .map(this::identifierFieldToString)

Re: [PR] iceberg-parquet: Switch tests to JUnit5 + AssertJ-style assertions [iceberg]

wanglijie95 commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1411652841 ## parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java: ## @@ -79,16 +53,39 @@ import org.apache.parquet.hadoop.metadata.ColumnChunk

Re: [PR] Core: Suppress exceptions in case of dropTableData [iceberg]

nk1506 commented on code in PR #9184: URL: https://github.com/apache/iceberg/pull/9184#discussion_r1411645521 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -150,8 +154,7 @@ private static void deleteFiles(FileIO io, Set allManifests) { String

Re: [PR] Core: Implement equals/hashCode method for RESTResponse [iceberg]

Fokko commented on code in PR #9049: URL: https://github.com/apache/iceberg/pull/9049#discussion_r1411644693 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -846,6 +846,92 @@ private static Map validateRefs( return inputRefs; } + @Override + @Suppr

Re: [PR] Spec: Clarify partition equality [iceberg]

Fokko commented on code in PR #9125: URL: https://github.com/apache/iceberg/pull/9125#discussion_r1411626147 ## format/spec.md: ## @@ -607,6 +610,7 @@ Notes: 1. An alternative, *strict projection*, creates a partition predicate that will match a file if all of the rows in th

Re: [PR] Core: Optimize manifest evaluation for super wide tables [iceberg]

Fokko commented on code in PR #9147: URL: https://github.com/apache/iceberg/pull/9147#discussion_r1411617308 ## api/src/main/java/org/apache/iceberg/types/Types.java: ## @@ -592,6 +594,13 @@ public Types.StructType asStructType() { return this; } +public Schema

Re: [PR] Core: Optimize manifest evaluation for super wide tables [iceberg]

Fokko commented on code in PR #9147: URL: https://github.com/apache/iceberg/pull/9147#discussion_r1411615389 ## api/src/main/java/org/apache/iceberg/expressions/NamedReference.java: ## @@ -38,7 +38,8 @@ public String name() { @Override public BoundReference bind(Types.St

Re: [PR] Build: Bump datamodel-code-generator from 0.24.2 to 0.25.0 [iceberg]

dependabot[bot] commented on PR #9158: URL: https://github.com/apache/iceberg/pull/9158#issuecomment-1835470889 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

Re: [PR] Build: Bump datamodel-code-generator from 0.24.2 to 0.25.0 [iceberg]

Fokko closed pull request #9158: Build: Bump datamodel-code-generator from 0.24.2 to 0.25.0 URL: https://github.com/apache/iceberg/pull/9158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Build: Bump datamodel-code-generator from 0.24.2 to 0.25.0 [iceberg]

Fokko commented on PR #9158: URL: https://github.com/apache/iceberg/pull/9158#issuecomment-1835470824 Superseded by https://github.com/apache/iceberg/pull/9189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] Build: Bump datamodel-code-generator from 0.24.2 to 0.25.0 [iceberg]

Fokko opened a new pull request, #9189: URL: https://github.com/apache/iceberg/pull/9189 Bumps [datamodel-code-generator](https://github.com/koxudaxi/datamodel-code-generator) from 0.24.2 to 0.25.0. - [Release notes](https://github.com/koxudaxi/datamodel-code-generator/releases) - [

[I] Flink throw an exception while reading table data through icebergsource [iceberg]

AllenWee1106 opened a new issue, #9188: URL: https://github.com/apache/iceberg/issues/9188 ### Query engine flink --> icebergsource ### Question I have a difficult point and I need everyone's assistance, THX! flink on yarn throw exception: `java.util.concurrent.

Re: [PR] Build: Bump org.apache.httpcomponents.client5:httpclient5 from 5.2.1 to 5.2.2 [iceberg]

Fokko commented on PR #9157: URL: https://github.com/apache/iceberg/pull/9157#issuecomment-1835467709 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Build: Bump software.amazon.awssdk:bom from 2.21.26 to 2.21.29 [iceberg]

Fokko merged PR #9154: URL: https://github.com/apache/iceberg/pull/9154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] Build: Bump mkdocs-material from 9.4.10 to 9.4.12 [iceberg]

Fokko merged PR #9159: URL: https://github.com/apache/iceberg/pull/9159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] Core: Suppress exceptions in case of dropTableData [iceberg]

Fokko commented on PR #9184: URL: https://github.com/apache/iceberg/pull/9184#issuecomment-1835463313 Thanks for picking this up @nk1506! Left two minor comments, let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Core: Suppress exceptions in case of dropTableData [iceberg]

Fokko commented on code in PR #9184: URL: https://github.com/apache/iceberg/pull/9184#discussion_r1411609064 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -91,7 +90,12 @@ public static void dropTableData(FileIO io, TableMetadata metadata) { Set manifests

Re: [PR] Core: Suppress exceptions in case of dropTableData [iceberg]

Fokko commented on code in PR #9184: URL: https://github.com/apache/iceberg/pull/9184#discussion_r1411608715 ## core/src/main/java/org/apache/iceberg/CatalogUtil.java: ## @@ -150,8 +154,7 @@ private static void deleteFiles(FileIO io, Set allManifests) { String

Re: [PR] Spark: Bump Spark minor versions for 3.3 and 3.4 [iceberg]

ajantha-bhat commented on code in PR #9187: URL: https://github.com/apache/iceberg/pull/9187#discussion_r1411600157 ## gradle/libs.versions.toml: ## @@ -77,8 +77,8 @@ scala-collection-compat = "2.11.0" slf4j = "1.7.36" snowflake-jdbc = "3.14.3" spark-hive32 = "3.2.2" -spark-h

Re: [PR] Build: Upgrade to gradle 8.4 [iceberg]

jbonofre commented on PR #8486: URL: https://github.com/apache/iceberg/pull/8486#issuecomment-1835446041 I'm resuming my work on this one, upgrading to Gradle 8.5 and proposing a fix for revapi. I will share details soon. -- This is an automated message from the Apache Git Service. To res

Re: [I] Upgrade to gradle 8.5 [iceberg]

jbonofre commented on issue #8485: URL: https://github.com/apache/iceberg/issues/8485#issuecomment-1835445391 I'm resuming my work on this issue, upgrading to Gradle 8.5 and dealing with revapi. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] An exception occurred while writing iceberg data through Spark: org. apache. iceberg. exceptions. CommitFailedException: metadata location has changed [iceberg]

AllenWee1106 commented on issue #9178: URL: https://github.com/apache/iceberg/issues/9178#issuecomment-1835398678 @nk1506 @ismailsimsek THX, What is the maximum concurrent write supported by Iceberg? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] chore: junit 5 migration for TestFlinkScan [iceberg]

cgpoh commented on code in PR #9185: URL: https://github.com/apache/iceberg/pull/9185#discussion_r1411525318 ## flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkInputFormat.java: ## @@ -33,24 +33,20 @@ import org.apache.iceberg.Schema; import org.apache

Re: [PR] test: Add integration tests for rest catalog. [iceberg-rust]

liurenjie1024 commented on code in PR #109: URL: https://github.com/apache/iceberg-rust/pull/109#discussion_r1411522039 ## crates/catalog/rest/tests/rest_catalog_test.rs: ## @@ -0,0 +1,376 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] test: Add integration tests for rest catalog. [iceberg-rust]

liurenjie1024 commented on code in PR #109: URL: https://github.com/apache/iceberg-rust/pull/109#discussion_r1411522039 ## crates/catalog/rest/tests/rest_catalog_test.rs: ## @@ -0,0 +1,376 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

Re: [PR] test: Add integration tests for rest catalog. [iceberg-rust]

liurenjie1024 commented on code in PR #109: URL: https://github.com/apache/iceberg-rust/pull/109#discussion_r1411521057 ## crates/catalog/rest/Cargo.toml: ## @@ -40,5 +41,7 @@ urlencoding = { workspace = true } uuid = { workspace = true, features = ["v4"] } [dev-dependencies

Re: [I] iceberg HiveCatalog insert exception of GSS initiate failed [iceberg]

lizu18xz commented on issue #3127: URL: https://github.com/apache/iceberg/issues/3127#issuecomment-1835309336 > The root cause is that the Hive Client CliDriver does not write the HMS DelegationToken into the UGI, while HiveServer2 has done. Hello, may I ask when this problem can be r

Re: [PR] chore: junit 5 migration for TestFlinkScan [iceberg]

cgpoh commented on code in PR #9185: URL: https://github.com/apache/iceberg/pull/9185#discussion_r1411517558 ## flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/HadoopCatResource.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Flink: Document watermark generation feature [iceberg]

mas-chen commented on code in PR #9179: URL: https://github.com/apache/iceberg/pull/9179#discussion_r1411460488 ## docs/flink-queries.md: ## @@ -277,6 +277,58 @@ DataStream stream = env.fromSource(source, WatermarkStrategy.noWatermarks() "Iceberg Source as Avro GenericReco

Re: [PR] Flink: Fix IcebergSource tableloader lifecycle management in batch mode [iceberg]

mas-chen commented on code in PR #9173: URL: https://github.com/apache/iceberg/pull/9173#discussion_r1411458771 ## flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java: ## @@ -197,17 +203,21 @@ private SplitEnumerator createEnumer LOG.info(

Re: [I] Simplify JDK build versions using --release flag [iceberg]

github-actions[bot] commented on issue #7440: URL: https://github.com/apache/iceberg/issues/7440#issuecomment-1835009496 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Scope the annotations so that they don't show up as a dependency in the pom.xml for org.apache.iceberg:iceberg-{api|core} [iceberg]

github-actions[bot] commented on issue #7756: URL: https://github.com/apache/iceberg/issues/7756#issuecomment-1835008976 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [PR] Flink: Document watermark generation feature [iceberg]

stevenzwu commented on code in PR #9179: URL: https://github.com/apache/iceberg/pull/9179#discussion_r1411432735 ## docs/flink-queries.md: ## @@ -277,6 +277,58 @@ DataStream stream = env.fromSource(source, WatermarkStrategy.noWatermarks() "Iceberg Source as Avro GenericRec

Re: [PR] Flink: Document watermark generation feature [iceberg]

stevenzwu commented on code in PR #9179: URL: https://github.com/apache/iceberg/pull/9179#discussion_r1411432735 ## docs/flink-queries.md: ## @@ -277,6 +277,58 @@ DataStream stream = env.fromSource(source, WatermarkStrategy.noWatermarks() "Iceberg Source as Avro GenericRec

Re: [PR] Flink: Document watermark generation feature [iceberg]

stevenzwu commented on code in PR #9179: URL: https://github.com/apache/iceberg/pull/9179#discussion_r1411428437 ## docs/flink-queries.md: ## @@ -277,6 +277,58 @@ DataStream stream = env.fromSource(source, WatermarkStrategy.noWatermarks() "Iceberg Source as Avro GenericRec

Re: [PR] Core: Expired Snapshot files in a transaction should be deleted. [iceberg]

bartash commented on PR #9183: URL: https://github.com/apache/iceberg/pull/9183#issuecomment-1834824627 @amogh-jahagirdar thanks for the helpful suggestions. I pushed a new version. Changes from version 1: - Used the term “manifest list file” instead of “snapshot file”. - Fixed th

Re: [PR] iceberg-parquet: Switch tests to JUnit5 + AssertJ-style assertions [iceberg]

GianlucaPrincipini commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1411351531 ## parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java: ## @@ -79,16 +53,39 @@ import org.apache.parquet.hadoop.metadata.Colu

[PR] Build: Bump mypy-boto3-glue from 1.29.2 to 1.33.5 [iceberg-python]

dependabot[bot] opened a new pull request, #172: URL: https://github.com/apache/iceberg-python/pull/172 Bumps [mypy-boto3-glue](https://github.com/youtype/mypy_boto3_builder) from 1.29.2 to 1.33.5. Commits See full diff in https://github.com/youtype/mypy_boto3_builder/commits";

Re: [PR] Build: Bump mypy-boto3-glue from 1.29.2 to 1.33.0 [iceberg-python]

dependabot[bot] closed pull request #171: Build: Bump mypy-boto3-glue from 1.29.2 to 1.33.0 URL: https://github.com/apache/iceberg-python/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Build: Bump mypy-boto3-glue from 1.29.2 to 1.33.0 [iceberg-python]

dependabot[bot] commented on PR #171: URL: https://github.com/apache/iceberg-python/pull/171#issuecomment-1834648908 Superseded by #172. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Flink: Document watermark generation feature [iceberg]

mas-chen commented on code in PR #9179: URL: https://github.com/apache/iceberg/pull/9179#discussion_r1411286325 ## docs/flink-queries.md: ## @@ -277,6 +277,58 @@ DataStream stream = env.fromSource(source, WatermarkStrategy.noWatermarks() "Iceberg Source as Avro GenericReco

Re: [PR] Flink: Document watermark generation feature [iceberg]

stevenzwu commented on code in PR #9179: URL: https://github.com/apache/iceberg/pull/9179#discussion_r1411207388 ## docs/flink-queries.md: ## @@ -277,6 +277,66 @@ DataStream stream = env.fromSource(source, WatermarkStrategy.noWatermarks() "Iceberg Source as Avro GenericRec

Re: [PR] Docs: Clarified Partition Transform [iceberg]

jasonmfehr commented on PR #8337: URL: https://github.com/apache/iceberg/pull/8337#issuecomment-1834281053 @dramaticlly -- following up on the PR. It fell off my radar. Can you please re-review? -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Api: Track partition statistics via TableMetadata [iceberg]

ajantha-bhat commented on PR #8502: URL: https://github.com/apache/iceberg/pull/8502#issuecomment-1834166805 > Ack, will review this week. Thanks. Also, please include https://github.com/apache/iceberg/pull/9170 in the review -- This is an automated message from the Apache Git

[I] Inconsistent query results after partition key change [iceberg]

jessiedanwang opened a new issue, #9186: URL: https://github.com/apache/iceberg/issues/9186 ### Apache Iceberg version 1.2.0 ### Query engine Spark ### Please describe the bug 🐞 the dataset was partitioned using month(timestamp col), then partition key chan

Re: [PR] iceberg-parquet: Switch tests to JUnit5 + AssertJ-style assertions [iceberg]

wanglijie95 commented on code in PR #9161: URL: https://github.com/apache/iceberg/pull/9161#discussion_r1410907370 ## parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java: ## @@ -79,16 +53,39 @@ import org.apache.parquet.hadoop.metadata.ColumnChunk

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

ajantha-bhat commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1410902735 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieUtil.java: ## @@ -165,4 +180,95 @@ public static TableMetadata updateTableMetadataWithNessieSpecificProper

Re: [I] Create JUnit5-version of FlinkCatalogTestBase [iceberg]

wanglijie95 commented on issue #9079: URL: https://github.com/apache/iceberg/issues/9079#issuecomment-1834057254 Hi @nastra , I'm interested in working on this issue, can I take it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] feat: suport read/write Manifest [iceberg-rust]

ZENOTME commented on PR #79: URL: https://github.com/apache/iceberg-rust/pull/79#issuecomment-1834010470 Seem the binary file will make typos fail. Maybe we should fix #70 first. Other parts is ready to review. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

nk1506 commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1410847819 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -328,6 +346,14 @@ private void setHmsTableParameters( Set obsoleteProps,

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

nk1506 commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1410845873 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -162,8 +163,11 @@ protected void doRefresh() { Thread.currentThread().inte

Re: [PR] feat: suport read/write Manifest [iceberg-rust]

ZENOTME commented on PR #79: URL: https://github.com/apache/iceberg-rust/pull/79#issuecomment-1834001803 Sorry for being late. The #82 has closed. Let's move again. I have fixed the problem mentioned above and recommit. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Nessie: Support views for NessieCatalog [iceberg]

snazy commented on code in PR #8909: URL: https://github.com/apache/iceberg/pull/8909#discussion_r1410794852 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java: ## @@ -347,4 +327,73 @@ private TableIdentifier identifierWithoutTableReference( protected Map pr

Re: [PR] JDBC catalog fix namespaceExists check [iceberg]

ismailsimsek commented on PR #8340: URL: https://github.com/apache/iceberg/pull/8340#issuecomment-1833943008 @nastra @Fokko if you have time, could you please review it too? it should be ready. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1410794266 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -162,8 +163,11 @@ protected void doRefresh() { Thread.currentThread().inter

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1410792115 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -328,6 +346,14 @@ private void setHmsTableParameters( Set obsoleteProps,

Re: [PR] Nessie: reimplement namespace operations [iceberg]

snazy commented on code in PR #8857: URL: https://github.com/apache/iceberg/pull/8857#discussion_r1410786552 ## nessie/src/test/java/org/apache/iceberg/nessie/TestMultipleClients.java: ## @@ -67,33 +71,84 @@ public void afterEach() throws Exception { } @Test - public vo

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

nk1506 commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1410775536 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -162,8 +163,11 @@ protected void doRefresh() { Thread.currentThread().inte

Re: [PR] chore: junit 5 migration for TestFlinkScan [iceberg]

pvary commented on code in PR #9185: URL: https://github.com/apache/iceberg/pull/9185#discussion_r1410770854 ## flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkSrc.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] chore: junit 5 migration for TestFlinkScan [iceberg]

pvary commented on code in PR #9185: URL: https://github.com/apache/iceberg/pull/9185#discussion_r1410768638 ## flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkInputFormat.java: ## @@ -33,24 +33,20 @@ import org.apache.iceberg.Schema; import org.apache

Re: [PR] chore: junit 5 migration for TestFlinkScan [iceberg]

pvary commented on code in PR #9185: URL: https://github.com/apache/iceberg/pull/9185#discussion_r1410762888 ## flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java: ## @@ -288,14 +294,13 @@ private static void assertEquals( ByteBuffer bb = ByteBuff

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

nk1506 commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1410762191 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -328,6 +346,14 @@ private void setHmsTableParameters( Set obsoleteProps,

Re: [PR] Nessie: reimplement namespace operations [iceberg]

snazy commented on code in PR #8857: URL: https://github.com/apache/iceberg/pull/8857#discussion_r1410760088 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -323,28 +417,13 @@ public void renameTable(TableIdentifier from, TableIdentifier to) {

Re: [PR] chore: junit 5 migration for TestFlinkScan [iceberg]

pvary commented on code in PR #9185: URL: https://github.com/apache/iceberg/pull/9185#discussion_r1410759259 ## flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java: ## @@ -193,75 +192,81 @@ private static void assertEquals( return; } -Asse

Re: [PR] chore: junit 5 migration for TestFlinkScan [iceberg]

pvary commented on code in PR #9185: URL: https://github.com/apache/iceberg/pull/9185#discussion_r1410758396 ## flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/HadoopCatResource.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1410742413 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -162,8 +163,11 @@ protected void doRefresh() { Thread.currentThread().inter

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1410736513 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -328,6 +346,14 @@ private void setHmsTableParameters( Set obsoleteProps,

Re: [PR] Parquet: Move to ValueReader generation to a visitor [iceberg]

Fokko commented on PR #9063: URL: https://github.com/apache/iceberg/pull/9063#issuecomment-1833850530 @aokolnychyi do you have a spare cycle for reviewing this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Flink: Document watermark generation feature [iceberg]

pvary commented on code in PR #9179: URL: https://github.com/apache/iceberg/pull/9179#discussion_r1410623023 ## docs/flink-queries.md: ## @@ -277,6 +277,58 @@ DataStream stream = env.fromSource(source, WatermarkStrategy.noWatermarks() "Iceberg Source as Avro GenericRecord"

Re: [PR] Flink: Document watermark generation feature [iceberg]

pvary commented on code in PR #9179: URL: https://github.com/apache/iceberg/pull/9179#discussion_r1410620614 ## docs/flink-queries.md: ## @@ -277,6 +277,58 @@ DataStream stream = env.fromSource(source, WatermarkStrategy.noWatermarks() "Iceberg Source as Avro GenericRecord"

Re: [PR] Flink: Document watermark generation feature [iceberg]

pvary commented on code in PR #9179: URL: https://github.com/apache/iceberg/pull/9179#discussion_r1410618695 ## docs/flink-queries.md: ## @@ -277,6 +277,58 @@ DataStream stream = env.fromSource(source, WatermarkStrategy.noWatermarks() "Iceberg Source as Avro GenericRecord"

Re: [PR] Flink: Document watermark generation feature [iceberg]

pvary commented on code in PR #9179: URL: https://github.com/apache/iceberg/pull/9179#discussion_r1410618353 ## docs/flink-queries.md: ## @@ -277,6 +277,58 @@ DataStream stream = env.fromSource(source, WatermarkStrategy.noWatermarks() "Iceberg Source as Avro GenericRecord"

Re: [PR] Flink: Document watermark generation feature [iceberg]

pvary commented on code in PR #9179: URL: https://github.com/apache/iceberg/pull/9179#discussion_r1410617511 ## docs/flink-queries.md: ## @@ -277,6 +277,58 @@ DataStream stream = env.fromSource(source, WatermarkStrategy.noWatermarks() "Iceberg Source as Avro GenericRecord"

Re: [PR] Flink: Document watermark generation feature [iceberg]

pvary commented on code in PR #9179: URL: https://github.com/apache/iceberg/pull/9179#discussion_r1410606706 ## docs/flink-queries.md: ## @@ -277,6 +277,58 @@ DataStream stream = env.fromSource(source, WatermarkStrategy.noWatermarks() "Iceberg Source as Avro GenericRecord"

Re: [PR] Flink: Document watermark generation feature [iceberg]

pvary commented on code in PR #9179: URL: https://github.com/apache/iceberg/pull/9179#discussion_r1410598890 ## docs/flink-queries.md: ## @@ -277,6 +277,58 @@ DataStream stream = env.fromSource(source, WatermarkStrategy.noWatermarks() "Iceberg Source as Avro GenericRecord"

Re: [I] An exception occurred while writing iceberg data through Spark: org. apache. iceberg. exceptions. CommitFailedException: metadata location has changed [iceberg]

ismailsimsek commented on issue #9178: URL: https://github.com/apache/iceberg/issues/9178#issuecomment-1833596213 @nk1506 @AllenWee1106 correct that will be my guess to, concurrent write to same table -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Core: Optimize manifest evaluation for super wide tables [iceberg]

irshadcc commented on PR #9147: URL: https://github.com/apache/iceberg/pull/9147#issuecomment-1833511276 @rdblue I would really appreciate if you could take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] test: Add integration tests for rest catalog. [iceberg-rust]

Xuanwo commented on code in PR #109: URL: https://github.com/apache/iceberg-rust/pull/109#discussion_r1410479056 ## crates/catalog/rest/tests/rest_catalog_test.rs: ## @@ -0,0 +1,376 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

Re: [I] An exception occurred while writing iceberg data through Spark: org. apache. iceberg. exceptions. CommitFailedException: metadata location has changed [iceberg]

nk1506 commented on issue #9178: URL: https://github.com/apache/iceberg/issues/9178#issuecomment-1833467461 As per implementation [validateMetadataLocation](https://github.com/apache/iceberg/blob/d247b20f166ccb0b92443d4b05330b1e0d9c5d49/core/src/main/java/org/apache/iceberg/jdbc/JdbcTableOpe

Re: [PR] Flink: Fix IcebergSource tableloader lifecycle management in batch mode [iceberg]

pvary commented on code in PR #9173: URL: https://github.com/apache/iceberg/pull/9173#discussion_r1410384938 ## flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java: ## @@ -197,17 +203,21 @@ private SplitEnumerator createEnumer LOG.info(