pvary commented on code in PR #9185:
URL: https://github.com/apache/iceberg/pull/9185#discussion_r1410762888
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##########
@@ -288,14 +294,13 @@ private static void assertEquals(
ByteBuffer bb = ByteBuffer.wrap((byte[]) actual);
long firstLong = bb.getLong();
long secondLong = bb.getLong();
- Assert.assertEquals(
- "UUID should be equal",
- expected.toString(),
- new UUID(firstLong, secondLong).toString());
+ Assertions.assertThat(new UUID(firstLong, secondLong).toString())
+ .as("UUID should be equal")
+ .isEqualTo(expected.toString());
break;
case FIXED:
Assertions.assertThat(expected).as("Should expect
byte[]").isInstanceOf(byte[].class);
- Assert.assertArrayEquals("binary should be equal", (byte[]) expected,
(byte[]) actual);
+ Assertions.assertThat((byte[]) actual).as("binary should be
equal").isEqualTo(expected);
Review Comment:
Could we do chaining?
```
Assertions.assertThat(expected)
.as("Should expect byte[]")
.isInstanceOf(byte[].class)
.isEqualTo(actual);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
