pvary commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1410736513
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -328,6 +346,14 @@ private void setHmsTableParameters(
Set<String> obsoleteProps,
boolean hiveEngineEnabled,
Map<String, String> summary) {
+
+ setHmsParameters(
Review Comment:
previously we did this:
- Set up `parameters` based on the `table.getParameters()`
- Added `metadata.uuid` to the `parameters`
- Removed `obsoleteProps` from the `parameters`
- Added `TABLE_TYPE_PROP`, `METADATA_LOCATION_PROP`,
`PREVIOUS_METADATA_LOCATION_PROP` to the `parameters`
- Added `schema` to the `parameters`
After the change we do this:
- Set up `parameters` based on the `table.getParameters()`
- Added `metadata.uuid` to the `parameters`
- Added `TABLE_TYPE_PROP`, `METADATA_LOCATION_PROP`,
`PREVIOUS_METADATA_LOCATION_PROP` to the `parameters`
- Added `schema` to the `parameters`
- And remove the `obsoleteProps` only here
Would this mean that the TABLE_TYPE_PROP, METADATA_LOCATION_PROP,
PREVIOUS_METADATA_LOCATION_PROP, Schema is removed, if they get into the
`obsoleteProps`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
