nk1506 commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1410762191
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -328,6 +346,14 @@ private void setHmsTableParameters(
Set<String> obsoleteProps,
boolean hiveEngineEnabled,
Map<String, String> summary) {
+
+ setHmsParameters(
Review Comment:
Yes there are chances if `obsoleteProps` has those keys it will be removed.
But I think here `obsoleteProps` should contain iceberg specific properties not
these standard keys. But to be safer do you think I should move
[setHmsParameters](https://github.com/apache/iceberg/pull/8907/files#diff-e502621d52f86cf0ec3187dda30ac61f6b76efb7b6276bc8d233ccb2c836fb98R350)
after `obsoleteProps.forEach(parameters::remove);`
WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
