nk1506 commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1410845873
########## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ########## @@ -162,8 +163,11 @@ protected void doRefresh() { Thread.currentThread().interrupt(); throw new RuntimeException("Interrupted during refresh", e); } - - refreshFromMetadataLocation(metadataLocation, metadataRefreshMaxRetries); + if (table != null && table.getTableType().equalsIgnoreCase(TableType.VIRTUAL_VIEW.name())) { + disableRefresh(); Review Comment: Since we are using `ViewCatalogTests` error should be also consistent with test cases. We have different errors for different scenarios. IMO it is better to have the consistency with other catalogs. WDYT ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org