bartash commented on PR #9183: URL: https://github.com/apache/iceberg/pull/9183#issuecomment-1834824627
@amogh-jahagirdar thanks for the helpful suggestions. I pushed a new version. Changes from version 1: - Used the term “manifest list file” instead of “snapshot file”. - Fixed the order of expected and actual parameters in my added assertions in TestSequenceNumberForV2Table. - Added a new test in TestRemoveSnapshots(). The existing mechanism for tracking deleted files in TestRemoveSnapshots does not work for deletes inside transactions as the function passed in deleteWith() is called before the files are actually deleted in BaseTransaction, which is where my fix is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
