Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

[via GitHub]

nk1506 commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1410775536


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -162,8 +163,11 @@ protected void doRefresh() {
       Thread.currentThread().interrupt();
       throw new RuntimeException("Interrupted during refresh", e);
     }
-
-    refreshFromMetadataLocation(metadataLocation, metadataRefreshMaxRetries);
+    if (table != null && 
table.getTableType().equalsIgnoreCase(TableType.VIRTUAL_VIEW.name())) {
+      disableRefresh();

Review Comment:
   In Case of `Table` is being created with the same name as `view` it can fail 
while doing tableOperations so we should must stop this for refresh. Attaching 
a screenshot for better views. 
   ![Screenshot 2023-11-30 at 8 11 51 
PM](https://github.com/apache/iceberg/assets/4146188/24a0e000-e919-4522-99ba-7ec1415a9d81)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org