nk1506 commented on code in PR #9184:
URL: https://github.com/apache/iceberg/pull/9184#discussion_r1411662284
##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -91,7 +90,12 @@ public static void dropTableData(FileIO io, TableMetadata
metadata) {
Set<ManifestFile> manifestsToDelete = Sets.newHashSet();
for (Snapshot snapshot : metadata.snapshots()) {
// add all manifests to the delete set because both data and delete
files should be removed
- Iterables.addAll(manifestsToDelete, snapshot.allManifests(io));
+ try {
+ Iterables.addAll(manifestsToDelete, snapshot.allManifests(io));
+ } catch (RuntimeException e) {
Review Comment:
`NoSuchKeyException` is very much storage specific. We will have come with a
approach to generalize it for all the file systems like **(S3/Azure/GCS)** .
Please share your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
