Re: [PATCH] testsuite: Add require target for SJLJ exception implementation

2025-04-24 Thread Jeff Law
On 4/24/25 12:22 PM, Dimitar Dimitrov wrote: Testcases for musttail call optimization fail on pru-unknown-elf: FAIL: c-c++-common/musttail14.c -std=gnu++17 (test for excess errors) Excess errors: .../gcc/gcc/testsuite/c-c++-common/musttail14.c:37:14: error: cannot tail-call: caller

Re: [PATCH] testsuite: Skip tests incompatible with generic thunk support

2025-04-24 Thread Bernhard Reutner-Fischer
>> * lib/target-supports.exp >> (check_effective_target_variadic_mi_thunk): New function. >OK. >jeff > Please document new effective_target checks in sourcebuild.texi thanks

Re: [PATCH] testsuite: Skip tests incompatible with generic thunk support

2025-04-24 Thread Jeff Law
On 4/24/25 12:23 PM, Dimitar Dimitrov wrote: Some backends do not define TARGET_ASM_OUTPUT_MI_THUNK. But the generic thunk support cannot emit code for calling variadic methods of multiple-inheritance classes. Example error for pru-unknown-elf: .../gcc/gcc/testsuite/g++.dg/ipa/pr83549.C:7

[PATCH] testsuite: Skip tests incompatible with generic thunk support

2025-04-24 Thread Dimitar Dimitrov
Some backends do not define TARGET_ASM_OUTPUT_MI_THUNK. But the generic thunk support cannot emit code for calling variadic methods of multiple-inheritance classes. Example error for pru-unknown-elf: .../gcc/gcc/testsuite/g++.dg/ipa/pr83549.C:7:24: error: generic thunk code fails for method 'v

[PATCH] testsuite: Add require target for SJLJ exception implementation

2025-04-24 Thread Dimitar Dimitrov
Testcases for musttail call optimization fail on pru-unknown-elf: FAIL: c-c++-common/musttail14.c -std=gnu++17 (test for excess errors) Excess errors: .../gcc/gcc/testsuite/c-c++-common/musttail14.c:37:14: error: cannot tail-call: caller uses sjlj exceptions Silence these errors by disabli

Re: [PATCH] testsuite: AMDGCN test for vect-early-break_38.c as well to consistent architecture [PR119286]

2025-04-23 Thread Richard Biener
On Wed, 23 Apr 2025, Tamar Christina wrote: > Hi All, > > I had missed this one during the AMDGCN test failures. > > Like vect-early-break_18.c this test is also scalaring the > loads and thus leading to unexpected vectorization for this > testcase. > > Bootstrapped Regtested on aarch64-none-li

[PATCH] testsuite: AMDGCN test for vect-early-break_38.c as well to consistent architecture [PR119286]

2025-04-22 Thread Tamar Christina
Hi All, I had missed this one during the AMDGCN test failures. Like vect-early-break_18.c this test is also scalaring the loads and thus leading to unexpected vectorization for this testcase. Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. Cross checked the failing case on amdgc

Re: [PATCH] testsuite: Use sigsetjmp in gcc.misc-tests/gcov-31.c

2025-04-22 Thread Jørgen Kvalsvik
Hi, Thanks for fixing this. I just checked glibc, which implements __sigsetjmp as: # define sigsetjmp(env, savemask) __sigsetjmp (env, savemask) So I would think this is fine. I leave the ack to the Jakub, Richard et al, of course. Thanks, Jørgen On 2025-04-22 10:33, Rainer Orth wrote: T

Re: [PATCH] testsuite: Use sigsetjmp in gcc.misc-tests/gcov-31.c

2025-04-22 Thread Richard Biener
On Tue, 22 Apr 2025, Rainer Orth wrote: > The gcc.misc-tests/gcov-31.c test FAILs on Solaris and Darwin: > > FAIL: gcc.misc-tests/gcov-31.c (test for excess errors) > > Excess errors: > /vol/gcc/src/hg/master/local/gcc/testsuite/gcc.misc-tests/gcov-31.c:23:5: > error: implicit declaration of fu

[PATCH] testsuite: Use sigsetjmp in gcc.misc-tests/gcov-31.c

2025-04-22 Thread Rainer Orth
The gcc.misc-tests/gcov-31.c test FAILs on Solaris and Darwin: FAIL: gcc.misc-tests/gcov-31.c (test for excess errors) Excess errors: /vol/gcc/src/hg/master/local/gcc/testsuite/gcc.misc-tests/gcov-31.c:23:5: error: implicit declaration of function '__sigsetjmp'; did you mean 'sigsetjmp'? [-Wimp

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-18 Thread Mike Stump
On Apr 10, 2025, at 6:38 AM, Christophe Lyon wrote: > > On Thu, 10 Apr 2025 at 15:29, Hans-Peter Nilsson wrote: >> >>> From: Christophe Lyon >>> Date: Thu, 10 Apr 2025 15:21:23 +0200 >> >> Not sure why I'm CC:ed on this one, not being a maintainer >> of the testsuite or targets where gcov tes

Re: [PATCH] testsuite: Use int size instead of alignment for pr116357.c

2025-04-18 Thread Jeff Law
On 1/29/25 11:35 AM, Dimitar Dimitrov wrote: The test case assumes that alignof(int)=sizeof(int). But for some targets this is not valid. For example, for PRU target, alignof(int)=1 but sizeof(int)=4. Fix the test case to align to twice the size of int, as the expected dg-error messages sug

[PATCH] testsuite: g++.dg/cpp2a/constinit16.C requires tls

2025-04-17 Thread Christophe Lyon
This test is 'dg-do compile', so require tls instead of tls_runtime. This enables it on targets such as arm-none-eabi configured with --enable-threads=no. gcc/testsuite/ChangeLog: * g++.dg/cpp2a/constinit16.C: Require tls. --- gcc/testsuite/g++.dg/cpp2a/constinit16.C | 2 +- 1 file chan

[PATCH] testsuite: g++.dg/cpp2a/decomp2.C requires tls_runtime

2025-04-17 Thread Christophe Lyon
Since this test is a 'dg-do run', it requires tls_runtime rather than just tls. This makes the test UNSUPPORTED on targets such as arm-non-eabi, instead of FAIL/UNRESOLVED because __aeabi_read_tp is not provided (e.g. when GCC is configured with --enable-threads=no. gcc/testsuite/ChangeLog:

Re: [PATCH] [testsuite] [ppc] require ifunc for target_clones test

2025-04-16 Thread Peter Bergner
On 4/11/25 1:08 PM, Alexandre Oliva wrote: > > gcc.target/powerpc/power11-3.c uses target_clones, that depends on > ifunc. Require ifunc support. This looks "obvious" to me. The only systems we (IBM) have access to build and test on all have ifunc support, so we clearly didn't hit this ourselve

Re: [PATCH] [testsuite] [ppc] block-cmp-8 should require powerpc64

2025-04-16 Thread Peter Bergner
On 4/16/25 12:27 AM, Alexandre Oliva wrote: > Since that sort of broad change will presumably not make gcc-15 (it > wouldn't fix a regression, not even the problem addressed by the > upthread patch), Yes, the patch to change powerpc64 -> powerpc64_hw is definitely a gcc-16 patch. > ...may I un

Re: [PATCH] [testsuite] [ppc] compile [PR112822] with -mvsx

2025-04-16 Thread Peter Bergner
On 4/15/25 11:44 PM, Alexandre Oliva wrote: > On Apr 15, 2025, Peter Bergner wrote: >> I have verified the modified test case ICEs with the exact same >> error as the original test case using the commit immediately >> before the commit the fixed the ICE. > > Awesome, thanks! I hereby withdraw th

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-16 Thread Christophe Lyon
On Wed, 16 Apr 2025 at 16:14, Hans-Peter Nilsson wrote: > > > From: Christophe Lyon > > Date: Wed, 16 Apr 2025 14:41:17 +0200 > > > ping? > > Since you directed it at me and CC:ed the list; in case that > was deliberate: I can only repeat "still ok", but I don't > have approval rights to the test

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-16 Thread Hans-Peter Nilsson
> From: Christophe Lyon > Date: Wed, 16 Apr 2025 14:41:17 +0200 > ping? Since you directed it at me and CC:ed the list; in case that was deliberate: I can only repeat "still ok", but I don't have approval rights to the testsuite parts. > > On Thu, 10 Apr 2025 at 15:48, Hans-Peter Nilsson wrot

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-16 Thread Christophe Lyon
ping? On Thu, 10 Apr 2025 at 15:48, Hans-Peter Nilsson wrote: > > > From: Christophe Lyon > > Date: Thu, 10 Apr 2025 15:38:48 +0200 > > > On Thu, 10 Apr 2025 at 15:29, Hans-Peter Nilsson wrote: > > > > > > > From: Christophe Lyon > > > > Date: Thu, 10 Apr 2025 15:21:23 +0200 > > > > > > Not su

Re: [PATCH] testsuite: force AMDGCN test for vect-early-break_18.c to consistent architecture [PR119286]

2025-04-16 Thread Andrew Stubbs
On 16/04/2025 08:57, Tamar Christina wrote: Hi All, The given test is intended to test vectorization of a strided access done by having a step of > 1. GCN target doesn't support load lanes, so the testcase is expected to fail, other targets create a permuted load here which we then then reject.

Re: [PATCH] testsuite: force AMDGCN test for vect-early-break_18.c to consistent architecture [PR119286]

2025-04-16 Thread Richard Biener
On Wed, 16 Apr 2025, Tamar Christina wrote: > Hi All, > > The given test is intended to test vectorization of a strided access done by > having a step of > 1. > > GCN target doesn't support load lanes, so the testcase is expected to fail, > other targets create a permuted load here which we then

[PATCH] testsuite: force AMDGCN test for vect-early-break_18.c to consistent architecture [PR119286]

2025-04-16 Thread Tamar Christina
Hi All, The given test is intended to test vectorization of a strided access done by having a step of > 1. GCN target doesn't support load lanes, so the testcase is expected to fail, other targets create a permuted load here which we then then reject. However some GCN arch don't seem to support

Re: [PATCH] [testsuite] [ppc] compile [PR112822] with -mvsx

2025-04-15 Thread Alexandre Oliva
On Apr 14, 2025, Peter Bergner wrote: > diff --git a/gcc/testsuite/g++.dg/pr112822.C b/gcc/testsuite/g++.dg/pr112822.C > -typedef __attribute__((altivec(vector__))) double co; > +typedef double co __attribute__ ((vector_size (16))); FWIW, I've tested this change on gcc-14 powerpc-elf and I confi

Re: [PATCH] [testsuite] [ppc] pr87600, pr89313: test for __PPC__ as well

2025-04-15 Thread Alexandre Oliva
On Apr 14, 2025, Peter Bergner wrote: > On 4/11/25 1:03 PM, Alexandre Oliva wrote: >> gcc.dg/pr87600.h and gcc.dg/pr89313.c test for __powerpc__ and >> __POWERPC__ to choose ppc register names, but ppc-elf defines neither; >> it defines __PPC__, so test for that as well. > Is there a reason why

Re: [PATCH] [testsuite] [ppc] block-cmp-8 should require powerpc64

2025-04-15 Thread Alexandre Oliva
On Apr 15, 2025, Peter Bergner wrote: > On 4/14/25 11:35 PM, Alexandre Oliva wrote: >>> That said, that should be done in a separate patch. >> >> *nod*. Do you mean you're going to make that change, that I should, or >> that you hope someone else will? I'd rather avoid duplication, and this >>

Re: [PATCH] [testsuite] [ppc] disable -mpowerpc64 for various ilp32 asm-out checks

2025-04-15 Thread Alexandre Oliva
On Apr 15, 2025, Peter Bergner wrote: > On 4/15/25 9:36 AM, Peter Bergner wrote: >> So what ABI does powerpc-elf use and what does it mandate? That's not for me to decide, but to me the patch that introduced OS_MISSING_POWERPC64 and the PR106680 coversation suggests that enabling -mpowerpc64 wit

Re: [PATCH] [testsuite] [ppc] compile [PR112822] with -mvsx

2025-04-15 Thread Alexandre Oliva
On Apr 15, 2025, Peter Bergner wrote: > On 4/14/25 11:30 PM, Alexandre Oliva wrote: >> On Apr 14, 2025, Peter Bergner wrote: >> >>> This is an architecture independent test case, so I'm surprised this >>> doesn't FAIL on non-powerpc targets since they don't know anything >>> about altivec. >>

Re: [PATCH] [testsuite] [ppc] compile [PR112822] with -mvsx

2025-04-15 Thread Peter Bergner
On 4/14/25 11:30 PM, Alexandre Oliva wrote: > On Apr 14, 2025, Peter Bergner wrote: > >> This is an architecture independent test case, so I'm surprised this >> doesn't FAIL on non-powerpc targets since they don't know anything >> about altivec. > > AFAICT we ignore attributes we don't know abou

Re: [PATCH] [testsuite] [ppc] disable -mpowerpc64 for various ilp32 asm-out checks

2025-04-15 Thread Peter Bergner
On 4/15/25 9:36 AM, Peter Bergner wrote: > On 4/15/25 12:01 AM, Alexandre Oliva wrote: >> On Apr 14, 2025, Peter Bergner wrote: >> >>> But -mcpu= should not enable -mpowerpc64 by default for -m32 compiles. >> >> Oh, is that so? It seems to have been the case for quite a long time. >> I can trivia

Re: [PATCH] [testsuite] [ppc] disable -mpowerpc64 for various ilp32 asm-out checks

2025-04-15 Thread Peter Bergner
On 4/15/25 12:01 AM, Alexandre Oliva wrote: > On Apr 14, 2025, Peter Bergner wrote: > >> But -mcpu= should not enable -mpowerpc64 by default for -m32 compiles. > > Oh, is that so? It seems to have been the case for quite a long time. > I can trivially see that GCC 9 already did that, but it may

Re: [PATCH] [testsuite] [ppc] block-cmp-8 should require powerpc64

2025-04-15 Thread Peter Bergner
On 4/14/25 11:35 PM, Alexandre Oliva wrote: >> That said, that should be done in a separate patch. > > *nod*. Do you mean you're going to make that change, that I should, or > that you hope someone else will? I'd rather avoid duplication, and this > is likely a somewhat involved change, since th

Re: [PATCH] [testsuite] [ppc] disable -mpowerpc64 for various ilp32 asm-out checks

2025-04-14 Thread Alexandre Oliva
On Apr 14, 2025, Peter Bergner wrote: > But -mcpu= should not enable -mpowerpc64 by default for -m32 compiles. Oh, is that so? It seems to have been the case for quite a long time. I can trivially see that GCC 9 already did that, but it may have been around for much longer than that. And TBH i

Re: [PATCH] [testsuite] [ppc] block-cmp-8 should require powerpc64

2025-04-14 Thread Alexandre Oliva
On Apr 14, 2025, Peter Bergner wrote: > That said, I hate the name "powerpc64" and it should probably be > renamed to "powerpc64_hw" to be more clear about what it's testing. Yeah, that would make sense. > That said, that should be done in a separate patch. *nod*. Do you mean you're going to

Re: [PATCH] [testsuite] [ppc] compile [PR112822] with -mvsx

2025-04-14 Thread Alexandre Oliva
On Apr 14, 2025, Peter Bergner wrote: > This is an architecture independent test case, so I'm surprised this > doesn't FAIL on non-powerpc targets since they don't know anything > about altivec. AFAICT we ignore attributes we don't know about. I'd think the following fix should help them too.

Re: [PATCH] [testsuite] [ppc] disable -mpowerpc64 for various ilp32 asm-out checks

2025-04-14 Thread Peter Bergner
On 4/11/25 1:05 PM, Alexandre Oliva wrote: > Multiple tests on ilp32 get TARGET_POWERPC64 enabled by -mdejagnu-cpu > options, but the results they expect are only attained without > enabling it, so disable it explicitly. [snip] > diff --git a/gcc/testsuite/gcc.target/powerpc/bfp/scalar-extract-sig-

Re: [PATCH] [testsuite] [ppc] block-cmp-8 should require powerpc64

2025-04-14 Thread Peter Bergner
On 4/11/25 1:04 PM, Alexandre Oliva wrote: > --- a/gcc/testsuite/gcc.target/powerpc/block-cmp-8.c > +++ b/gcc/testsuite/gcc.target/powerpc/block-cmp-8.c > @@ -1,6 +1,6 @@ > /* { dg-do run { target ilp32 } } */ > /* { dg-options "-O2 -mpowerpc64" } */ > -/* { dg-require-effective-target has_arch_p

Re: [PATCH] [testsuite] [ppc] pr87600, pr89313: test for __PPC__ as well

2025-04-14 Thread Peter Bergner
On 4/11/25 1:03 PM, Alexandre Oliva wrote: > gcc.dg/pr87600.h and gcc.dg/pr89313.c test for __powerpc__ and > __POWERPC__ to choose ppc register names, but ppc-elf defines neither; > it defines __PPC__, so test for that as well. Is there a reason why powerpc-*-elf doesn't define __powerpc__ or __P

Re: [PATCH] [testsuite] [ppc] ipa-sra-19.c: pass -Wno-psabi on powerpc-*-elf as well

2025-04-14 Thread Peter Bergner
On 4/11/25 1:01 PM, Alexandre Oliva wrote: > Like other ppc targets, powerpc-*-elf needs -Wno-psabi to compile > gcc.dg/ipa/ipa-sra-19.c without an undesired warning about vector > argument passing. > > Regstrapped on powerpc64le-linux-gnu. Also tested with gcc-14 on > x86_64-linux-x-powerpc-elf.

Re: [PATCH] [testsuite] [ppc] compile [PR112822] with -mvsx

2025-04-14 Thread Peter Bergner
On 4/11/25 12:57 PM, Alexandre Oliva wrote: > diff --git a/gcc/testsuite/g++.dg/pr112822.C b/gcc/testsuite/g++.dg/pr112822.C > index a8557522467d7..9ec5707eb4c4d 100644 > --- a/gcc/testsuite/g++.dg/pr112822.C > +++ b/gcc/testsuite/g++.dg/pr112822.C > @@ -1,6 +1,8 @@ > /* PR tree-optimization/11282

Re: [v2] Polish 'dg-output-file' test logs (was: [PATCH] testsuite: Add support for dg-output-file directive)

2025-04-14 Thread Jakub Jelinek
On Mon, Apr 14, 2025 at 07:47:21PM +0200, Thomas Schwinge wrote: > gcc/testsuite/ > * lib/gcc-dg.exp (${tool}_load): Polish 'dg-output-file' test > logs. > --- > gcc/testsuite/lib/gcc-dg.exp | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/gcc/testsuite

[v2] Polish 'dg-output-file' test logs (was: [PATCH] testsuite: Add support for dg-output-file directive)

2025-04-14 Thread Thomas Schwinge
Hi! On 2025-04-13T17:15:05+0200, I wrote: > On 2025-03-18T14:54:23+0100, Jakub Jelinek wrote: >> The following patch offers [...] dg-output-file >> directive where one can supply a text file with expected output > >> --- gcc/doc/sourcebuild.texi.jj 2025-03-11 09:18:21.750133577 +0100 >> +++

Polish 'dg-output-file' test logs (was: [PATCH] testsuite: Add support for dg-output-file directive)

2025-04-13 Thread Thomas Schwinge
Hi! On 2025-03-18T14:54:23+0100, Jakub Jelinek wrote: > The following patch offers [...] dg-output-file > directive where one can supply a text file with expected output > --- gcc/doc/sourcebuild.texi.jj 2025-03-11 09:18:21.750133577 +0100 > +++ gcc/doc/sourcebuild.texi 2025-03-18 14:41:5

[PATCH] testsuite: unxfail ira-shrinkwrap-prep-[12].c for x86_64 [PR117706]

2025-04-12 Thread Andrew Pinski
When late combine was enabled for x86_64 (r15-1735-ge62ea4fb8ffcab), these 2 testcases start to xpass in a similar fashion as when late combine was added and the testcase was updated for aarch64 not to xfail them there. Pushed as obvious after a test to make sure the testcase no longer xpass.

[PATCH] [testsuite] [ppc] pr87600, pr89313: test for __PPC__ as well

2025-04-11 Thread Alexandre Oliva
gcc.dg/pr87600.h and gcc.dg/pr89313.c test for __powerpc__ and __POWERPC__ to choose ppc register names, but ppc-elf defines neither; it defines __PPC__, so test for that as well. Regstrapped on powerpc64le-linux-gnu. Also tested with gcc-14 on x86_64-linux-x-powerpc-elf. Ok to install? for

[PATCH] [testsuite] [ppc] use dg-do-if in vec-mul.c

2025-04-11 Thread Alexandre Oliva
The overriding of dg-do in gcc.target/powerpc/vec-mul.c I put there last year didn't quite work. It needed the newly-added dg-do-if to work the way I wished. Fix it, and simplify it. While at that, I found out that when target matched, dg-do-if didn't call dg-do correctly, because it dropped t

[PATCH] [testsuite] [ppc] require vsx for vec-cmpne tests

2025-04-11 Thread Alexandre Oliva
The gcc.target/powerpc/vec-cmpne.c and .../vec-cmpne-runnable.c tests need both vsx and vmx support, but vsx is taken for granted, which doesn't hold on ppc-elf. Add the appropriate requirements and options. Regstrapped on powerpc64le-linux-gnu. Also tested with gcc-14 on x86_64-linux-x-powerp

[PATCH] [testsuite] [ppc] adjust vsx-builtin-7.c xxpermdi count for ilp32

2025-04-11 Thread Alexandre Oliva
gcc.target/powerpc/vsx-builtin-7.c uses fewer xxpermdi insns than expected on ilp32. Adjust. Regstrapped on powerpc64le-linux-gnu. Also tested with gcc-14 on x86_64-linux-x-powerpc-elf. Ok to install? for gcc/testsuite/ChangeLog * gcc.target/powerpc/vsx-builtin-7.c: Adjust xxpermdi

[PATCH] [testsuite] [ppc] tolerate -mfloat128 warning in pr99708.c

2025-04-11 Thread Alexandre Oliva
gcc.target/powerpc/pr99708.c uses -mfloat128, and that causes the usual "may not be fully supported" warning that we need to prune on such tests. Tolerate it. Regstrapped on powerpc64le-linux-gnu. Also tested with gcc-14 on x86_64-linux-x-powerpc-elf. Ok to install? for gcc/testsuite/Chang

[PATCH] [testsuite] [ppc] skip -msoft-float tests when testing with -mhard-float

2025-04-11 Thread Alexandre Oliva
Testing ppc-elf with -mhard-float conflicts with explicit -msoft-float in gcc.target/powerpc/ppc-fma-6.c and gcc.target/powerpc/pr105334.c. Skip these tests under -mhard-float. Regstrapped on powerpc64le-linux-gnu. Also tested with gcc-14 on x86_64-linux-x-powerpc-elf. Ok to install? for gc

[PATCH] [testsuite] [ppc] allow implicit fuction declarations in pr92661.c

2025-04-11 Thread Alexandre Oliva
gcc.target/powerpc/pr92661.c expects and tolerates errors about dfp builtins when dfp is not supported, but the C front end no longer accepts calls of undeclared functions by default, even with -w. Adding -fpermissive would do, but I thought it would be too broad, so I went for -Wno-error=implici

[PATCH] [testsuite] [ppc] add -mno-strict-align to pr111449-1.c

2025-04-11 Thread Alexandre Oliva
gcc.target/powerpc/pr111449-1.c's expected results only come about without strict alignment, so disable it explicitly. Regstrapped on powerpc64le-linux-gnu. Also tested with gcc-14 on x86_64-linux-x-powerpc-elf. Ok to install? for gcc/testsuite/ChangeLog * gcc.target/powerpc/pr1114

[PATCH] [testsuite] [ppc] require ifunc for target_clones test

2025-04-11 Thread Alexandre Oliva
gcc.target/powerpc/power11-3.c uses target_clones, that depends on ifunc. Require ifunc support. Regstrapped on powerpc64le-linux-gnu. Also tested with gcc-14 on x86_64-linux-x-powerpc-elf. Ok to install? for gcc/testsuite/ChangeLog * gcc.target/powerpc/power11-3.c: Require ifunc

[PATCH] [testsuite] [ppc] add -maltivec to pr111380-2.c

2025-04-11 Thread Alexandre Oliva
gcc.target/powerpc/pr111380-2.c requires altivec to be enabled to hit the expected option mismatch and inline error, so enable it after checking for compiler support. Regstrapped on powerpc64le-linux-gnu. Also tested with gcc-14 on x86_64-linux-x-powerpc-elf. Ok to install? for gcc/testsuit

[PATCH] [testsuite] [ppc] add -mdejagnu-cpu=power7 to pr17381.c

2025-04-11 Thread Alexandre Oliva
Below power7, it seems to be more profitable to compress the floating-point constants and use an additional fp register move to "extend" it. Only at power7 and above do we keep the constants separate and load them, getting to the expected 'fmr' count. Regstrapped on powerpc64le-linux-gnu. Also

[PATCH] [testsuite] [ppc] add -mfloat128 to pr67808.c

2025-04-11 Thread Alexandre Oliva
gcc.target/powerpc/pr67808.c in some cases expects both 128-bit long double types to be defined, but -mlong-double-128 doesn't guarantee that without -mfloat128 on targets that would get the IEEE128 type as long double. Add -mfloat128 to ensure the desired IBM 128-bit floating-point type is avai

[PATCH] [testsuite] [ppc] block-cmp-8 should require powerpc64

2025-04-11 Thread Alexandre Oliva
gcc.target/powerpc/block-cmp-8.c is an execution test on ilp32. It tests for support for the 64-bit ISA in the compiler, but not for the ability to execute powerpc64 instructions, so the test fails on 32-bit hardware. Require powerpc64 instead. Regstrapped on powerpc64le-linux-gnu. Also teste

[PATCH] [testsuite] [ppc] disable -mpowerpc64 for various ilp32 asm-out checks

2025-04-11 Thread Alexandre Oliva
Multiple tests on ilp32 get TARGET_POWERPC64 enabled by -mdejagnu-cpu options, but the results they expect are only attained without enabling it, so disable it explicitly. Regstrapped on powerpc64le-linux-gnu. Also tested with gcc-14 on x86_64-linux-x-powerpc-elf. Ok to install? for gcc/tes

[PATCH] [testsuite] [ppc] newlib sets FE_VXSOFT on raise FE_INVALID

2025-04-11 Thread Alexandre Oliva
The implementation of the fe*except primitives in newlib sets the FE_VXSOFT bit when raising FE_INVALID, and the test doesn't expect that. Skip it: the tested builtin expansions are for glibc only anyway. Regstrapped on powerpc64le-linux-gnu. Also tested with gcc-14 on x86_64-linux-x-powerpc-e

[PATCH] [testsuite] [ppc] xfail pr52451.c on ppc [PR58684]

2025-04-11 Thread Alexandre Oliva
Like pr91323.c, pr52451.c fails on all powerpc variants (except where already skipped), because it uses fcmpu even when qNaNs should flag FP exceptions. Regstrapped on powerpc64le-linux-gnu. Also tested with gcc-14 on x86_64-linux-x-powerpc-elf. Ok to install? for gcc/testsuite/ChangeLog

[PATCH] [testsuite] [ppc] add -mfloat128 to __ieee128-using bfp tests

2025-04-11 Thread Alexandre Oliva
Some ppc bfp tests use __ieee128 without ensuring it's available. Require ppc_ieee128_ok, add -mfloat128 to get the type defined, and tolerate the warning that this option may trigger. Regstrapped on powerpc64le-linux-gnu. Also tested with gcc-14 on x86_64-linux-x-powerpc-elf. Ok to install?

[PATCH] [testsuite] [ppc] ipa-sra-19.c: pass -Wno-psabi on powerpc-*-elf as well

2025-04-11 Thread Alexandre Oliva
Like other ppc targets, powerpc-*-elf needs -Wno-psabi to compile gcc.dg/ipa/ipa-sra-19.c without an undesired warning about vector argument passing. Regstrapped on powerpc64le-linux-gnu. Also tested with gcc-14 on x86_64-linux-x-powerpc-elf. Ok to install? for gcc/testsuite/ChangeLog

[PATCH] [testsuite] [ppc] require float128 available for copysign

2025-04-11 Thread Alexandre Oliva
The rs6000.md copysign3 expander requires the mode to satisfy FLOAT128_IEEE_P, so requiring float128 on ppc for ifn_copysign effective target is hopefully a close-enough approximation. gcc.dg/fold-copysign-1.c and gcc.dg/pr55152-2.c fail on ppc-elf without this. Regstrapped on powerpc64le-linux

[PATCH] [testsuite] [ppc] compile [PR112822] with -mvsx

2025-04-11 Thread Alexandre Oliva
g++.dg/pr112822.C uses altivec vectors explicitly, but it expects this feature to be enabled by default on targets that recognize the attribute, which is not a given on older ppc cpus, where the compiler recommends recompiling with -mvsx. Since it's just a compilation test, we don't seem to need t

[PATCH] testsuite: arm: Fix unsigned-extend-2.c [PR116445]

2025-04-11 Thread Christophe Lyon
The test was designed to pass with thumb2, but code generation changed with the introduction of Low Overhead Loops, so the test can fail if one overrides the flags when running the testsuite. In addition, useless subtract / extension instructions require -O2 to remove them (-O is not sufficient),

Re: [PATCH] testsuite: arm: rename arm_v8_1_lob_ok into arm_v8_1_lob_hw

2025-04-11 Thread Christophe Lyon
Hi! On Thu, 10 Apr 2025 at 19:13, Richard Earnshaw (lists) wrote: > > On 10/04/2025 14:55, Christophe Lyon wrote: > > All arm effective-targets using check_runtime use the "_hw" or > > "_multilib" suffix, so rename arm_v8_1_lob_ok into arm_v8_1_lob_hw for > > consistency. > > > > gcc/testsuite/Ch

Re: [PATCH] testsuite: arm: rename arm_v8_1_lob_ok into arm_v8_1_lob_hw

2025-04-10 Thread Richard Earnshaw (lists)
On 10/04/2025 14:55, Christophe Lyon wrote: > All arm effective-targets using check_runtime use the "_hw" or > "_multilib" suffix, so rename arm_v8_1_lob_ok into arm_v8_1_lob_hw for > consistency. > > gcc/testsuite/ChangeLog > > * lib/target-supports.exp: Rename arm_v8_1_lob_ok into >

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-10 Thread Christophe Lyon
On Thu, 10 Apr 2025 at 15:29, Hans-Peter Nilsson wrote: > > > From: Christophe Lyon > > Date: Thu, 10 Apr 2025 15:21:23 +0200 > > Not sure why I'm CC:ed on this one, not being a maintainer > of the testsuite or targets where gcov tests are exercised, Because you fixed a problem in r13-4103-ge91d

[PATCH] testsuite: arm: rename arm_v8_1_lob_ok into arm_v8_1_lob_hw

2025-04-10 Thread Christophe Lyon
All arm effective-targets using check_runtime use the "_hw" or "_multilib" suffix, so rename arm_v8_1_lob_ok into arm_v8_1_lob_hw for consistency. gcc/testsuite/ChangeLog * lib/target-supports.exp: Rename arm_v8_1_lob_ok into arm_v8_1_lob_hw. * gcc.target/arm/lob1.c: Likew

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-10 Thread Hans-Peter Nilsson
> From: Christophe Lyon > Date: Thu, 10 Apr 2025 15:38:48 +0200 > On Thu, 10 Apr 2025 at 15:29, Hans-Peter Nilsson wrote: > > > > > From: Christophe Lyon > > > Date: Thu, 10 Apr 2025 15:21:23 +0200 > > > > Not sure why I'm CC:ed on this one, not being a maintainer > > of the testsuite or target

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-10 Thread Hans-Peter Nilsson
> From: Christophe Lyon > Date: Thu, 10 Apr 2025 15:21:23 +0200 Not sure why I'm CC:ed on this one, not being a maintainer of the testsuite or targets where gcov tests are exercised, but FWIW: LGTM except for the two nits: > ping? > > On Tue, 1 Apr 2025 at 22:37, Christophe Lyon > wrote: > >

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-10 Thread Christophe Lyon
ping? On Tue, 1 Apr 2025 at 22:37, Christophe Lyon wrote: > > After commit r15-8947-g8ed2d5d219e999, which added new tests using > gcov, the CI noticed failures because it was calling 'gcov' instead of > $target-gcov. > > This is because the CI scripts override GXX_UNDER_TEST, but still run > the

[PATCH] testsuite: Add -mabi to pr116595.C

2025-04-09 Thread Robin Dapp
Hi, as usual, I forgot to add -mabi=lp64d to the test case. This patch adds it. Going to push as obvious. Regards Robin gcc/testsuite/ChangeLog: * g++.target/riscv/rvv/autovec/pr116595.C: Add -mabi. --- gcc/testsuite/g++.target/riscv/rvv/autovec/pr116595.C | 2 +- 1 file changed, 1 in

Re: [PATCH] testsuite: arm: Tighten compile options for short-vfp-1.c [PR119556]

2025-04-07 Thread Richard Earnshaw
On 06/04/2025 19:49, Christophe Lyon wrote: The previous version of this test required arch v6+ (for sxth), and the number of vmov depended on the float-point ABI (where softfp needed more of them to transfer floating-point values to and from general registers). With this patch we require arch v

[PATCH] testsuite: arm: Tighten compile options for short-vfp-1.c [PR119556]

2025-04-06 Thread Christophe Lyon
The previous version of this test required arch v6+ (for sxth), and the number of vmov depended on the float-point ABI (where softfp needed more of them to transfer floating-point values to and from general registers). With this patch we require arch v7-a, vfp FPU and -mfloat-abi=hard, we also use

Re: [PATCH] testsuite, cobol: Avoid adding duplicate libs.

2025-04-06 Thread Richard Biener
> Am 06.04.2025 um 09:44 schrieb Iain Sandoe : > > Tested on x86_64, aarch64, powerpc64le - Linux; x86_64, aarch64 Darwin, > OK for trunk? Ok Richard > thanks > Iain > > --- 8< --- > > The discovered paths already include the multilib and so there is > no need to add an extra library to

[PATCH] testsuite, cobol: Avoid adding duplicate libs.

2025-04-06 Thread Iain Sandoe
Tested on x86_64, aarch64, powerpc64le - Linux; x86_64, aarch64 Darwin, OK for trunk? thanks Iain --- 8< --- The discovered paths already include the multilib and so there is no need to add an extra library to COBOL_UNDER_TEST. Doing so makes a duplicate, which causes test fails on Darwin, where

Re: [PATCH] [testsuite] [riscv] xfail ssa-dom-cse-2 on riscv64

2025-04-05 Thread Jeff Law
On 3/31/25 12:59 PM, Alexandre Oliva wrote: For the same reasons that affect alpha and other targets, gcc.dg/tree-ssa/ssa-dom-cse-2.c fails to be optimized to the expected return statement: the array initializer is vectorized into pairs, and DOM cannot see through that. Add riscv*-*-* to the

Re: [PATCH] testsuite: Fix up strub-internal-pr112938.C test for C++2{0,3,6}

2025-04-05 Thread Sam James
Jakub Jelinek writes: > On Thu, Mar 27, 2025 at 12:05:21AM +, Sam James wrote: >> The test was being ignored because dg.exp looks for .C in g++.dg/. >> >> gcc/testsuite/ChangeLog: >> PR middle-end/112938 >> >> * g++.dg/strub-internal-pr112938.cc: Move to... >> * g++.dg/strub-

Re: [PATCH] testsuite: i386: Fix c-c++-common/gomp/metadirective-device.c etc. with i?86 compiler

2025-04-05 Thread Jakub Jelinek
On Wed, Mar 26, 2025 at 02:24:04PM +0100, Rainer Orth wrote: > 2025-03-25 Rainer Orth > > gcc/testsuite: > * c-c++-common/gomp/metadirective-device.c > (dg-additional-options): Use on all x86 targets. Restrict to lp64. > * c-c++-common/gomp/metadirective-target-device-1

Re: [PATCH] testsuite: Remove guality xfails for aarch64*-*-*

2025-04-05 Thread Richard Sandiford
Christophe Lyon writes: > Since r15-7878-ge1c49f413c8, these tests appear as XPASS on aarch64, > so we can remove the xfails introduced by r12-102-gf31ddad8ac8f11. > > gcc/testsuite/ChangeLog: > > * gcc.dg/guality/pr90074.c: Remove xfail for aarch64. > * gcc.dg/guality/pr90716.c: Likew

Re: [Patch] testsuite/lib/libgomp.exp: compile with -fdiagnostics-plain-output

2025-04-05 Thread Jakub Jelinek
On Fri, Mar 21, 2025 at 01:10:44PM +0100, Tobias Burnus wrote: > I tried to match in dg-warning the whole string, including [-OpenMP], but it > failed. > > I turned out that that was because of -fdiagnostics-urls ... > > Solution do what other testsuites do: Use -fdiagnostics-plain-output. > >

Re: [PATCH] testsuite: i386: Fix gcc.target/i386/pr82142?.c etc. on Solaris/x86

2025-04-04 Thread Rainer Orth
Ping? It's been a week: https://gcc.gnu.org/pipermail/gcc-patches/2025-March/679330.html > Three tests FAIL on Solaris/x86 in similar ways: > > FAIL: gcc.target/i386/pr111673.c check-function-bodies advance > FAIL: gcc.target/i386/pr82142a.c check-function-bodies assignzero > FAIL: gcc.t

[PATCH] testsuite: arm: Fix dg-final in short-vfp-1.c [PR119556]

2025-04-04 Thread Christophe Lyon
Recent syntactic fixes enabled the test, but the result was failing. It turns out it was missing a space between the register arguments in the scan-assembler-times directives. gcc/testsuite/ChangeLog: PR target/119556 * gcc.target/arm/short-vfp-1.c: Add missing spaces. --- gcc/t

[PATCH] [testsuite] [riscv] xfail some [PR113281] tests

2025-04-04 Thread Alexandre Oliva
Some of the tests regressed with a fix for the vectorization of shifts. The riscv cost models need to be adjusted to avoid the unprofitable optimization. The failure of these tests has been known since 2024-03-13, without a forthcoming fix, so I suggest we consider it expected by now. Adjust t

Re: [PATCH] [testsuite] [riscv] xfail update-threading on riscv [PR110628]

2025-04-04 Thread Hans-Peter Nilsson
> From: Alexandre Oliva > Date: Mon, 31 Mar 2025 20:59:23 -0300 > On Mar 31, 2025, Jeff Law wrote: > > >> PR tree-optimization/110628 > >> * gcc.dg/tree-ssa/update-threading.c: XFAIL on riscv. > > ?!? This is passing on my tester: > > Indeed, despite the lack of any activity in the PR that cou

[PATCH] testsuite: Remove guality xfails for aarch64*-*-*

2025-04-02 Thread Christophe Lyon
Since r15-7878-ge1c49f413c8, these tests appear as XPASS on aarch64, so we can remove the xfails introduced by r12-102-gf31ddad8ac8f11. gcc/testsuite/ChangeLog: * gcc.dg/guality/pr90074.c: Remove xfail for aarch64. * gcc.dg/guality/pr90716.c: Likewise. --- gcc/testsuite/gcc.dg/gu

Re: [PATCH] testsuite: i386: Fix gcc.target/i386/pr82142?.c etc. on Solaris/x86

2025-04-02 Thread Uros Bizjak
On Wed, Apr 2, 2025 at 11:02 AM Rainer Orth wrote: > > Ping? It's been a week: > > https://gcc.gnu.org/pipermail/gcc-patches/2025-March/679330.html > > > Three tests FAIL on Solaris/x86 in similar ways: > > > > FAIL: gcc.target/i386/pr111673.c check-function-bodies advance > > FAIL: gcc.

[PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-01 Thread Christophe Lyon
After commit r15-8947-g8ed2d5d219e999, which added new tests using gcov, the CI noticed failures because it was calling 'gcov' instead of $target-gcov. This is because the CI scripts override GXX_UNDER_TEST, but still run the testsuite in-tree, and gcc-transform-out-of-tree only depends on TESTING

Re: [PATCH] [testsuite] [riscv] limit vwaddsub-1.c to rv64

2025-04-01 Thread Jeff Law
On 4/1/25 8:03 AM, Kito Cheng wrote: On Tue, Apr 1, 2025 at 12:47 PM Jeff Law wrote: On 3/31/25 7:03 PM, Alexandre Oliva wrote: On Mar 31, 2025, Jeff Law wrote: I don't immediately see anything in this test or its history to indicate it's only supposed to work for rv64. It's the 64-b

Re: [PATCH] [testsuite] [riscv] limit vwaddsub-1.c to rv64

2025-04-01 Thread Kito Cheng
On Tue, Apr 1, 2025 at 12:47 PM Jeff Law wrote: > > > > On 3/31/25 7:03 PM, Alexandre Oliva wrote: > > On Mar 31, 2025, Jeff Law wrote: > >> I don't immediately see anything in this test or its history to > >> indicate it's only supposed to work for rv64. > > > > It's the 64-bit integral argument

Re: [PATCH] testsuite: arm: Fix dg-final in short-vfp-1.c [PR119556]

2025-04-01 Thread Richard Earnshaw (lists)
On 31/03/2025 20:04, Christophe Lyon wrote: > Recent syntactic fixes enabled the test, but the result was failing. > > It turns out it was missing a space between the register arguments in > the scan-assembler-times directives. > > gcc/testsuite/ChangeLog: > > PR target/119556 > * gc

Re: [PATCH] [testsuite] [riscv] xfail some [PR113281] tests

2025-03-31 Thread Robin Dapp
Some of the tests regressed with a fix for the vectorization of shifts. The riscv cost models need to be adjusted to avoid the unprofitable optimization. The failure of these tests has been known since 2024-03-13, without a forthcoming fix, so I suggest we consider it expected by now. Adjust th

Re: [PATCH] [testsuite] [riscv] xfail some [PR113281] tests

2025-03-31 Thread Jeff Law
On 3/31/25 1:01 PM, Alexandre Oliva wrote: Some of the tests regressed with a fix for the vectorization of shifts. The riscv cost models need to be adjusted to avoid the unprofitable optimization. The failure of these tests has been known since 2024-03-13, without a forthcoming fix, so I su

Re: [PATCH] [testsuite] [riscv] limit vwaddsub-1.c to rv64

2025-03-31 Thread Jeff Law
On 3/31/25 7:03 PM, Alexandre Oliva wrote: On Mar 31, 2025, Jeff Law wrote: I don't immediately see anything in this test or its history to indicate it's only supposed to work for rv64. It's the 64-bit integral argument rs1. Right, but ISTM we ought to be able to handle a vector of 64bit i

Re: [PATCH] [testsuite] [riscv] limit vwaddsub-1.c to rv64

2025-03-31 Thread Alexandre Oliva
On Mar 31, 2025, Jeff Law wrote: > On 3/31/25 1:05 PM, Alexandre Oliva wrote: >> The desired vw{add,sub}.wx instructions don't come up on rv32 for >> the >> first two functions, we get v{add,sub}.vx instead. >> I suppose this is an oversight, and something about the test is >> meant >> for rv64

Re: [PATCH] [testsuite] [riscv] xfail update-threading on riscv [PR110628]

2025-03-31 Thread Alexandre Oliva
On Mar 31, 2025, Jeff Law wrote: >> PR tree-optimization/110628 >> * gcc.dg/tree-ssa/update-threading.c: XFAIL on riscv. > ?!? This is passing on my tester: Indeed, despite the lack of any activity in the PR that could suggest it's fixed in the trunk, it no longer fails in the trunk, only gcc-14

Re: [PATCH] [testsuite] [riscv] limit mcpu-xiangshan-nanhu.c to rv64

2025-03-31 Thread Jeff Law
On 3/31/25 1:02 PM, Alexandre Oliva wrote: The testcase makes the -march option conditional on rv64, and #errors out if the desired CPU properties are not active. This makes the test fail on rv32. Arrange to skip the test on rv32 instead, moving the rv64 conditional. Tested on x86_64-linux

Re: [PATCH] [testsuite] [riscv] xfail update-threading on riscv [PR110628]

2025-03-31 Thread Jeff Law
On 3/31/25 1:00 PM, Alexandre Oliva wrote: The failure to adjust estimated profiling frequencies in reassoc noted in PR110628 affects riscv as well. Add it to the XFAIL set. Tested on x86_64-linux-gnu native, and gcc-14 target riscv{64,32}-elf. Ok to install? for gcc/testsuite/ChangeLog

Re: [PATCH] testsuite: arm: Fix dg-final in short-vfp-1.c [PR119556]

2025-03-31 Thread Sam James
Christophe Lyon writes: > Recent syntactic fixes enabled the test, but the result was failing. > > It turns out it was missing a space between the register arguments in > the scan-assembler-times directives. Great find, thanks. > > gcc/testsuite/ChangeLog: > > PR target/119556 > * g

  1   2   3   4   5   6   7   8   9   10   >