Michal Skrivanek has posted comments on this change.
Change subject: aaa: Modify webadmin and userportal to use enginesso for
authentication
..
Patch Set 67:
Ravi, please make sure the "Connect Automatically" fun
Michal Skrivanek has posted comments on this change.
Change subject: core: Make regular user owner of VMs he created
..
Patch Set 1: Code-Review+1
good enough, at least the code is simple:)
--
To view, visit https
Michal Skrivanek has posted comments on this change.
Change subject: events: process status updates in sequential order
..
Patch Set 11:
if Omer is right then this is fine and we can leave this patch for later.
--
To view
Michal Skrivanek has posted comments on this change.
Change subject: engine, backend: enable vmconsole in host deploy
..
Patch Set 18:
then looks like CI issue. follow up with infra@ to update the package.
--
To view, visit
Michal Skrivanek has posted comments on this change.
Change subject: frontend: remote-viewrt version check
..
Patch Set 4: Code-Review+1
please fix typo in commit message
--
To view, visit https://gerrit.ovirt.org/41949
To
Michal Skrivanek has posted comments on this change.
Change subject: Fix exceptions on guest os reporting
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42260
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: Send an automatic refresh if the version changed
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42261
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: core: add support for power8e cpu
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42131
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: Adding atomic host support to the ovirt guest agent
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39750
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: engine: support non-unique vm and template names across DCs
(#912263)
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/41263/6/backend/manager
Michal Skrivanek has posted comments on this change.
Change subject: engine: add consoleAddress to migration command params
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41222/1/backend/manager/modules/vdsbroker
Michal Skrivanek has posted comments on this change.
Change subject: engine: add consoleAddress to migration command params
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/41222/1/backend/manager
Michal Skrivanek has posted comments on this change.
Change subject: hosted-engine: configure gluster for HC
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/39678/1/src/plugins/ovirt-host-deploy/hosted-engine
Michal Skrivanek has posted comments on this change.
Change subject: hosted-engine: configure gluster for HC
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/39678/1/src/plugins/ovirt-host-deploy/hosted-engine
Michal Skrivanek has posted comments on this change.
Change subject: hosted-engine: configure gluster for HC
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/39678/1/src/plugins/ovirt-host-deploy/hosted-engine
Michal Skrivanek has posted comments on this change.
Change subject: core: always send numa node for vm
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/40481/2/backend/manager/modules/vdsbroker/src/main/java/org
Michal Skrivanek has posted comments on this change.
Change subject: engine: Cleanup the vfs when the vm is down and refresh host if
needed
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/38624/15/backend/manager
Michal Skrivanek has posted comments on this change.
Change subject: engine: Cleanup the vfs when the vm is down and refresh host if
needed
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/38624/15/backend/manager
Michal Skrivanek has posted comments on this change.
Change subject: engine: Cleanup the vfs when the vm is down and refresh host if
needed
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/38624/15/backend/manager
Michal Skrivanek has posted comments on this change.
Change subject: engine: calling CollectVdsNetworkData after vm state changed to
up
..
Patch Set 16: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38261
To
Michal Skrivanek has posted comments on this change.
Change subject: pki: add pki-enroll-openssh-cert functionality
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38094/3/packaging/bin/pki-enroll-openssh-cert.sh
Michal Skrivanek has posted comments on this change.
Change subject: pki: add pki-enroll-openssh-cert functionality
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38094/3/packaging/bin/pki-enroll-openssh-cert.sh
Michal Skrivanek has posted comments on this change.
Change subject: core: removed the content of the script changing blank template
name
..
Patch Set 1:
why a contract. The documentation you linked just shows an example of
Michal Skrivanek has posted comments on this change.
Change subject: core: removed the content of the script changing blank template
name
..
Patch Set 1:
there's no API regression. The change is in a pre-installed tem
Michal Skrivanek has posted comments on this change.
Change subject: core: removed the content of the script changing blank template
name
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/39724
To
Michal Skrivanek has posted comments on this change.
Change subject: events: VM Status based on an event
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/37488/4/backend/manager/modules/vdsbroker/src/main/java/org
Michal Skrivanek has posted comments on this change.
Change subject: events: VM Status based on an event
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/37488/4/backend/manager/modules/vdsbroker/src/main/java/org
Michal Skrivanek has posted comments on this change.
Change subject: events: vm stats refersher refactioring
..
Patch Set 3:
(6 comments)
https://gerrit.ovirt.org/#/c/37487/3//COMMIT_MSG
Commit Message:
Line 3: AuthorDate
Michal Skrivanek has posted comments on this change.
Change subject: events: make event processing pool size configurable
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39093
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: events: VM Status based on an event
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/37488/4/backend/manager/modules/vdsbroker/src/main/java/org
Michal Skrivanek has posted comments on this change.
Change subject: host-deploy: support serial console
..
Patch Set 3:
why do we need 2 ports open?
--
To view, visit https://gerrit.ovirt.org/38095
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: frontend: Pass JSESSIONID in VV file
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/33770/17/frontend/webadmin/modules/gwt-common/src/main/java
Michal Skrivanek has posted comments on this change.
Change subject: frontend: Pass JSESSIONID in VV file
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/33770/17/frontend/webadmin/modules/gwt-common/src/main/java
Michal Skrivanek has posted comments on this change.
Change subject: core: vmsMonitoring - save info to be sooner
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/39406/1//COMMIT_MSG
Commit Message:
Line 3
Michal Skrivanek has posted comments on this change.
Change subject: core: vmsMonitoring - save info to be sooner
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/39406/1//COMMIT_MSG
Commit Message:
Line 3
Michal Skrivanek has posted comments on this change.
Change subject: core: el7 allows 4TiB max memory, enable for 3.6+ clusters
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38670
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: engine: removed unused PPC network drivers
..
Patch Set 1:
it should be ok to remove for all
--
To view, visit https://gerrit.ovirt.org/39316
To
Michal Skrivanek has posted comments on this change.
Change subject: core, userportal, webadmin: VirtIO console access key management
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/35810/4/backend/manager/modules
Michal Skrivanek has posted comments on this change.
Change subject: core: on init - clear down vms after vms monitoring
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38850/2/backend/manager/modules/vdsbroker/src
Michal Skrivanek has posted comments on this change.
Change subject: events: VM status update
..
Patch Set 4: Code-Review-1
sure, but this requires a _lot_ of changes on the engine side to use it
effectively.
For monitoring
Michal Skrivanek has posted comments on this change.
Change subject: events: VM status update
..
Patch Set 4:
is this intended to be a proof of concept only?
--
To view, visit https://gerrit.ovirt.org/37758
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: jsonrpc: queue name configuration
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/36364/6/packaging/dbscripts/upgrade/pre_upgrade/_config.sql
Michal Skrivanek has posted comments on this change.
Change subject: core: sync first host-vm monitoring cycle
..
Patch Set 1:
thanks a lot. I just wanted to, well, not add more locks unless they are really
needed. Locks are
Michal Skrivanek has posted comments on this change.
Change subject: core: sync first host-vm monitoring cycle
..
Patch Set 1:
yes, serial.
When we start monitoring just serially call HostStats once, then schedule the
Michal Skrivanek has posted comments on this change.
Change subject: core: sync first host-vm monitoring cycle
..
Patch Set 1:
instead of locks, can't we call the specific onTimer methods explicitly at the
start of monit
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: make use of the new onlyUUID parameter
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38709/4/mom.spec.in
File mom.spec.in:
Line 23
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: make use of the new onlyUUID parameter
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38709
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: core: Populate number of in/out migrations from host statistics
..
Patch Set 2:
after lengthy discussions we decided to keep the computation on vdsm to keep
Michal Skrivanek has posted comments on this change.
Change subject: webadmin: Allow actions on a VM list even if not available on
all VMs
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38415/1/frontend/webadmin
Michal Skrivanek has posted comments on this change.
Change subject: core: Refresh number of in/out migrations in HostMonitoring
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38325/1/backend/manager/modules
Michal Skrivanek has posted comments on this change.
Change subject: core: Refresh number of in/out migrations in HostMonitoring
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/38325/1/backend/manager
Michal Skrivanek has posted comments on this change.
Change subject: restapi: Add action to refresh host capabilities
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38287
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: json-rpc: fix the Host.getVMList return value
..
Patch Set 5:
verified by Omer with and without 38172
--
To view, visit https://gerrit.ovirt.org/38271
To
Michal Skrivanek has posted comments on this change.
Change subject: json-rpc: fix the Host.getVMList return value
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/38271
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: json-rpc: fix the Host.getVMList return value
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38271
To unsubscribe, visit https
Michal Skrivanek has posted comments on this change.
Change subject: vdsbroker: reduced scope of synchronized blocks
..
Patch Set 1: Code-Review-1
(1 comment)
irsbroker changes seem fine, the VdsIdVDSCommandBase is
Michal Skrivanek has posted comments on this change.
Change subject: json-rpc: fix the Host.getVMList return value
..
Patch Set 4: Code-Review+1
(1 comment)
I think we should go with an ugly hack as we can't wait till 3
Michal Skrivanek has posted comments on this change.
Change subject: engine: Added init method to command base.
..
Patch Set 2:
IOW, I'm against extending the base class of all commands (i.e. making it more
complex)
Michal Skrivanek has posted comments on this change.
Change subject: engine: Added init method to command base.
..
Patch Set 2: Code-Review-1
well, talking about the use-case, I don't really see this as a useful
improv
Michal Skrivanek has posted comments on this change.
Change subject: config: Increase KVM VCPU limit to 240
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37210
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: webadmin: if next run configuration exists the edit VM may load
forever
..
Patch Set 1: Code-Review+1
same as master
--
To view, visit http
Michal Skrivanek has posted comments on this change.
Change subject: core: osinfo: blacklist hyperv support
..
Patch Set 1:
Rerun-Hooks: all
--
To view, visit http://gerrit.ovirt.org/36677
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: [backend] Incorrect value for os.other max ram
..
Patch Set 1: Code-Review+1
seems reasonable
--
To view, visit http://gerrit.ovirt.org/36227
To
Michal Skrivanek has posted comments on this change.
Change subject: packaging: add gwt symbols packages
..
Patch Set 3: Code-Review+1
great!
@Tomas, anything else needed?
--
To view, visit http://gerrit.ovirt.org/36655
To
Michal Skrivanek has posted comments on this change.
Change subject: core: osinfo: blacklist hyperv support
..
Patch Set 3: Code-Review+1
jenkins failure unrelated
--
To view, visit http://gerrit.ovirt.org/36648
To
Michal Skrivanek has posted comments on this change.
Change subject: core: osinfo: blacklist hyperv support
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/36648/2/packaging/conf/osinfo-defaults.properties
File
Michal Skrivanek has posted comments on this change.
Change subject: core: notification to the user that a new client tools are
available
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36556/1/packaging/dbscripts
Michal Skrivanek has posted comments on this change.
Change subject: core: Adding 3.6 support
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/36518/1/packaging/dbscripts/upgrade/pre_upgrade/_config.sql
File
Michal Skrivanek has posted comments on this change.
Change subject: restapi: Fix balloon device when creating VMs from snaphots
..
Patch Set 1:
do we need "master" fix?
--
To view, visit http://gerrit.ovirt.or
Michal Skrivanek has posted comments on this change.
Change subject: core: Set emulated machines after capabilities
..
Patch Set 3:
Arik,Shahar, this looks ready
--
To view, visit http://gerrit.ovirt.org/25699
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: core: Replace ANTLRv4 with JavaCC in OsInfo validation
..
Patch Set 2:
grammar is less elegant than the antlr4, but it's good enough and doesn't
Michal Skrivanek has posted comments on this change.
Change subject: core: Adjust websockify to the new API
..
Patch Set 1:
sure, pushing new package would be a good thing. Though I would do it async. It
may take some time
Michal Skrivanek has posted comments on this change.
Change subject: core: Adjust websockify to the new API
..
Patch Set 1:
@Alon, is there any fundamental issue with this patch?
--
To view, visit http://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: core: fixed NPE when vdsm returns emtpy balloon info
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36016/1/backend/manager/modules/vdsbroker/src
Michal Skrivanek has posted comments on this change.
Change subject: core, engine: Disable CPU pinning validation
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/35782/1/backend/manager/modules/bll/src/main/java/org
Michal Skrivanek has posted comments on this change.
Change subject: core: on clone vm the thin provisioned become clone provisioned
..
Patch Set 3: Code-Review-1
in the bug there's a follow-up discussion. It needs d
Michal Skrivanek has posted comments on this change.
Change subject: core, engine: Disable CPU pinning validation
..
Patch Set 2:
please submit a corresponding patch on master first
--
To view, visit http://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: core: Set emulated machines after capabilities
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25699
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: core: do not decrease pending vm on stop of paused vm
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35670
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: restapi: copy instance type fields to the VM
..
Patch Set 4: Code-Review+1
same as upstream
--
To view, visit http://gerrit.ovirt.org/35427
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: frontend: Pass JSESSIONID in VV file
..
Patch Set 11:
Having a generic header field which will contain something like 'Cookie:
jsessionid=xyz' ri
Michal Skrivanek has posted comments on this change.
Change subject: osinfo: Add 64-bit versions of linux systems.
..
Patch Set 1: Code-Review-1
need to review the long added list of new OSes. Maybe revise an option to
switch
Michal Skrivanek has posted comments on this change.
Change subject: core: added event log when mixing RHLE 6 and 7 in one cluster
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35497
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: core: Set emulated machines after capabilities
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25699/2/backend/manager/modules/vdsbroker/src/main
Michal Skrivanek has posted comments on this change.
Change subject: frontend: Pass JSESSIONID in VV file
..
Patch Set 11:
- it's not only about 3.6 ovirt, when you consider virt-viewer's cycle and
release plans w
Michal Skrivanek has posted comments on this change.
Change subject: frontend: Pass JSESSIONID in VV file
..
Patch Set 11:
what will go away is the jsessionid, not the generic token/sessionid/ssoid
whatever you want to call
Michal Skrivanek has posted comments on this change.
Change subject: frontend: Pass JSESSIONID in VV file
..
Patch Set 11:
we already have an interface. it's jsessionid.
whatever we change on our end will need to be bac
Michal Skrivanek has posted comments on this change.
Change subject: core: added event log when mixing RHLE 6 and 7 in one cluster
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/35497/5/backend/manager/modules/dal
Michal Skrivanek has posted comments on this change.
Change subject: frontend: Pass JSESSIONID in VV file
..
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/33770/11//COMMIT_MSG
Commit Message:
Line 20:
Line 21
Michal Skrivanek has posted comments on this change.
Change subject: Engine: Pre-started vms in vm pool display bad auditlog message
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/35394/2/backend
Michal Skrivanek has posted comments on this change.
Change subject: Engine: Pre-started vms in vm pool display bad auditlog message
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/35394/2/backend/manager/modules/bll
Michal Skrivanek has posted comments on this change.
Change subject: Engine: Pre-started vms in vm pool display bad auditlog message
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/35394/2/backend/manager/modules/bll
Michal Skrivanek has posted comments on this change.
Change subject: frontend: Pass JSESSIONID in VV file
..
Patch Set 11:
What's the difference in the token?
Are we sure ravi's change is in in time?
Either way s
Michal Skrivanek has posted comments on this change.
Change subject: RFE: Add Granular permissions for VM operations
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/35206/4/backend/manager/modules/common/src/main
Michal Skrivanek has posted comments on this change.
Change subject: core: Allow skipping command execution
..
Patch Set 3:
I actually prefer this change. There is an immediate need to apply the same
logic to more than just
Michal Skrivanek has posted comments on this change.
Change subject: core: Allow skipping command execution
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34935
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: core: medium Instance Type mismatch feature page
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34495
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: engine: Add ability for conditional steps execution
..
Patch Set 1: Code-Review-1
IMHO the original Omer's approach 34935 is a better solution. Less
Michal Skrivanek has posted comments on this change.
Change subject: core: changed the list of fields which can not be overridden
..
Patch Set 1:
yeah
--
To view, visit http://gerrit.ovirt.org/34915
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: osinfo: Add rhel7/ppc64 into osinfo
..
Patch Set 1: Code-Review-1
-2. no more 3.4 oVirt planned
--
To view, visit http://gerrit.ovirt.org/34848
To
1 - 100 of 479 matches
Mail list logo
