Michal Skrivanek has posted comments on this change. Change subject: core: Set emulated machines after capabilities ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25699/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java: Line 179: Config.<List<String>> getValue(ConfigValues.ClusterEmulatedMachines, Line 180: vds.getVdsGroupCompatibilityVersion().getValue()), Line 181: vds.getSupportedEmulatedMachines().split(",")); Line 182: Line 183: if (matchedEmulatedMachine != null && !matchedEmulatedMachine.isEmpty() && vds.getStatus() != VDSStatus.NonOperational) { I'd say we should do it the other way, enumerate the "good" states. looking at the list of host states I'd guess "Up" and "Maintenance" only? Roy? Line 184: setClusterEmulatedMachine(vds, matchedEmulatedMachine); Line 185: return true; Line 186: } Line 187: return false; -- To view, visit http://gerrit.ovirt.org/25699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc25acf8e9914e382a5ebf66f9c5d895ed4dab2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
