Michal Skrivanek has posted comments on this change. Change subject: engine: Cleanup the vfs when the vm is down and refresh host if needed ......................................................................
Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/38624/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java: Line 23: EventResult storageDomainNotOperational(Guid storageDomainId, Guid storagePoolId); // BLL Line 24: Line 25: EventResult masterDomainNotOperational(Guid storageDomainId, Guid storagePoolId, boolean isReconstructToInactiveDomains, boolean canReconstructToCurrentMaster); // BLL Line 26: Line 27: void processOnVmStop(Collection<Guid> vmIds, Guid hostId); can't we get the hostId from the VMs instead of adding it as parameter everywhere? Line 28: Line 29: boolean vdsUpEvent(VDS vds); Line 30: Line 31: boolean connectHostToDomainsInActiveOrUnknownStatus(VDS vds); -- To view, visit https://gerrit.ovirt.org/38624 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1f861a451f4e0961ec122e4c2594081ea6dc71b Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
