Michal Skrivanek has posted comments on this change. Change subject: frontend: Pass JSESSIONID in VV file ......................................................................
Patch Set 11: - it's not only about 3.6 ovirt, when you consider virt-viewer's cycle and release plans we are more constrained. - jsessionid *is* a stable interface, ever since 3.3 (IIRC). So it can't go away in 3.6...and there's no schedule yet for 4.0 - I agree generic header is nice and can help in a specific case when one header is replaced with a different header. But in case we will eventually need more headers, or anything else...IMO this kind of future-proofing has no real reason/benefit. Once we have the new thing we can change it. Phasing out of jsessiond will be long so I'm not afraid of virt-viewer finding the time to change the implementation accordingly when feasible for them. I see no point in waiting for the new code, which doesn't yet exist, to be finished and settled down and I see that as a risk to the success of this join-effort feature which is way too long overdue. All in all, I would like to ask the maintainers to read and weight the arguments and either approve or reject the patch, otherwise we'll keep arguing forever. -- To view, visit http://gerrit.ovirt.org/33770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5c6d2c91b99240527760b57a6079b5f986aff5b Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches