Michal Skrivanek has posted comments on this change. Change subject: Engine: Pre-started vms in vm pool display bad auditlog message ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35394/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java: Line 568: if (getSucceeded()) { Line 569: boolean isStateless = isStatelessSnapshotExistsForVm(); Line 570: if (isStateless) { Line 571: return AuditLogType.VDS_INITIATED_RUN_VM_AS_STATELESS; Line 572: } else if (getFlow() == RunVmFlow.CREATE_STATELESS_IMAGES) { > hm..really? I would think the original code makes more sense. What was the ah, right, the isStateless on line 574(old) is the problem...in this case it's not stateless...then isn't the right fix actually: else if (!isVdsKnown) Line 573: return AuditLogType.VDS_INITIATED_RUN_AS_STATELESS_VM_NOT_YET_RUNNING; Line 574: } else { Line 575: return AuditLogType.VDS_INITIATED_RUN_VM; Line 576: } -- To view, visit http://gerrit.ovirt.org/35394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ce736c1b24265a13b147ffae235428ddbd597e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
