Michal Skrivanek has posted comments on this change. Change subject: core: Allow skipping command execution ......................................................................
Patch Set 3: I actually prefer this change. There is an immediate need to apply the same logic to more than just Stop command. It may not be all of them , but most of them yes. So it makes sense to abstract the thing in CommandBase. However as I explained in the other patch I don't see any need for skipping any other step for 2 reasons: 1) the validation step is the actual content of canDoAction. There's no need to create a new functionality to skip that - the CAD itself is that step. So to skip some part of validation means changes only within the CAD. 2) there are only 2 steps:-) -- To view, visit http://gerrit.ovirt.org/34935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib86226c3af0c245ec01c59ac650c9282d58f22bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
