Michal Skrivanek has posted comments on this change. Change subject: core: Refresh number of in/out migrations in HostMonitoring ......................................................................
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/38325/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java: Line 762: } Line 763: } Line 764: Line 765: void refreshInOutMigrations() { Line 766: if (!vdsManager.getRefreshStatistics()) { I'm not sure this is needed or even desired. We should update whenever we have a chance, if we have the data (we do have them every 5th iteration currently, but the plan would be to change the scheduling of host monitoring to do actions on every run, hence this code would need to be removed. But IMHO it shouldn't harm even today if we just omit the condition here) Also in refreshCommitedMemory() Line 767: return; Line 768: } Line 769: Line 770: int incomingMigrations = 0; Line 769: Line 770: int incomingMigrations = 0; Line 771: int outgoingMigrations = 0; Line 772: Line 773: for (Pair<VM, VmInternalData> pair : vdsManager.getLastVmsList()) { I don't think we want to count this from VMs in engine. The total we are getting from VDSM directly in 'vmMigrating' host stats, I think we should rather extend it there. (someone from SLA should recall a reason why it was done this way for the total) Line 774: VmInternalData vdsmVm = pair.getSecond(); Line 775: if (vdsmVm != null) { Line 776: if (vdsmVm.getVmDynamic().getStatus() == VMStatus.MigratingFrom) { Line 777: outgoingMigrations++; -- To view, visit https://gerrit.ovirt.org/38325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1ef858a6faf861678245cc02006f40dd230602 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
