Michal Skrivanek has posted comments on this change. Change subject: core, engine: Disable CPU pinning validation ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35782/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java: Line 162 Line 163 Line 164 Line 165 Line 166 > this derogate the check for both x86 vms. so maybe we can add condition on well, I'm not sure if it even makes sense. CPU pinning is a very specific scenario where you need to know what you are doing. And this check may just et in a way when reproting is not correct...or even in case of real hw cpu hotplug later. IMHO there's not too much of a point checking it... -- To view, visit http://gerrit.ovirt.org/35782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98c7a2f136b278a7a695bae8b2eadd3658f3e65c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
