[Engine-patches] Change in ovirt-engine[master]: webadmin: Added storage missing fields to Cloner

Allon Mureinik has posted comments on this change. Change subject: webadmin: Added storage missing fields to Cloner .. Patch Set 1: Code-Review+1 Looks fine to me. Daniel - is there anything I'm missing? -- To view, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: VM configuration should not be validated in Export Domain

Allon Mureinik has posted comments on this change. Change subject: core: VM configuration should not be validated in Export Domain .. Patch Set 2: Code-Review+2 Please verify and merge -- To view, visit https://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: log the selected storage domain for memory volumes

Allon Mureinik has posted comments on this change. Change subject: core: log the selected storage domain for memory volumes .. Patch Set 4: Rebased, no code changes. -- To view, visit https://gerrit.ovirt.org/42143 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: core: log the selected storage domain for memory volumes

Allon Mureinik has submitted this change and it was merged. Change subject: core: log the selected storage domain for memory volumes .. core: log the selected storage domain for memory volumes This patch adds an info log for th

[Engine-patches] Change in ovirt-engine[master]: core: log the selected storage domain for memory volumes

Allon Mureinik has posted comments on this change. Change subject: core: log the selected storage domain for memory volumes .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42143 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: engine: Add support for Refresh LUNs size

Allon Mureinik has posted comments on this change. Change subject: engine: Add support for Refresh LUNs size .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39318 To unsubscribe, visit https://gerrit.

[Engine-patches] Change in ovirt-engine[master]: engine: Add support for Refresh LUNs size

Allon Mureinik has posted comments on this change. Change subject: engine: Add support for Refresh LUNs size .. Patch Set 10: Code-Review-1 (20 comments) https://gerrit.ovirt.org/#/c/39318/10/backend/manager/modules/bll/src/ma

[Engine-patches] Change in ovirt-engine[master]: core[BLL]: Adding external status to command

Allon Mureinik has posted comments on this change. Change subject: core[BLL]: Adding external status to command .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42135 To unsubscribe, visit https://gerri

[Engine-patches] Change in ovirt-engine[master]: core[BE]: Adding external status to BE

Allon Mureinik has posted comments on this change. Change subject: core[BE]: Adding external status to BE .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42133 To unsubscribe, visit https://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core[DB]: Adding external status to DB

Allon Mureinik has posted comments on this change. Change subject: core[DB]: Adding external status to DB .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42132 To unsubscribe, visit https://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core[Search]:Add search support to external_status

Allon Mureinik has posted comments on this change. Change subject: core[Search]:Add search support to external_status .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42136 To unsubscribe, visit https:/

[Engine-patches] Change in ovirt-engine[master]: core[DAO]: Adding external status to DAOs

Allon Mureinik has posted comments on this change. Change subject: core[DAO]: Adding external status to DAOs .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42134 To unsubscribe, visit https://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core[BE]: Adding external status to BE

Allon Mureinik has posted comments on this change. Change subject: core[BE]: Adding external status to BE .. Patch Set 4: Code-Review+2 (2 comments) https://gerrit.ovirt.org/#/c/42133/4/backend/manager/modules/common/src/main/

[Engine-patches] Change in ovirt-engine[master]: core[DB]: Adding external status to DB

Allon Mureinik has posted comments on this change. Change subject: core[DB]: Adding external status to DB .. Patch Set 4: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/42132/4/packaging/dbscripts/create_views.sql File

[Engine-patches] Change in ovirt-engine[master]: gluster: Add Replica 3 validation

Allon Mureinik has posted comments on this change. Change subject: gluster: Add Replica 3 validation .. Patch Set 4: Verified+1 Code-Review+2 Rebased, solved merge conflicts. -- To view, visit https://gerrit.ovirt.org/41943 T

[Engine-patches] Change in ovirt-engine[master]: gluster: Add Replica 3 validation

Allon Mureinik has submitted this change and it was merged. Change subject: gluster: Add Replica 3 validation .. gluster: Add Replica 3 validation Allow creating gluster storage domains only with volumes defined as Replica 3.

[Engine-patches] Change in ovirt-engine[master]: restapi: Add "alias" and "name" to disk update metadata

Allon Mureinik has posted comments on this change. Change subject: restapi: Add "alias" and "name" to disk update metadata .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42103 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: Override image name in import image view

Allon Mureinik has submitted this change and it was merged. Change subject: core, webadmin: Override image name in import image view .. core, webadmin: Override image name in import image view This patch adds the ability to edi

[Engine-patches] Change in ovirt-engine[master]: webadmin: Enable editing name on import iscsi SD

Allon Mureinik has posted comments on this change. Change subject: webadmin: Enable editing name on import iscsi SD .. Patch Set 1: Code-Review+1 Need an FE maintainer -- To view, visit https://gerrit.ovirt.org/41060 To unsub

[Engine-patches] Change in ovirt-engine[master]: core[DB]: Adding external status to DB

Allon Mureinik has posted comments on this change. Change subject: core[DB]: Adding external status to DB .. Patch Set 1: Sorry for the broken communication here - caught Oved f2f and discussed a bit. The join with storage_poo

[Engine-patches] Change in ovirt-engine[master]: gluster: Add Replica 3 validation

Allon Mureinik has posted comments on this change. Change subject: gluster: Add Replica 3 validation .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41943 To unsubscribe, visit https://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core[DB]: Adding external status to DB

Allon Mureinik has posted comments on this change. Change subject: core[DB]: Adding external status to DB .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/42132/1/packaging/dbscripts/create_views.sql File packaging/db

[Engine-patches] Change in ovirt-engine[master]: core[Search]:Add search support to external_status

Allon Mureinik has posted comments on this change. Change subject: core[Search]:Add search support to external_status .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42136 To unsubscribe, visit https:/

[Engine-patches] Change in ovirt-engine[master]: core[BLL]: Adding external status to command

Allon Mureinik has posted comments on this change. Change subject: core[BLL]: Adding external status to command .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42135 To unsubscribe, visit https://gerri

[Engine-patches] Change in ovirt-engine[master]: core[DAO]: Adding external status to DAOs

Allon Mureinik has posted comments on this change. Change subject: core[DAO]: Adding external status to DAOs .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42134 To unsubscribe, visit https://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core[BE]: Adding external status to BE

Allon Mureinik has posted comments on this change. Change subject: core[BE]: Adding external status to BE .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42133/1/backend/manager/modules/common/src/main/j

[Engine-patches] Change in ovirt-engine[master]: core[DB]: Adding external status to DB

Allon Mureinik has posted comments on this change. Change subject: core[DB]: Adding external status to DB .. Patch Set 1: Code-Review-1 (5 comments) https://gerrit.ovirt.org/#/c/42132/1/packaging/dbscripts/create_views.sql Fil

[Engine-patches] Change in ovirt-engine[master]: webadmin: Size info in GB along side %

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Size info in GB along side % .. webadmin: Size info in GB along side % In Storage General sub tab, there's a percentage threshold. Add to it

[Engine-patches] Change in ovirt-engine[master]: webadmin: Size info in GB along side %

Allon Mureinik has posted comments on this change. Change subject: webadmin: Size info in GB along side % .. Patch Set 10: Rebased and built, no code changes. -- To view, visit https://gerrit.ovirt.org/40729 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: webadmin: Size info in GB along side %

Allon Mureinik has posted comments on this change. Change subject: webadmin: Size info in GB along side % .. Patch Set 9: Acked based on previous +2 by Daniel Erez. -- To view, visit https://gerrit.ovirt.org/40729 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: webadmin: Size info in GB along side %

Allon Mureinik has posted comments on this change. Change subject: webadmin: Size info in GB along side % .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40729 To unsubscribe, visit https://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: Introduce volume classification

Allon Mureinik has posted comments on this change. Change subject: core: Introduce volume classification .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42055/2/packaging/dbscripts/upgrade/03_06_1480_add

[Engine-patches] Change in ovirt-engine[master]: core: Add helper method for volume classification.

Allon Mureinik has posted comments on this change. Change subject: core: Add helper method for volume classification. .. Patch Set 2: Code-Review-1 This would make much more sense as part of the VolumeClassification class itse

[Engine-patches] Change in ovirt-engine[master]: core: Introduce volume classification enum

Allon Mureinik has posted comments on this change. Change subject: core: Introduce volume classification enum .. Patch Set 2: This patch, as it stands, is dead code. It should be squashed into the following one. -- To view,

[Engine-patches] Change in ovirt-engine[master]: core: Gluster disk as network device

Allon Mureinik has posted comments on this change. Change subject: core: Gluster disk as network device .. Patch Set 4: Code-Review+1 Looks good to me. Do not merge before the VDSM side is merged. -- To view, visit https://ge

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: Change init type of BackwardCompatibilityTaskCreationTest

Allon Mureinik has posted comments on this change. Change subject: Change init type of BackwardCompatibilityTaskCreationTest .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42014 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Gluster disk as network device

Allon Mureinik has posted comments on this change. Change subject: core: Gluster disk as network device .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/41899/3/backend/manager/modules/vdsbroker/src/main/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Size info in GB along side %

Allon Mureinik has posted comments on this change. Change subject: webadmin: Size info in GB along side % .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40729 To unsubscribe, visit https://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: webadmin: disk permissions never loads

Allon Mureinik has posted comments on this change. Change subject: webadmin: disk permissions never loads .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41603 To unsubscribe, visit https://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add tooltip to storage critical threshold

Allon Mureinik has posted comments on this change. Change subject: webadmin: Add tooltip to storage critical threshold .. Patch Set 1: Code-Review+1 Backend looks great, waiting for a frontend maintainer to review -- To view,

[Engine-patches] Change in ovirt-engine[master]: core: rm AddVmTemplateFromSnapshot useless method

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm AddVmTemplateFromSnapshot useless method .. core: rm AddVmTemplateFromSnapshot useless method Removed the redundant AddVmTemplateFromSnapshotC

[Engine-patches] Change in ovirt-engine[master]: core: rm AddVmTemplateFromSnapshot useless method

Allon Mureinik has posted comments on this change. Change subject: core: rm AddVmTemplateFromSnapshot useless method .. Patch Set 2: Code-Review+2 Rebased, no code changes. -- To view, visit https://gerrit.ovirt.org/41825 To

[Engine-patches] Change in ovirt-engine[master]: core: rm AddVmTemplateFromSnapshot useless method

Allon Mureinik has posted comments on this change. Change subject: core: rm AddVmTemplateFromSnapshot useless method .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/41825 To unsubscribe, visit https://ger

[Engine-patches] Change in ovirt-engine[master]: core: rm AddVmTemplateFromSnapshot useless method

Allon Mureinik has uploaded a new change for review. Change subject: core: rm AddVmTemplateFromSnapshot useless method .. core: rm AddVmTemplateFromSnapshot useless method Removed the redundant AddVmTemplateFromSnapshotCommand.g

[Engine-patches] Change in ovirt-engine[master]: core: Log problematic domain name when moving host to non op...

Allon Mureinik has posted comments on this change. Change subject: core: Log problematic domain name when moving host to non operational .. Patch Set 3: Code-Review+2 Please verify and merge -- To view, visit https://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: add MemoryStorageHandler the ability to sort

Allon Mureinik has posted comments on this change. Change subject: core: add MemoryStorageHandler the ability to sort .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40438 To unsubscribe, visit https:/

[Engine-patches] Change in ovirt-engine[master]: core: redesign MemoryStorageHandler to use filters

Allon Mureinik has posted comments on this change. Change subject: core: redesign MemoryStorageHandler to use filters .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40437 To unsubscribe, visit https:/

[Engine-patches] Change in ovirt-engine[master]: core: add more tests to MemoryStorageHandlerTest

Allon Mureinik has posted comments on this change. Change subject: core: add more tests to MemoryStorageHandlerTest .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40436 To unsubscribe, visit https://g

[Engine-patches] Change in ovirt-engine[master]: core: redesign MemoryStorageHandlerTest to use mocks

Allon Mureinik has posted comments on this change. Change subject: core: redesign MemoryStorageHandlerTest to use mocks .. Patch Set 6: Code-Review+2 Much better! -- To view, visit https://gerrit.ovirt.org/40435 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: move logic regarding memory storage handling

Allon Mureinik has posted comments on this change. Change subject: core: move logic regarding memory storage handling .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40433 To unsubscribe, visit https:/

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5-gluster]: core: Fix typos in Gluster geo-replication

Allon Mureinik has posted comments on this change. Change subject: core: Fix typos in Gluster geo-replication .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/41472 To unsubscribe, visit https://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: Fix FB issue in VdsCpuUsageComparator

Allon Mureinik has posted comments on this change. Change subject: core: Fix FB issue in VdsCpuUsageComparator .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/41265 To unsubscribe, visit https://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: Fix FB issue in VdsCpuUsageComparator

Allon Mureinik has uploaded a new change for review. Change subject: core: Fix FB issue in VdsCpuUsageComparator .. core: Fix FB issue in VdsCpuUsageComparator This patch fixes the following FindBugs warning on this class: """

[Engine-patches] Change in ovirt-engine[master]: core: Remove LSM in different storage sub types limitation

Allon Mureinik has posted comments on this change. Change subject: core: Remove LSM in different storage sub types limitation .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/37019 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: Remove LSM in different storage sub types limitation

Allon Mureinik has posted comments on this change. Change subject: core: Remove LSM in different storage sub types limitation .. Patch Set 10: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/37019/10//COMMIT_MSG Commit

[Engine-patches] Change in ovirt-engine[master]: core: add MemoryStorageHandler the ability to sort

Allon Mureinik has posted comments on this change. Change subject: core: add MemoryStorageHandler the ability to sort .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40438 To unsubscribe, visit https:/

[Engine-patches] Change in ovirt-engine[master]: core: redesign MemoryStorageHandler to use filters

Allon Mureinik has posted comments on this change. Change subject: core: redesign MemoryStorageHandler to use filters .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40437 To unsubscribe, visit https:/

[Engine-patches] Change in ovirt-engine[master]: core: add more tests to MemoryStorageHandlerTest

Allon Mureinik has posted comments on this change. Change subject: core: add more tests to MemoryStorageHandlerTest .. Patch Set 4: Code-Review-1 (7 comments) https://gerrit.ovirt.org/#/c/40436/4/backend/manager/modules/bll/sr

[Engine-patches] Change in ovirt-engine[master]: core: redesign MemoryStorageHandlerTest to use mocks

Allon Mureinik has posted comments on this change. Change subject: core: redesign MemoryStorageHandlerTest to use mocks .. Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/40435/4/backend/manager/modules/bll

[Engine-patches] Change in jenkins[master]: vdsm: Fedora 20 is not supported on master

Allon Mureinik has posted comments on this change. Change subject: vdsm: Fedora 20 is not supported on master .. Patch Set 4: Code-Review+1 Can we move forward with this? -- To view, visit https://gerrit.ovirt.org/41033 To un

[Engine-patches] Change in ovirt-engine[master]: core: move logic regarding memory storage handling

Allon Mureinik has posted comments on this change. Change subject: core: move logic regarding memory storage handling .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40433 To unsubscribe, visit https:/

[Engine-patches] Change in ovirt-engine[master]: UI: Fix header buttons in import iScsi target

Allon Mureinik has posted comments on this change. Change subject: UI: Fix header buttons in import iScsi target .. Patch Set 1: Daniel, can we merge this? -- To view, visit https://gerrit.ovirt.org/41051 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: database: Define user roles to import/export domains

Allon Mureinik has posted comments on this change. Change subject: database: Define user roles to import/export domains .. Patch Set 1: Code-Review+1 (2 comments) Looks about right to me. Eli? https://gerrit.ovirt.org/#/c/410

[Engine-patches] Change in ovirt-engine[master]: permissions: Change role type of ActionGroup.IMPORT_EXPORT_VM

Allon Mureinik has posted comments on this change. Change subject: permissions: Change role type of ActionGroup.IMPORT_EXPORT_VM .. Patch Set 1: Code-Review+1 (2 comments) +1 on the code, see suggestion wrt commit message. ht

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: restapi: Extending disk editing when adding a new template.

Allon Mureinik has posted comments on this change. Change subject: restapi: Extending disk editing when adding a new template. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40986 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: Grammar fix

Allon Mureinik has posted comments on this change. Change subject: core: Grammar fix .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-M

[Engine-patches] Change in ovirt-engine[master]: core: Grammar fix

Allon Mureinik has uploaded a new change for review. Change subject: core: Grammar fix .. core: Grammar fix Fixed the common mistake of using "more then" instead of "more than" throughout the codebsae. Change-Id: Idd4bba75e08bf

[Engine-patches] Change in ovirt-engine[master]: core: Move RetrieveImageDataVDSCommand log execution to DEBU...

Allon Mureinik has posted comments on this change. Change subject: core: Move RetrieveImageDataVDSCommand log execution to DEBUG level .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40873 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: Fix typo for rebooting a VM

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix typo for rebooting a VM .. core: Fix typo for rebooting a VM Fixed typo: Reebot -> Reboot Change-Id: Ibd85439417ad87940c38dca4d25101a248ecad

[Engine-patches] Change in ovirt-engine[master]: core: Fix typo in Network cluster messages

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix typo in Network cluster messages .. core: Fix typo in Network cluster messages Fixed grammar mistake "more then" to "more than". Change-Id:

[Engine-patches] Change in ovirt-engine[master]: core: Fix typo for rebooting a VM

Allon Mureinik has posted comments on this change. Change subject: core: Fix typo for rebooting a VM .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40857 To unsubscribe, visit https://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: core: Fix typos in Gluster geo-replication

Allon Mureinik has posted comments on this change. Change subject: core: Fix typos in Gluster geo-replication .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40856 To unsubscribe, visit https://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: Fix typo for rebooting a VM

Allon Mureinik has posted comments on this change. Change subject: core: Fix typo for rebooting a VM .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40857 To unsubscribe, visit https://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: core: Fix typos in Gluster geo-replication

Allon Mureinik has posted comments on this change. Change subject: core: Fix typos in Gluster geo-replication .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40856 To unsubscribe, visit https://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: Fix typo in Network cluster messages

Allon Mureinik has posted comments on this change. Change subject: core: Fix typo in Network cluster messages .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40855 To unsubscribe, visit https://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: Fix typos in Gluster geo-replication

Allon Mureinik has uploaded a new change for review. Change subject: core: Fix typos in Gluster geo-replication .. core: Fix typos in Gluster geo-replication Fixed typos: - brocker -> broker - inetrevene -> intervene Change-I

[Engine-patches] Change in ovirt-engine[master]: core: Fix typo in Network cluster messages

Allon Mureinik has uploaded a new change for review. Change subject: core: Fix typo in Network cluster messages .. core: Fix typo in Network cluster messages Fixed grammar mistake "more then" to "more than". Change-Id: I9791b66

[Engine-patches] Change in ovirt-engine[master]: core: Fix typo for rebooting a VM

Allon Mureinik has uploaded a new change for review. Change subject: core: Fix typo for rebooting a VM .. core: Fix typo for rebooting a VM Fixed typo: Reebot -> Reboot Change-Id: Ibd85439417ad87940c38dca4d25101a248ecad7c Bug-U

[Engine-patches] Change in ovirt-engine[master]: restapi: Use description for discover FCP Storage in rsdl

Allon Mureinik has posted comments on this change. Change subject: restapi: Use description for discover FCP Storage in rsdl .. Patch Set 2: Code-Review+1 Looks good to me. REST maintainers? -- To view, visit https://gerrit.o

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: always storing HOST_ID as an int

Allon Mureinik has posted comments on this change. Change subject: packaging: setup: always storing HOST_ID as an int .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40778/1//COMMIT_MSG Commit Message: Line 8: Line

[Engine-patches] Change in ovirt-engine[master]: core: Add backend thresholds validation support

Allon Mureinik has submitted this change and it was merged. Change subject: core: Add backend thresholds validation support .. core: Add backend thresholds validation support When adding thresholds trough REST api, we need valu

[Engine-patches] Change in ovirt-engine[master]: core: Add storage space thresholds support

Allon Mureinik has submitted this change and it was merged. Change subject: core: Add storage space thresholds support .. core: Add storage space thresholds support This patch adds two thresholds per domain: LowSpaceThreshold (

[Engine-patches] Change in ovirt-engine[master]: core: Add storage space thresholds support

Allon Mureinik has posted comments on this change. Change subject: core: Add storage space thresholds support .. Patch Set 47: Verified+1 Code-Review+2 Reabsed, fixed typo in the commit message (defauls -> default). No code cha

[Engine-patches] Change in ovirt-engine[master]: core: Add backend thresholds validation support

Allon Mureinik has posted comments on this change. Change subject: core: Add backend thresholds validation support .. Patch Set 7: Code-Review+2 Rebased, no code changes. -- To view, visit https://gerrit.ovirt.org/40473 To un

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5.3]: core: NPE fix in clone image from snapshot

Allon Mureinik has posted comments on this change. Change subject: core: NPE fix in clone image from snapshot .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40753 To unsubscribe, visit https://gerrit.

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5.3]: core: Extracting virtIO-scsi disabling check in CDA

Allon Mureinik has posted comments on this change. Change subject: core: Extracting virtIO-scsi disabling check in CDA .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40752 To unsubscribe, visit https:

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: Extracting virtIO-scsi disabling check in CDA

Allon Mureinik has posted comments on this change. Change subject: core: Extracting virtIO-scsi disabling check in CDA .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40727 To unsubscribe, visit https:

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5]: core: NPE fix in clone image from snapshot

Allon Mureinik has posted comments on this change. Change subject: core: NPE fix in clone image from snapshot .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40728 To unsubscribe, visit https://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: Extracting virtIO-scsi disabling check in CDA

Allon Mureinik has submitted this change and it was merged. Change subject: core: Extracting virtIO-scsi disabling check in CDA .. core: Extracting virtIO-scsi disabling check in CDA VirtIO-scsi disabling validation in AddVmFro

[Engine-patches] Change in ovirt-engine[master]: core: NPE fix in clone image from snapshot

Allon Mureinik has submitted this change and it was merged. Change subject: core: NPE fix in clone image from snapshot .. core: NPE fix in clone image from snapshot NPE is thrown from AddVmFromSnapshotCommand's CDA. This is cau

[Engine-patches] Change in ovirt-engine[master]: core: NPE fix in clone image from snapshot

Allon Mureinik has posted comments on this change. Change subject: core: NPE fix in clone image from snapshot .. Patch Set 4: Code-Review+2 Rebased, no code changes. -- To view, visit https://gerrit.ovirt.org/40662 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: core: Extracting virtIO-scsi disabling check in CDA

Allon Mureinik has posted comments on this change. Change subject: core: Extracting virtIO-scsi disabling check in CDA .. Patch Set 2: Code-Review+2 Code fixed as per Omer's review, acking. -- To view, visit https://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: NPE fix in clone image from snapshot

Allon Mureinik has posted comments on this change. Change subject: core: NPE fix in clone image from snapshot .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40662 To unsubscribe, visit https://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: Extracting virtIO-scsi disabling check in CDA

Allon Mureinik has posted comments on this change. Change subject: core: Extracting virtIO-scsi disabling check in CDA .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40710 To unsubscribe, visit https:

[Engine-patches] Change in ovirt-engine[master]: core: Add backend thresholds validation support

Allon Mureinik has posted comments on this change. Change subject: core: Add backend thresholds validation support .. Patch Set 4: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/40473/4/backend/manager/modules/dal/src/

[Engine-patches] Change in ovirt-engine[master]: core: Add storage space thresholds support

Allon Mureinik has posted comments on this change. Change subject: core: Add storage space thresholds support .. Patch Set 44: Code-Review+1 Backend looks OK, Frontend seems to have answered the last review's comments. Giving

[Engine-patches] Change in ovirt-engine[master]: restapi: Fix typo in import image RSDL metadata

Allon Mureinik has posted comments on this change. Change subject: restapi: Fix typo in import image RSDL metadata .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40588 To unsubscribe, visit https://ge

[Engine-patches] Change in ovirt-engine[master]: core: Remove LSM in different storage sub types limitation

Allon Mureinik has posted comments on this change. Change subject: core: Remove LSM in different storage sub types limitation .. Patch Set 7: (1 comment) Code looks good, see comment on the error msg https://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5.2]: core: Add OVF_STORE disks registration on Data Center initia...

Allon Mureinik has posted comments on this change. Change subject: core: Add OVF_STORE disks registration on Data Center initialization .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40595 To unsubsc

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.5.2]: core: Refactor register of OVF_STORE disks

Allon Mureinik has posted comments on this change. Change subject: core: Refactor register of OVF_STORE disks .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40594 To unsubscribe, visit https://gerrit.

  1   2   3   4   5   6   7   8   9   10   >