Allon Mureinik has posted comments on this change. Change subject: core[DB]: Adding external status to DB ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/42132/1/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 511: storage_domain_dynamic.used_disk_size AS used_disk_size, Line 512: fn_get_disk_commited_value_by_storage ( storage_domain_static.id ) AS commited_disk_size, Line 513: fn_get_actual_images_size_by_storage ( storage_domain_static.id ) AS actual_images_size, Line 514: NULL AS status, Line 515: storage_pool_iso_map.external_status AS external_status, > remove this from the patch or return NULL as external status ??? NULL As external_status, sorry for the confusion. Line 516: fn_get_storage_domain_shared_status_by_domain_id ( storage_domain_static.id, Line 517: storage_pool_iso_map.status, Line 518: storage_domain_static.storage_domain_type ) AS storage_domain_shared_status, Line 519: storage_domain_static.recoverable AS recoverable, Line 566: FROM Line 567: storage_domain_static Line 568: INNER JOIN storage_domain_dynamic ON storage_domain_static.id = storage_domain_dynamic.id Line 569: INNER JOIN storage_pool_iso_map ON storage_domain_static.id = storage_pool_iso_map.storage_id Line 570: INNER JOIN storage_pool ON storage_pool_iso_map.storage_pool_id = storage_pool.id > This view is used in the search engine, how will I get the external_status You won't, just like you don't get status. Search will just have to live without it, sorry. Line 571: Line 572: LEFT Line 573: OUTER JOIN ( Line 574: SELECT -- To view, visit https://gerrit.ovirt.org/42132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdfc25b91eacfa73be783b3b84827e0d5788b91d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
