Allon Mureinik has posted comments on this change. Change subject: core[DB]: Adding external status to DB ......................................................................
Patch Set 1: Sorry for the broken communication here - caught Oved f2f and discussed a bit. The join with storage_pool_iso_map is wrong, as a domain can potentially be part of two pools, and have a different status on each one. Theoretically, you could join storage_domain_* on an aggregate query from storage_pool_iso_map, but I don't think that would make too much sense. After discussing a bit, it seems that external_status and status are different. Status is something we manage, per domain (e.g., Active, Maintenance, etc.). extenal_status comes from the storage (vendor) itself, and has nothing to do with oVirt's Storage Pool, so it makes more sense to put it on storage_domain_dynamic, which will also seal the dillema of the join here. -- To view, visit https://gerrit.ovirt.org/42132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdfc25b91eacfa73be783b3b84827e0d5788b91d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
