[Engine-patches] Change in ovirt-engine[master]: core: rm AddVmTemplateFromSnapshot useless method

[amureini]

Allon Mureinik has uploaded a new change for review.

Change subject: core: rm AddVmTemplateFromSnapshot useless method
......................................................................

core: rm AddVmTemplateFromSnapshot useless method

Removed the redundant AddVmTemplateFromSnapshotCommand.getSnapshotDao()
method. The base class, AuditLogableBse, already has a getSnapshotDAO()
method and having another method with the same functionality and only a
difference in case is both redundant and confusing, as FindBugs warns
about.

Change-Id: I9c6bd54cb652fa79c40d9179dad2622e6968a858
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java
1 file changed, 2 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/25/41825/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java
index c589e15..2ff6a95 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java
@@ -23,7 +23,6 @@
 import org.ovirt.engine.core.common.utils.Pair;
 import org.ovirt.engine.core.compat.Guid;
 import org.ovirt.engine.core.dao.DiskImageDAO;
-import org.ovirt.engine.core.dao.SnapshotDao;
 import org.ovirt.engine.core.utils.transaction.TransactionMethod;
 import org.ovirt.engine.core.utils.transaction.TransactionSupport;
 
@@ -157,7 +156,7 @@
                 // Assumption - a snapshot can be locked only if in status OK, 
so if canDoAction passed
                 // this is the status of the snapshot. In addition the newly 
added VM is in down status
                 getCompensationContext().snapshotEntityStatus(getSnapshot());
-                
getSnapshotDao().updateStatus(getParameters().getSourceSnapshotId(), 
SnapshotStatus.LOCKED);
+                
getSnapshotDAO().updateStatus(getParameters().getSourceSnapshotId(), 
SnapshotStatus.LOCKED);
                 getCompensationContext().stateChanged();
                 return null;
             }
@@ -166,7 +165,7 @@
 
     protected void unlockSnapshot() {
         // Assumption - this is last DB change of command, no need for 
compensation here
-        getSnapshotDao().updateStatus(getParameters().getSourceSnapshotId(), 
SnapshotStatus.OK);
+        getSnapshotDAO().updateStatus(getParameters().getSourceSnapshotId(), 
SnapshotStatus.OK);
     }
 
     private Snapshot getSnapshot() {
@@ -178,10 +177,6 @@
 
     protected DiskImageDAO getDiskImageDao() {
         return getDbFacade().getDiskImageDao();
-    }
-
-    protected SnapshotDao getSnapshotDao() {
-        return getDbFacade().getSnapshotDao();
     }
 
     protected VM getVmFromConfiguration() {


-- 
To view, visit https://gerrit.ovirt.org/41825
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c6bd54cb652fa79c40d9179dad2622e6968a858
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches