Allon Mureinik has posted comments on this change. Change subject: core: redesign MemoryStorageHandlerTest to use mocks ......................................................................
Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/40435/4/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/memory/MemoryStorageHandlerTest.java: Line 66: Line 67: private void initStorageDomains() { Line 68: validStorageDomain = initStorageDomain(); Line 69: invalidStorageDomain1 = initStorageDomain(); Line 70: invalidStorageDomain2 = initStorageDomain(); talked to Idan f2f. Let's make this more readable: validDomain = initValidDomain(); // also registered the validator invalidDomain1 = initValidDomain(); // also registered the validator invalidDomain2 = initValidDomain(); // also registered the validator Line 71: } Line 72: Line 73: private StorageDomain initStorageDomain() { Line 74: StorageDomain storageDomain = new StorageDomain(); -- To view, visit https://gerrit.ovirt.org/40435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe874762dda6967a1bc5e29c973fac7b00fbda70 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Candace Sheremeta <csher...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
