Allon Mureinik has posted comments on this change. Change subject: core[DB]: Adding external status to DB ......................................................................
Patch Set 4: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/42132/4/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 517: storage_domain_static.recoverable AS recoverable, Line 518: unregistered_entities.storage_domain_id IS NOT NULL AS contains_unregistered_entities, Line 519: storage_domain_static.warning_low_space_indicator as warning_low_space_indicator, Line 520: storage_domain_static.critical_space_action_blocker as critical_space_action_blocker, Line 521: NULL AS external_status You have storage_domain_dynamic joined already - not reason not to query storage_domain_dynamic.external_status here. Line 522: FROM Line 523: storage_domain_static Line 524: INNER JOIN storage_domain_dynamic ON storage_domain_static.id = storage_domain_dynamic.id Line 525: LEFT -- To view, visit https://gerrit.ovirt.org/42132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdfc25b91eacfa73be783b3b84827e0d5788b91d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
