Allon Mureinik has posted comments on this change. Change subject: permissions: Change role type of ActionGroup.IMPORT_EXPORT_VM ......................................................................
Patch Set 1: Code-Review+1 (2 comments) +1 on the code, see suggestion wrt commit message. https://gerrit.ovirt.org/#/c/41050/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-05-18 10:58:57 +0300 Line 4: Commit: Ala Hino <ah...@redhat.com> Line 5: CommitDate: 2015-05-18 11:17:11 +0300 Line 6: Line 7: permissions: Change role type of ActionGroup.IMPORT_EXPORT_VM s/permissions/core/ Line 8: Line 9: Changed role type of ActionGroup.IMPORT_EXPORT_VM from RoleType.ADMIN to Line 10: RoleType.USER. This change is required in order to enable defining permissions Line 11: for users to import/export VMs or templates. Line 7: permissions: Change role type of ActionGroup.IMPORT_EXPORT_VM Line 8: Line 9: Changed role type of ActionGroup.IMPORT_EXPORT_VM from RoleType.ADMIN to Line 10: RoleType.USER. This change is required in order to enable defining permissions Line 11: for users to import/export VMs or templates. Also worth noting the immediate benefit: with this patch, admins can create a new custom role which will allow non-admin users to export/import vms/templates via REST API Line 12: Line 13: Change-Id: Ic701948cc390118a652158067f27979d1e268c37 Line 14: Related-Bug: https://bugzilla.redhat.com/1108153 -- To view, visit https://gerrit.ovirt.org/41050 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic701948cc390118a652158067f27979d1e268c37 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
