Allon Mureinik has posted comments on this change. Change subject: core: Remove LSM in different storage sub types limitation ......................................................................
Patch Set 7: (1 comment) Code looks good, see comment on the error msg https://gerrit.ovirt.org/#/c/37019/7/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 736: ACTION_TYPE_FAILED_OVF_DISK_IS_BEING_USED=Cannot ${action} ${type}. Disk OVF data is currently being updated. Line 737: ACTION_TYPE_FAILED_UNSUPPORTED_OVF=Cannot ${action} ${type}. There is no OVF for the specific entity. Line 738: ACTION_TYPE_FAILED_DOMAIN_OVF_ON_UPDATE=Cannot ${action} ${type}. Storage Domain OVF data is currently being updated. Line 739: ACTION_TYPE_FAILED_DISK_IS_BEING_MIGRATED=Cannot ${action} ${type}. Disk ${DiskName} is being moved or copied. Line 740: ACTION_TYPE_FAILED_DESTINATION_AND_SOURCE_STORAGE_SUB_TYPES_DIFFERENT=Cannot ${action} ${type}. Source and target domains must both be either file domains or block domains in this cluster version. ... In this Data Center compatibility version Line 741: ACTION_TYPE_FAILED_TEMPLATE_IS_BEING_EXPORTED=Cannot ${action} ${type}. Template ${TemplateName} is being exported. Line 742: ACTION_TYPE_FAILED_NO_VALID_DOMAINS_STATUS_FOR_TEMPLATE_DISKS=Cannot ${action} ${type}. Can't find Domain(s) in ${applicableStatus} status for some of the Template disks.\n\ Line 743: Please make sure that there is at least one Storage Domain in applicable status for each one of the disks :\n\ Line 744: ${disksInfo}. -- To view, visit https://gerrit.ovirt.org/37019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5cbf6b7e3fd14af3dc22fca2469ba43ec6a4353 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
