Allon Mureinik has posted comments on this change. Change subject: core: Introduce volume classification ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42055/2/packaging/dbscripts/upgrade/03_06_1480_add_column_volume_classification.sql File packaging/dbscripts/upgrade/03_06_1480_add_column_volume_classification.sql: Line 1: SELECT fn_db_add_column('images', 'volume_classification', 'SMALLINT'); Line 2: Line 3: update images set volume_classification = 0 where active; Line 4: update images set volume_classification = 1 where active = false; Lets fold this into one statement: UPDATE images SET volume_classification = CASE WHEN active THEN 0 ELSE 1 END; Line 5: -- To view, visit https://gerrit.ovirt.org/42055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1f37abcc4c5a99076138d7dfb0ffe72f68aef50 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
