[Engine-patches] Change in ovirt-engine[master]: webadmin: allow nested tags more than 2 levels deep

2013-09-04 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: webadmin: allow nested tags more than 2 levels deep .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18610 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: gluster: [WIP] Query to get the gluster volume size info

2013-09-04 Thread shtripat
Shubhendu Tripathi has uploaded a new change for review. Change subject: gluster: [WIP] Query to get the gluster volume size info .. gluster: [WIP] Query to get the gluster volume size info Query for getting the gluster volume s

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: added branding cascading resource servlet

2013-09-04 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: added branding cascading resource servlet .. Patch Set 5: Verified+1 made cascaded resource get defined in resources.properties, not the m

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: added branding cascading resource servlet

2013-09-04 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: added branding cascading resource servlet .. Patch Set 4: (1 comment) File packaging

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: split messages in two file

2013-09-04 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: userportal,webadmin: split messages in two file .. userportal,webadmin: split messages in two file - Split messages.properties into messages and resources

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: split messages in two file

2013-09-04 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: split messages in two file .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18623 To unsubscribe, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: split messages in two file

2013-09-04 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal,webadmin: split messages in two file .. Patch Set 9: Verified+1 fyi, I renamed resources.properties to external_resources.properties, because I need

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: split messages in two file

2013-09-04 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: split messages in two file .. Patch Set 9: thanks Greg, for the quick response. -- To view, visit http://gerrit.ovirt.org/18623 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: split messages in two file

2013-09-04 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: split messages in two file .. Patch Set 8: Greg, the patch currently depends on an outdated version of another (merged) patch. can you please

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: split messages in two file

2013-09-04 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: split messages in two file .. Patch Set 8: > Greg, ... or Alexander, of course. Thanks. -- To view, visit http://gerrit.ovirt.org/18623 To

[Engine-patches] Change in ovirt-engine[master]: engine: fix broken message lookup

2013-09-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: engine: fix broken message lookup .. Patch Set 5: Verified+1 Code-Review+2 Merging based on previous acks. -- To view, visit http://gerrit.ovirt.org/18828 To u

[Engine-patches] Change in ovirt-engine[master]: engine: fix broken message lookup

2013-09-04 Thread vszocs
Vojtech Szocs has submitted this change and it was merged. Change subject: engine: fix broken message lookup .. engine: fix broken message lookup - Fixed issue where certain combinations of message keys where not being included

[Engine-patches] Change in ovirt-engine[master]: engine: leak property file resource

2013-09-04 Thread vszocs
Vojtech Szocs has submitted this change and it was merged. Change subject: engine: leak property file resource .. engine: leak property file resource - Fixed resource leak in loading themes. Change-Id: I7d66412b9b5242af8c471d4

[Engine-patches] Change in ovirt-engine[master]: engine: leak property file resource

2013-09-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: engine: leak property file resource .. Patch Set 3: Verified+1 Code-Review+2 Merging based on previous acks. -- To view, visit http://gerrit.ovirt.org/18722 To

[Engine-patches] Change in ovirt-engine[master]: engine: fix broken message lookup

2013-09-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: engine: fix broken message lookup .. Patch Set 5: Rebased (no changes since last time). -- To view, visit http://gerrit.ovirt.org/18828 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: engine: fix broken message lookup

2013-09-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: engine: fix broken message lookup .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18828 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: webadmin: GuideMe cluster does not pass OverrideFirewall

2013-09-04 Thread vszocs
Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: GuideMe cluster does not pass OverrideFirewall .. webadmin: GuideMe cluster does not pass OverrideFirewall - Fixed class cast exception in onA

[Engine-patches] Change in ovirt-engine[master]: engine: leak property file resource

2013-09-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: engine: leak property file resource .. Patch Set 3: Rebased (no changes since last time). -- To view, visit http://gerrit.ovirt.org/18722 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: webadmin: GuideMe cluster does not pass OverrideFirewall

2013-09-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: GuideMe cluster does not pass OverrideFirewall .. Patch Set 2: Verified+1 Code-Review+2 Merging based on previous acks. -- To view, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: webadmin: GuideMe cluster does not pass OverrideFirewall

2013-09-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: GuideMe cluster does not pass OverrideFirewall .. Patch Set 2: Rebased (no changes since last time). -- To view, visit http://gerrit.ovirt.org/18674

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Fix popups after engine restart & relogin

2013-09-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Fix popups after engine restart & relogin .. Patch Set 3: Verified+1 Code-Review+2 Merging based on previous acks. -- To view, visit http:

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Fix popups after engine restart & relogin

2013-09-04 Thread vszocs
Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Fix popups after engine restart & relogin .. webadmin,userportal: Fix popups after engine restart & relogin This patch ensures that

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: login wait state

2013-09-04 Thread vszocs
Vojtech Szocs has submitted this change and it was merged. Change subject: userportal,webadmin: login wait state .. userportal,webadmin: login wait state - Fixed login failure event not firing when input validation failed. This

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Fix popups after engine restart & relogin

2013-09-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Fix popups after engine restart & relogin .. Patch Set 2: (1 comment) File frontend/w

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: login wait state

2013-09-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: login wait state .. Patch Set 2: Rebased (no changes since last time). -- To view, visit http://gerrit.ovirt.org/18634 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: login wait state

2013-09-04 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: login wait state .. Patch Set 2: Verified+1 Code-Review+2 Merging based on previous acks. -- To view, visit http://gerrit.ovirt.org/18634

[Engine-patches] Change in ovirt-engine[master]: engine: fix broken message lookup

2013-09-04 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: engine: fix broken message lookup .. Patch Set 4: @Alon/Vojtech - can you please review? Thanks. -- To view, visit http://gerrit.ovirt.org/18828 To unsubscribe,

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: bin: support --vm-status option

2013-09-04 Thread alourie
Alex Lourie has posted comments on this change. Change subject: bin: support --vm-status option .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/17878 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: enforce VM name

2013-09-04 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: setup: enforce VM name .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18816 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: sort login domain select box

2013-09-04 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: sort login domain select box .. Patch Set 2: (1 comment) Commit Message Line 3: AuthorD

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: disconnecting from storage pool

2013-09-04 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: setup: disconnecting from storage pool .. Patch Set 11: Code-Review+1 (1 comment) Small comment, otherwise looks good. ...

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: build: ovirt-hosted-engine-setup-1.0.0-0.3.beta

2013-09-04 Thread alourie
Alex Lourie has posted comments on this change. Change subject: build: ovirt-hosted-engine-setup-1.0.0-0.3.beta .. Patch Set 13: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18064 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: sort login domain select box

2013-09-04 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: sort login domain select box .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/18727 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: sort login domain select box

2013-09-04 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: sort login domain select box .. Patch Set 2: Code-Review+1 +1 on the GUI code change; needs "+2" from an engine-core maintainer (Eli?), woul

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: added branding cascading resource servlet

2013-09-04 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: added branding cascading resource servlet .. Patch Set 4: (1 comment) File packaging/br

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: added branding cascading resource servlet

2013-09-04 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: added branding cascading resource servlet .. Patch Set 4: (1 comment) File packaging/br

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: added branding cascading resource servlet

2013-09-04 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: added branding cascading resource servlet .. Patch Set 4: (1 comment) File packaging

[Engine-patches] Change in ovirt-engine[master]: engine, frontend: disable new vm button if no DC is up

2013-09-04 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: engine,frontend: disable new vm button if no DC is up .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/18885 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: added branding cascading resource servlet

2013-09-04 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: added branding cascading resource servlet .. Patch Set 4: (1 comment) File packaging

[Engine-patches] Change in ovirt-engine[master]: engine, frontend: disable new vm button if no DC is up

2013-09-04 Thread tjelinek
Tomas Jelinek has uploaded a new change for review. Change subject: engine,frontend: disable new vm button if no DC is up .. engine,frontend: disable new vm button if no DC is up Following changes done to achive this: - created

[Engine-patches] Change in ovirt-engine[master]: engine: Add branded link to console resources

2013-09-04 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: engine: Add branded link to console resources .. Patch Set 7: - removed link from new/edit vm/pool/template dialog - adjusted positioning of link in basic user po

[Engine-patches] Change in ovirt-engine[master]: engine: Add branded link to console resources

2013-09-04 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: engine: Add branded link to console resources .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/18596 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: engine: cleanup in RemoveSnapshotSingleDiskCommand

2013-09-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: cleanup in RemoveSnapshotSingleDiskCommand .. Patch Set 2: Persisted async task placeholder before calling to VDS command. Answered to Allon's and Maor'

[Engine-patches] Change in ovirt-engine[master]: engine: cleanup in RemoveSnapshotSingleDiskCommand

2013-09-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: cleanup in RemoveSnapshotSingleDiskCommand .. Patch Set 1: (3 comments) File backend/manager/modul

[Engine-patches] Change in ovirt-engine[master]: engine:VDS Command for Start Gluster volume remove brick

2013-09-04 Thread rnachimu
Ramesh N has uploaded a new change for review. Change subject: engine:VDS Command for Start Gluster volume remove brick .. engine:VDS Command for Start Gluster volume remove brick VDS command to start the remove brick operatio

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: Minor spec cleanups

2013-09-04 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: sdk: Minor spec cleanups .. Patch Set 4: Verified+1 Fixed the Provides and Obsoletes tags for smoother rename. -- To view, visit http://gerrit.ovirt.org/18868

[Engine-patches] Change in ovirt-engine[master]: frontend: Select an empty profile does not work

2013-09-04 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: frontend: Select an empty profile does not work .. Patch Set 4: (6 comments) File frontend/webadmin/module

[Engine-patches] Change in ovirt-engine[master]: engine: Removes not used image groups after snapshot removal

2013-09-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: engine: Removes not used image groups after snapshot removal .. Patch Set 4: (1 comment) Answer to Allon's comment inside .

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: Minor spec cleanups

2013-09-04 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: sdk: Minor spec cleanups .. Patch Set 3: Verified+1 Remove the shebang from params.py, avoid duplicated files and put all the %doc in one line. -- To view, v

[Engine-patches] Change in ovirt-engine[master]: webadmin: Removed unused variable

2013-09-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: webadmin: Removed unused variable .. Patch Set 2: Code-Review+1 (1 comment) Commit Message Line 5: CommitD

[Engine-patches] Change in ovirt-engine[master]: engine: remove castings

2013-09-04 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: engine: remove castings .. engine: remove castings Change-Id: Ib7b8b9f5721e2efd23cbd92ff77c3d3b5d40d811 Signed-off-by: Arik Hadas --- M backend/manager/modules/b

[Engine-patches] Change in ovirt-engine[master]: restapi: remove castings

2013-09-04 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: restapi: remove castings .. restapi: remove castings Change-Id: I499ca2f08f2c3b9f0ceef0999367b2b9be031890 Signed-off-by: Arik Hadas --- M backend/manager/modules

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: Minor spec cleanups

2013-09-04 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: sdk: Minor spec cleanups .. Patch Set 2: Verified+1 Fixed a typo in the commit message. -- To view, visit http://gerrit.ovirt.org/18868 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Consolidate duplicate exception handling

2013-09-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Consolidate duplicate exception handling .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/18871 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Remove unused methods from UserCommandBase

2013-09-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Remove unused methods from UserCommandBase .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/18870 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: engine: Remove instanceof from GetDomainListQuery

2013-09-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: engine: Remove instanceof from GetDomainListQuery .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/18869 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: core: Consolidate duplicate exception handling

2013-09-04 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Consolidate duplicate exception handling .. core: Consolidate duplicate exception handling This patch removes duplicate blocks of exception handling. Th

[Engine-patches] Change in ovirt-engine[master]: engine: Remove instanceof from GetDomainListQuery

2013-09-04 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: engine: Remove instanceof from GetDomainListQuery .. engine: Remove instanceof from GetDomainListQuery Runtime type checking is no way of passing parameters -

[Engine-patches] Change in ovirt-engine[master]: core: Remove unused methods from UserCommandBase

2013-09-04 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Remove unused methods from UserCommandBase .. core: Remove unused methods from UserCommandBase Removed ProcessAdElementDefaultRole(Guid, String) and CanA

[Engine-patches] Change in ovirt-engine[master]: frontend: Adding FQDN column to VmViews

2013-09-04 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: frontend: Adding FQDN column to VmViews .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/17865 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: Minor spec cleanups

2013-09-04 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: sdk: Minor spec cleanups .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/18868 To unsubscribe, visit http://gerrit.ovirt.org/settings Ger

[Engine-patches] Change in ovirt-engine[master]: Use FQDN from guest agent for RDP

2013-09-04 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: Use FQDN from guest agent for RDP .. Patch Set 8: (1 comment) File backend/manager/modules/restapi/inte

[Engine-patches] Change in ovirt-engine[master]: Use FQDN from guest agent for RDP

2013-09-04 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: Use FQDN from guest agent for RDP .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.ovirt.org/17709 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: Minor spec cleanups

2013-09-04 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: sdk: Minor spec cleanups .. sdk: Minor spec cleanups This patch does some minor cleanups on the spec file as suggested by Crhistopher Meng in the bug opened i

[Engine-patches] Change in ovirt-engine[master]: engine: VdcActionUtils: Remove reflection

2013-09-04 Thread rgolan
Roy Golan has posted comments on this change. Change subject: engine: VdcActionUtils: Remove reflection .. Patch Set 2: (1 comment) File backend/manager/modules/common/src/

[Engine-patches] Change in ovirt-engine[master]: core: Add POWER 7 to the CPU list

2013-09-04 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: Add POWER 7 to the CPU list .. Patch Set 4: (1 comment) File backend/manager/modules/common/src/main/jav

[Engine-patches] Change in ovirt-engine[master]: webadmin: Increased size of dialog and panel

2013-09-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Increased size of dialog and panel .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18863 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Increased size of dialog and panel

2013-09-04 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Increased size of dialog and panel .. webadmin: Increased size of dialog and panel They were causing the "Sync Network" widget to be invisible.

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: saving memcheck parameter to answer file

2013-09-04 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: saving memcheck parameter to answer file .. packaging: setup: saving memcheck parameter to answer file This new implementation allows

[Engine-patches] Change in ovirt-engine[master]: pki: Cleanup CA creation

2013-09-04 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: pki: Cleanup CA creation .. pki: Cleanup CA creation Remove old certs on CA creation Example scenario where this is required: engine-setup ran with web

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: saving memcheck parameter to answer file

2013-09-04 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: setup: saving memcheck parameter to answer file .. Patch Set 9: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18669 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: pki: Cleanup CA creation

2013-09-04 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: pki: Cleanup CA creation .. Patch Set 13: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18749 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Change rollback message

2013-09-04 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: setup: Change rollback message .. Patch Set 4: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/17845 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Change rollback message

2013-09-04 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: Change rollback message .. packaging: setup: Change rollback message Fix the text for the existing one in db/schema.py and change it

[Engine-patches] Change in ovirt-engine[master]: Engine: update video device save wrong values

2013-09-04 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: Engine: update video device save wrong values .. Engine: update video device save wrong values Change-Id: I6cc48d5eb3fc60cba022d8f6b4a8dee3760be5e5 bug-url:

[Engine-patches] Change in ovirt-engine[master]: Engine: update video device save wrong values

2013-09-04 Thread rgolan
Roy Golan has posted comments on this change. Change subject: Engine: update video device save wrong values .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18786 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: Engine: update video device save wrong values

2013-09-04 Thread rgolan
Roy Golan has posted comments on this change. Change subject: Engine: update video device save wrong values .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18786 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: webadmin: Handler cleanup in ModelListTreeViewModel

2013-09-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Handler cleanup in ModelListTreeViewModel .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18667 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: backend: add ActionGroup to access image domains

2013-09-04 Thread derez
Daniel Erez has posted comments on this change. Change subject: backend: add ActionGroup to access image domains .. Patch Set 3: Code-Review-1 (1 comment) File backend/mana

[Engine-patches] Change in ovirt-engine[master]: core: Fix double checking

2013-09-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix double checking .. Patch Set 3: Actually, if you initialize the instance during class loading, you don't even need to specify it as volatile... --

[Engine-patches] Change in ovirt-engine[master]: restapi: generalize getStoragePoolIdForDomain

2013-09-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: restapi: generalize getStoragePoolIdForDomain .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18438 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: backend: add ActionGroup to access image domains

2013-09-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: backend: add ActionGroup to access image domains .. Patch Set 3: Code-Review+1 +1 on the backend side. -- To view, visit http://gerrit.ovirt.org/18078 To unsu

[Engine-patches] Change in ovirt-engine[master]: restapi: disk entity export to glance

2013-09-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: restapi: disk entity export to glance .. Patch Set 4: Code-Review+1 +1 on the backend side -- To view, visit http://gerrit.ovirt.org/17541 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: engine: Removes not used image groups after snapshot removal

2013-09-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: engine: Removes not used image groups after snapshot removal .. Patch Set 4: Code-Review-1 (1 comment) Fil

[Engine-patches] Change in ovirt-engine[master]: engine: cleanup in RemoveSnapshotSingleDiskCommand

2013-09-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: engine: cleanup in RemoveSnapshotSingleDiskCommand .. Patch Set 1: Code-Review-1 (2 comments) File backen

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Rename /etc/sysconfig/ovirt-engine

2013-09-04 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: Rename /etc/sysconfig/ovirt-engine .. packaging: setup: Rename /etc/sysconfig/ovirt-engine During upgrade, after updating packages, w

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Rename /etc/sysconfig/ovirt-engine

2013-09-04 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: setup: Rename /etc/sysconfig/ovirt-engine .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18760 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: all-in-one: Add titles

2013-09-04 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: setup: all-in-one: Add titles .. Patch Set 4: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18424 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: all-in-one: Add titles

2013-09-04 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: all-in-one: Add titles .. packaging: setup: all-in-one: Add titles Add titles for the allinone plugin. Also make storage run after c

[Engine-patches] Change in ovirt-engine[master]: core, rest, ui: VirtIO-SCSI enabled flag

2013-09-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core,rest,ui: VirtIO-SCSI enabled flag .. Patch Set 4: (1 comment) Can you elaborate on why you need a Boolean for the default value? Not sure I'm following y

[Engine-patches] Change in ovirt-engine[master]: core: Elaborate java docs in FixturesTool.

2013-09-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Elaborate java docs in FixturesTool. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18864 To unsubscribe, visit http://gerrit.ov