Arik Hadas has uploaded a new change for review.
Change subject: restapi: remove castings
......................................................................
restapi: remove castings
Change-Id: I499ca2f08f2c3b9f0ceef0999367b2b9be031890
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/18872/1
diff --git
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java
index 23adf9d..675cd07 100644
---
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java
+++
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java
@@ -146,7 +146,7 @@
IdQueryParameters params = new IdQueryParameters(jobId);
VdcQueryReturnValue queryResult =
runQuery(VdcQueryType.GetJobByJobId, params);
if (queryResult != null && queryResult.getSucceeded() &&
queryResult.getReturnValue() != null) {
- Job job = (Job)queryResult.getReturnValue();
+ Job job = queryResult.getReturnValue();
return job.getStatus()==JobExecutionStatus.STARTED ?
CreationStatus.IN_PROGRESS : CreationStatus.COMPLETE;
} else {
//not supposed to happen
diff --git
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
index fcc5d33..988d0fd 100644
---
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
+++
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
@@ -144,7 +144,7 @@
DbUser returnValue = null;
if (userQueryResponse != null && userQueryResponse.getSucceeded()) {
- returnValue = (DbUser) userQueryResponse.getReturnValue();
+ returnValue = userQueryResponse.getReturnValue();
}
return returnValue;
diff --git
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java
index 6a41f9d..9af38a8 100644
---
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java
+++
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java
@@ -93,7 +93,7 @@
params.setSessionId(sessionId);
VdcQueryReturnValue queryReturnValue =
backend.RunPublicQuery(VdcQueryType.ValidateSession, params);
if (queryReturnValue != null) {
- VdcUser vdcUser = (VdcUser) queryReturnValue.getReturnValue();
+ VdcUser vdcUser = queryReturnValue.getReturnValue();
if (vdcUser != null) {
principal = new Principal(vdcUser.getUserName(),
vdcUser.getPassword(), vdcUser.getDomainControler());
sessionHelper.setSessionId(sessionId);
--
To view, visit http://gerrit.ovirt.org/18872
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I499ca2f08f2c3b9f0ceef0999367b2b9be031890
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
