Sergey Gotliv has posted comments on this change.
Change subject: engine: Removes not used image groups after snapshot removal
......................................................................
Patch Set 4:
(1 comment)
Answer to Allon's comment inside
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
Line 176: if
(imageIdsUsedByActiveSnapshot.contains(diskImage.getId()) ||
Line 177:
removeInProcessImageIds.contains(diskImage.getId())) {
Line 178: continue;
Line 179: }
Line 180:
what do you mean?
runAsyncTask is the private method of that class and was there a lot of time,
right?
It's called from the other places in that command either, right (please, check
it by yourself)?
This method is actually calling to internalCommand so maybe its name is
confusing...
Line 181: VdcReturnValueBase retValue =
runAsyncTask(VdcActionType.RemoveImage,
Line 182: new
RemoveImageParameters(diskImage.getImageId()));
Line 183:
Line 184: if (retValue.getSucceeded()) {
--
To view, visit http://gerrit.ovirt.org/18647
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07928bc8ff4225055586b96e47d3787d741a95b4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
