Ofer Schreiber has submitted this change and it was merged. Change subject: pki: Cleanup CA creation ......................................................................
pki: Cleanup CA creation Remove old certs on CA creation Example scenario where this is required: engine-setup ran with websocket-proxy enabled engine-cleanup engine-setup ran with allinone enabled Without this change, the cert creation for the vdsm host in the second run will fail, because it runs as user ovirt, and the previous engine-setup left certs/1004.pem owned by root, so can't be rewritten. Also, for completeness, remove old keys and requests, as well as other files, add error checking to backup/remove, etc. And fix minor error. Change-Id: Ibab2884b461da0a723ea9d2040985a2429af1632 Signed-off-by: Yedidyah Bar David <d...@redhat.com> Signed-off-by: Alon Bar-Lev <alo...@redhat.com> --- M packaging/bin/pki-common.sh.in M packaging/bin/pki-create-ca.sh 2 files changed, 36 insertions(+), 10 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibab2884b461da0a723ea9d2040985a2429af1632 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
