Allon Mureinik has posted comments on this change.

Change subject: core,rest,ui: VirtIO-SCSI enabled flag
......................................................................


Patch Set 4:

(1 comment)

Can you elaborate on why you need a Boolean for the default value? Not sure I'm 
following your logic.

....................................................
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
Line 402:         return vmTemplate;
Line 403:     }
Line 404: 
Line 405:     private VDSGroup createVdsGroup() {
Line 406:         if (vdsGroup == null) {
Ichs.
Not in this patch - lets keep consistency.
Line 407:             vdsGroup = new VDSGroup();
Line 408:             vdsGroup.setcompatibility_version(Version.v3_3);
Line 409:         }
Line 410:         return vdsGroup;


-- 
To view, visit http://gerrit.ovirt.org/18638
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice06fda5946b5961cfe9c819b0b368525b1f4b58
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to