Vinzenz Feenstra has posted comments on this change.

Change subject: Use FQDN from guest agent for RDP
......................................................................


Patch Set 8:

(1 comment)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2296: 
Line 2297:   <xs:complexType name="GuestInfo">
Line 2298:     <xs:sequence>
Line 2299:       <xs:element ref="ips" minOccurs="0" maxOccurs="1"/>
Line 2300:       <xs:element name="fqdn" type="xs:string" minOccurs="0" 
maxOccurs="1"/>
Well this option, is influencing the RDP Console behaviour. Until now the RDP 
Console was using either IP or an assumed FQDN by using the VM Name + the 
Domain.
This option introduces the ability to prefer either using the FQDN reported by 
the guest agent if available (which might not be the case) or solely use the 
way before that change.

This option was solely introduced to modify the behaviour of the RDP Console in 
the Webadmin and User Portal. If the option is changed the REST API will still 
report here both: ips and fqdn. (if they exist of course)

2. Added entry to FeaturesHelper (For the FQDN value)
Line 2301:     </xs:sequence>
Line 2302:   </xs:complexType>
Line 2303: 
Line 2304:   <xs:element name="vms" type="VMs"/>


-- 
To view, visit http://gerrit.ovirt.org/17709
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e7f8e46c6a71ccbfe9af9bf85271d7294b03526
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to