Alex Lourie has posted comments on this change.
Change subject: packaging: setup: disconnecting from storage pool
......................................................................
Patch Set 11: Code-Review+1
(1 comment)
Small comment, otherwise looks good.
....................................................
File src/plugins/ovirt-hosted-engine-setup/storage/storage.py
Line 437: def _spmStop(self):
Line 438: self.logger.debug('spmStop')
Line 439: spUUID = self.environment[ohostedcons.StorageEnv.SP_UUID]
Line 440: status, status_uuid = self.serv.spmStop(args=[
Line 441: spUUID,
this multiline split is a little vague; I would either go for all in one line,
or with
spmStop(
args=[spUUID],
)
Line 442: ])
Line 443: if status != 0:
Line 444: raise RuntimeError(status_uuid)
Line 445: self.logger.debug(status_uuid)
--
To view, visit http://gerrit.ovirt.org/17676
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3052c62316bc3bd6ddc82f10356e3bf665816bc
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Eduardo <ewars...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@gmail.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
