Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: added branding cascading resource servlet ......................................................................
Patch Set 4: (1 comment) .................................................... File packaging/branding/ovirt.brand/branding.properties Line 18: messages=messages.properties Line 19: Line 20: # resources -- images, PDFs, etc. These are cascaded, so if the same resource Line 21: # exists in a higher brand, the higher brand "wins" and gets served. Line 22: favicon=images/favicon.ico OK, I think that now I get the difference, and Alon is right - we need to distinguish between strings (which we take as-is and not really care about what they are and/or what they stand for) and resources (which are also *represented* by strings, but we know that each such string represents a path of a file which its *content* needs to be checked/served in some sense, etc.) actually, what I initially had in mind is to treat the favicon path like any other branded string: put it in messages/resources.properties, and use it as-is in the relevant context (in this case - in the 'href' property of the relevant 'link rel="shortcut icon"' tag in the relevant pages). we can always say that the user is fully responsible for the branded content that he supplies; just like he can put in 'user_portal.css' a reference to a background-image URL that doesn't exist, provide a feedback-button-URL that leads nowhere, etc., he can provide a favicon path that doesn't exist. so I think we need to do either that (unless I missed something), or fully go with Alon's suggestion, but no mixing. thoughts? Line 23: Line 24: # Welcome page template (optional, allows you to add things to the welcome page) Line 25: welcome=welcome_page.template Line 26: -- To view, visit http://gerrit.ovirt.org/18385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dcd9d0f22a7c5867c39576020ad16dd6c53deda Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
