Sandro Bonazzola has posted comments on this change.
Change subject: packaging: create the conf.d directory
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13145
To unsu
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Introduction of CommandManager
..
Patch Set 2: (6 inline comments)
File
backend/manager/modules/b
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Introduction of CommandManager
..
Patch Set 2: (1 inline comment)
Ravi, already an important comment - can we have some info on why you chose
EHCache
Mark Wu has posted comments on this change.
Change subject: Allow creating ISO domain on localfs
..
Patch Set 3: (10 inline comments)
Allon,
I really appreciate for your detailed review and great suggestion. I will add
the po
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Set mnt_option, vfsType for glusterfs.
..
engine: Set mnt_option, vfsType for glusterfs.
Modified this condition to allow setting mnt_option, vfsType et
Ayal Baron has posted comments on this change.
Change subject: core: Extract SD validations from ImagesHandler
..
Patch Set 7: (4 inline comments)
Just a partial review
File
Sharad Mishra has abandoned this change.
Change subject: webadmin: Update storage pop view to add Gluster FS.
..
Patch Set 16: Abandoned
squashed with http://gerrit.ovirt.org/#/c/8983/
--
To view, visit http://gerrit.ovirt.org
Sharad Mishra has abandoned this change.
Change subject: core: Update StorageTypeTest to include Gluster FS.
..
Patch Set 12: Abandoned
squashed with http://gerrit.ovirt.org/#/c/8834/
--
To view, visit http://gerrit.ovirt.org/
Sharad Mishra has abandoned this change.
Change subject: core: Add capability check for Gluster FS.
..
Patch Set 16: Abandoned
squashed with http://gerrit.ovirt.org/#/c/8834/
--
To view, visit http://gerrit.ovirt.org/8964
To u
Sharad Mishra has restored this change.
Change subject: engine: Add glusterfs domain to engine.
..
Patch Set 16: Restored
oops this is the original patch.
--
To view, visit http://gerrit.ovirt.org/8834
To unsubscribe, visit ht
Sharad Mishra has abandoned this change.
Change subject: core: Adding compatibility version support for GlusterFS.
..
Patch Set 15: Abandoned
squashed with http://gerrit.ovirt.org/#/c/8834/
--
To view, visit http://gerrit.ovir
Sharad Mishra has abandoned this change.
Change subject: engine: Add glusterfs domain to engine.
..
Patch Set 16: Abandoned
squashed with http://gerrit.ovirt.org/#/c/8834/
--
To view, visit http://gerrit.ovirt.org/8834
To unsu
Sharad Mishra has abandoned this change.
Change subject: core: Update Enums to support GLusterFS.
..
Patch Set 14: Abandoned
squashed with http://gerrit.ovirt.org/#/c/8834/
--
To view, visit http://gerrit.ovirt.org/8961
To uns
Sharad Mishra has abandoned this change.
Change subject: api: Add support for GlusterFS in api.
..
Patch Set 14: Abandoned
squashed with http://gerrit.ovirt.org/#/c/8834/
--
To view, visit http://gerrit.ovirt.org/8844
To unsub
Sharad Mishra has abandoned this change.
Change subject: core: Introduce AddGlusterFsStorageDomainCommand.
..
Patch Set 15: Abandoned
squashed with http://gerrit.ovirt.org/#/c/8834/
--
To view, visit http://gerrit.ovirt.org/88
Sharad Mishra has abandoned this change.
Change subject: core: Update StoragePoolValidator test to test GlusterFS.
..
Patch Set 15: Abandoned
squashed with http://gerrit.ovirt.org/#/c/8834/
--
To view, visit http://gerrit.ovir
Sharad Mishra has abandoned this change.
Change subject: core: Adding compatibility version support for GlusterFS.
..
Patch Set 12: Abandoned
squashed with http://gerrit.ovirt.org/#/c/8834/
--
To view, visit http://gerrit.ovir
Omer Frenkel has posted comments on this change.
Change subject: core: on handing over a VM mark it as MigratingTo
..
Patch Set 2: (1 inline comment)
forgot this one :/
File
Omer Frenkel has posted comments on this change.
Change subject: core: on handing over a VM mark it as MigratingTo
..
Patch Set 2: (1 inline comment)
File
backend/manager/mo
Daniel Erez has posted comments on this change.
Change subject: webadmin: load image refreshing data
..
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
.
Ravi Nori has posted comments on this change.
Change subject: engine : Introduction of CommandManager
..
Patch Set 1: Verified
rebased on e6d01cc5a49c273c088964e24
--
To view, visit http://gerrit.ovirt.org/13152
To unsubscribe
Ravi Nori has uploaded a new change for review.
Change subject: engine : Introduction of CommandManager
..
engine : Introduction of CommandManager
This patch introducs the command manager and two new
interfaces CallBack and Task
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: use tools new conf.d feature
..
Patch Set 1: Verified; I would prefer that you didn't submit this
Marking as -1 until we get snapshot of the new tools.
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: use tools new conf.d feature
..
packaging: use tools new conf.d feature
Change-Id: I4849ac3dcefeb22b7aea725b6bd734174d6778e2
Signed-off-by: Alon Bar-L
Sandro Bonazzola has posted comments on this change.
Change subject: Fixed set_hosts for handling correctly -H option
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13149
To unsubscribe, visit http://gerrit.
Sandro Bonazzola has uploaded a new change for review.
Change subject: Fixed set_hosts for handling correctly -H option
..
Fixed set_hosts for handling correctly -H option
As stated in the method documentation each option set to
Kiril Nesenko has posted comments on this change.
Change subject: config: fixup default config locaiton
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13144
To unsubscr
Sandro Bonazzola has abandoned this change.
Change subject: Fix reference to DEFAULT_CONFIGURATION_FILE
..
Patch Set 1: Abandoned
Already pushed by Alon: http://gerrit.ovirt.org/#/c/13144/
--
To view, visit http://gerrit.ovirt
Sandro Bonazzola has posted comments on this change.
Change subject: config: fixup default config locaiton
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13144
To unsubscribe, visit http://gerrit.ovirt.org/s
Sandro Bonazzola has posted comments on this change.
Change subject: config: fixup default config locaiton
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13144
To unsub
Alon Bar-Lev has posted comments on this change.
Change subject: Fix reference to DEFAULT_CONFIGURATION_FILE
..
Patch Set 1:
I thought we can merge this ASAP... before other people find...
http://gerrit.ovirt.org/#/c/13144/
-
Sandro Bonazzola has posted comments on this change.
Change subject: Fix reference to DEFAULT_CONFIGURATION_FILE
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13148
To unsubscribe, visit http://gerrit.ovirt
Sandro Bonazzola has uploaded a new change for review.
Change subject: Fix reference to DEFAULT_CONFIGURATION_FILE
..
Fix reference to DEFAULT_CONFIGURATION_FILE
Change-Id: Ia3835f34fef9644734329da93210e53e9ca99025
Signed-off-by
Omer Frenkel has posted comments on this change.
Change subject: core: remove read lock of template being exported
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13109
Omer Frenkel has posted comments on this change.
Change subject: core: add locking groups for resources in export domain
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: create the conf.d directory
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13147
To unsubscribe, visit http://gerrit.ovirt.org/sett
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: create the conf.d directory
..
packaging: create the conf.d directory
Change-Id: Iee943cfe44c581cd6b767f8460e35aa65cec0728
Signed-off-by: Alon Bar-Lev
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: create the conf.d directory
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13146
To unsubscribe, visit http://gerrit.ovirt.org/sett
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: create the conf.d directory
..
packaging: create the conf.d directory
Change-Id: I65b5eb9717a24a97b4e743039905f17457387dd4
Signed-off-by: Alon Bar-Lev
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: create the conf.d directory
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13145
To unsubscribe, visit http://gerrit.ovirt.org/sett
Alon Bar-Lev has posted comments on this change.
Change subject: config: fixup default config locaiton
..
Patch Set 1: Verified
My apology, I did not notice the config prefix in this tool.
Sorry.
--
To view, visit http://gerr
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: create the conf.d directory
..
packaging: create the conf.d directory
Change-Id: Ia5a5a6c6f1df8a62c39c4c30933981e01b0a5706
Signed-off-by: Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review.
Change subject: config: fixup default config locaiton
..
config: fixup default config locaiton
Change-Id: I643659e908f2d970299f320e3a4ee5aba05d71f5
Signed-off-by: Alon Bar-Lev
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: update version of postgresql driver
..
Patch Set 1:
Abend?
--
To view, visit http://gerrit.ovirt.org/12790
To unsubscribe, visit http://gerrit.ovirt.o
Ravi Nori has posted comments on this change.
Change subject: engine : User can see events which don't belong to him
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/13091
To unsubscribe, visit http://gerrit.o
Laszlo Hornyak has posted comments on this change.
Change subject: engine: use autoclose to clean up vdsdeploy
..
Patch Set 1:
Ok, so we agree that there is an issue?
--
To view, visit http://gerrit.ovirt.org/13090
To unsubscr
Keith Robertson has submitted this change and it was merged.
Change subject: packaging: Fixed creating objects in an insecure way
..
packaging: Fixed creating objects in an insecure way
This patch is using a 'validate_cert_chai
Keith Robertson has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10815
To un
Keith Robertson has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 6:
argh... one more rebase please. Gerrit can't figure it out.
--
To view, visit http://ger
Keith Robertson has posted comments on this change.
Change subject: packaging: Fixed creating objects in an insecure way
..
Patch Set 6: Verified; Looks good to me, approved
Alex,
The same logic for 'insecure' needs to be appli
Keith Robertson has submitted this change and it was merged.
Change subject: config: support conf.d notation for configuration
..
config: support conf.d notation for configuration
Read the config file and all config files withi
Keith Robertson has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13142
To unsub
Keith Robertson has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13142
To unsubscribe, vi
Keith Robertson has submitted this change and it was merged.
Change subject: config: support conf.d notation for configuration
..
config: support conf.d notation for configuration
Read the config file and all config files withi
Keith Robertson has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13141
To unsub
Keith Robertson has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13141
To unsubscribe, vi
Keith Robertson has submitted this change and it was merged.
Change subject: config: support conf.d notation for configuration
..
config: support conf.d notation for configuration
Read the config file and all config files withi
Keith Robertson has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13140
To unsubscribe, visit http://gerrit.
Keith Robertson has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13140
To unsubscribe, vi
Keith Robertson has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13140
To unsubscribe, vi
Keith Robertson has posted comments on this change.
Change subject: cleanup: update .gitignore
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13083
To unsubscribe, visit http://gerrit.ovirt
Keith Robertson has submitted this change and it was merged.
Change subject: cleanup: update .gitignore
..
cleanup: update .gitignore
Change-Id: If42ce8d6e2106c529576aa6171a0f57364e14869
Signed-off-by: Alon Bar-Lev
---
M .giti
Keith Robertson has posted comments on this change.
Change subject: build: use embedded gettext
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13082
To unsubscribe, visit http://gerrit.ovir
Keith Robertson has submitted this change and it was merged.
Change subject: build: use embedded gettext
..
build: use embedded gettext
there are too many variants of version within different distributions
for us to support it
Tal Nisan has posted comments on this change.
Change subject: core: Allow force re-election of a specific host as SPM
..
Patch Set 4: (1 inline comment)
File
backend/manager
Keith Robertson has submitted this change and it was merged.
Change subject: build: use embedded gettext
..
build: use embedded gettext
there are too many variants of version within different distributions
for us to support it
Keith Robertson has posted comments on this change.
Change subject: build: use embedded gettext
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13081
To unsubscribe, visit http://gerrit.ovir
Keith Robertson has submitted this change and it was merged.
Change subject: build: use embedded gettext
..
build: use embedded gettext
there are too many variants of version within different distributions
for us to support it
Keith Robertson has posted comments on this change.
Change subject: build: use embedded gettext
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13078
To unsubscribe, visit http://gerrit.ovir
Roy Golan has posted comments on this change.
Change subject: tools: Setting ClientConsoleModeDefault
..
Patch Set 1:
if there are "possible values" you can put them as valid values and it will be
validated
ClientConsoleMode
Oved Ourfali has posted comments on this change.
Change subject: engine : User can see events which don't belong to him
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13091
To unsubscribe,
Vered Volansky has posted comments on this change.
Change subject: core: Allow force re-election of a specific host as SPM
..
Patch Set 4: (5 inline comments)
File backend/ma
Alon Bar-Lev has posted comments on this change.
Change subject: core: config: clenaup: use glob instead of listdir
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13143
To unsubsc
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: config: clenaup: use glob instead of listdir
..
core: config: clenaup: use glob instead of listdir
Change-Id: Ia11f738e1b58d717e91b84483b1a96cb0bbc
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: config: clenaup: use glob instead of listdir
..
core: config: clenaup: use glob instead of listdir
Change-Id: Ia11f738e1b58d717e91b84483b1a96cb0bbc94e8
Sig
Alon Bar-Lev has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 1: Verified
Verified by isolating the functions.
--
To view, visit http://gerrit.ovirt.org/13142
T
Alon Bar-Lev has uploaded a new change for review.
Change subject: config: support conf.d notation for configuration
..
config: support conf.d notation for configuration
Read the config file and all config files within the .d di
Alon Bar-Lev has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13141
To unsubscribe, visit http://gerrit.ovi
Alon Bar-Lev has uploaded a new change for review.
Change subject: config: support conf.d notation for configuration
..
config: support conf.d notation for configuration
Read the config file and all config files within the .d di
Alon Bar-Lev has posted comments on this change.
Change subject: engine: use autoclose to clean up vdsdeploy
..
Patch Set 1:
This is the last time I spend time to address your comments.
Please move along.
This issue is closed
Lior Vernia has posted comments on this change.
Change subject: webadmin: Changed bond name widget to SuggestBox
..
Patch Set 3: (2 inline comments)
File
frontend/webadmin/m
Laszlo Hornyak has posted comments on this change.
Change subject: engine: use autoclose to clean up vdsdeploy
..
Patch Set 1:
You know how you manage your time, I did not mean right now.
>From the technical perspective what I
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated parsing of the async tasks
..
Patch Set 1: (1 inline comment)
File packaging/fedora/setup/
Alon Bar-Lev has posted comments on this change.
Change subject: config: support conf.d notation for configuration
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13140
To unsubscribe, visit http://gerrit.ovi
Alon Bar-Lev has uploaded a new change for review.
Change subject: config: support conf.d notation for configuration
..
config: support conf.d notation for configuration
Read the config file and all config files within the .d di
Alon Bar-Lev has posted comments on this change.
Change subject: engine: use autoclose to clean up vdsdeploy
..
Patch Set 1:
> Could you spend just a couple of minutes explaining your point?
Already had, I am wasting too much
Laszlo Hornyak has posted comments on this change.
Change subject: engine: use autoclose to clean up vdsdeploy
..
Patch Set 1:
Could you spend just a couple of minutes explaining your point?
--
To view, visit http://gerrit.ovi
Ravi Nori has posted comments on this change.
Change subject: restapi : Add permit to role issues(#919202)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13139
To unsubscribe, visit http://gerrit.ovirt.org/s
Ravi Nori has uploaded a new change for review.
Change subject: restapi : Add permit to role issues(#919202)
..
restapi : Add permit to role issues(#919202)
When trying to add permit to role the permit
name needs to accept both
Alon Bar-Lev has posted comments on this change.
Change subject: engine: use autoclose to clean up vdsdeploy
..
Patch Set 1:
Please move along to fix other parts of the application.
Thank you.
--
To view, visit http://gerrit.
Laszlo Hornyak has posted comments on this change.
Change subject: engine: use autoclose to clean up vdsdeploy
..
Patch Set 1:
let's try to get back to technical details, so if the VdsDeploy.finalize() does
not have to wait, b
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Changed bond name widget to SuggestBox
..
Patch Set 3: (2 inline comments)
File
frontend/webadmin/
Allon Mureinik has posted comments on this change.
Change subject: core: Removed the unused GetImageByImageIdQuery
..
Patch Set 1:
Be advised: GetImageByImageIdParameters was renamed to
GetStorageDomainsByImageIdParameters, bu
Allon Mureinik has posted comments on this change.
Change subject: core: Removed the unused GetImageByImageIdQuery
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/13138
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has uploaded a new change for review.
Change subject: core: Removed the unused GetImageByImageIdQuery
..
core: Removed the unused GetImageByImageIdQuery
This patch removes the unused query GetImageByImageIdQuery.
Shireesh Anjal has posted comments on this change.
Change subject: gluster: Use brick server for advanced details
..
Patch Set 3: (1 inline comment)
Will send next patch-set with a new test cases to verify the scenario when
br
Allon Mureinik has abandoned this change.
Change subject: core: Removed the unused GetImageByImageIdQuery
..
Patch Set 1: Abandoned
pushed by mistake
--
To view, visit http://gerrit.ovirt.org/13137
To unsubscribe, visit http:/
Allon Mureinik has uploaded a new change for review.
Change subject: core: Removed the unused GetImageByImageIdQuery
..
core: Removed the unused GetImageByImageIdQuery
This patch removes the unused query GetImageByImageIdQuery.
Doron Fediuck has posted comments on this change.
Change subject: userportal: Add quota bar tool-tip
..
Patch Set 2: (1 inline comment)
File
frontend/webadmin/modules/userpo
ofri masad has posted comments on this change.
Change subject: userportal: Add quota bar tool-tip
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13134
To unsubscribe, visit http://gerrit.ovirt.org/settings
1 - 100 of 172 matches
Mail list logo
