Omer Frenkel has posted comments on this change. Change subject: core: on handing over a VM mark it as MigratingTo ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java Line 1557: vmToRemove.getmigrating_to_vds(), Line 1558: VMStatus.MigratingTo); Line 1559: Line 1560: // if the DST host goes unresponsive it will take care all MigratingTo and unknown VMs Line 1561: ResourceManager.getInstance().InternalSetVmStatus(vmToRemove, VMStatus.MigratingTo); what if host already in non-operational status? shouldn't we check it and move to unknown in this scenario? Line 1562: Line 1563: // save the VM state Line 1564: addVmDynamicToList(vmToRemove.getDynamicData()); Line 1565: addVmStatisticsToList(vmToRemove.getStatisticsData()); -- To view, visit http://gerrit.ovirt.org/13040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96b855c11171fd5f65cd2e22801d09608cba805d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
