Omer Frenkel has posted comments on this change.
Change subject: core: on handing over a VM mark it as MigratingTo
......................................................................
Patch Set 2: (1 inline comment)
forgot this one :/
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
Line 27: private final String RESTART = "Restart";
Line 28:
Line 29: public VdsNotRespondingTreatmentCommand(T parameters) {
Line 30: super(parameters);
Line 31: mVmList.addAll(getVmDAO().getAllMigratingToHost(getVdsId()));
is there an option to move this from the ctor to other place? maybe even
execute? its not a must but it feels not related to the ctor
Line 32: }
Line 33:
Line 34: /**
Line 35: * Create an executor which retries to find a proxy, since this
command is automatic and we don't want it to fail
--
To view, visit http://gerrit.ovirt.org/13040
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I96b855c11171fd5f65cd2e22801d09608cba805d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
