Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated parsing of the async tasks
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 841:
Line 842: # We only want to return anything if there are really async tasks
records
Line 843: # Count is the 3rd line (header, ----, count, #of rows)
Line 844: if runningTasks and int(runningTasks.split('\n')[2]) > 0:
Line 845: runningTasks, rc = utils.execRemoteSqlCommand(
Again, why not use my new modern function? parseRemoteSqlCommand
Line 846: userName=SERVER_ADMIN,
Line 847: dbHost=SERVER_NAME,
Line 848: dbPort=SERVER_PORT,
Line 849: dbName=dbName,
--
To view, visit http://gerrit.ovirt.org/13131
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b1f24ef5e83cf09c01c3ebbb00375098ddc52c1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
