Daniel Erez has posted comments on this change.
Change subject: webadmin: load image refreshing data
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java
Line 120: // Notify model provider that the tab has been revealed
Line 121: modelProvider.onSubTabSelected();
Line 122:
Line 123: ActionTable<?> table = getView().getTable();
Line 124: if(table != null) {
please use formatter
Line 125: table.setLoadingState(LoadingState.LOADING);
Line 126: }
Line 127: }
Line 128:
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java
Line 127: protected void listenOnManualRefresh() {
Line 128: refreshPanel.addClickHandler(new ClickHandler() {
Line 129: @Override
Line 130: public void onClick(ClickEvent event) {
Line 131: if(manualRefreshCallback != null) {
please use formatter
Line 132: manualRefreshCallback.onManualRefresh();
Line 133: }
Line 134: controller.refresh();
Line 135: }
--
To view, visit http://gerrit.ovirt.org/12946
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8be80df57eafc4244c57029f8260d4d67c47b3f4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
