Shireesh Anjal has posted comments on this change. Change subject: gluster: Use brick server for advanced details ......................................................................
Patch Set 3: (1 inline comment) Will send next patch-set with a new test cases to verify the scenario when brick id is passed as null. .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQueryTest.java Line 165: when(brickDao.getById(BRICK_ID)).thenReturn(getBrick()); Line 166: Line 167: // Mock the query's parameters Line 168: doReturn(CLUSTER_ID).when(getQueryParameters()).getClusterId(); Line 169: doReturn(VOLUME_ID).when(getQueryParameters()).getVolumeId(); Thanks, will write a test to verify the behavior when brick id is passed null. Will not spend effort in verifying the getServiceInfo as we are working on a totally new way of fetching services, which will remove this method altogether.. Line 170: doReturn(BRICK_ID).when(getQueryParameters()).getBrickId(); Line 171: doReturn(true).when(getQueryParameters()).isDetailRequired(); Line 172: Line 173: VDSReturnValue returnValue = new VDSReturnValue(); -- To view, visit http://gerrit.ovirt.org/12979 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4acb0bbe84bacab714926d69b639bbda970df9a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
