Laszlo Hornyak has posted comments on this change. Change subject: engine: use autoclose to clean up vdsdeploy ......................................................................
Patch Set 1: You know how you manage your time, I did not mean right now. >From the technical perspective what I am trying to tell you is that if the >finalizer is not blocking, because it is not doing anything, then it is not >needed. If it is needed (because faulty code not closing it), then it is going >to block the GC thread for 20 seconds. This 20 seconds can be more than enough >to make a OOM, while the close method does not make sure the resources are >freed: if the thread is not joinded, it will just leave it running. So really >the finalizer is not only not needed, but it is a potential threat to the >application server and ovirt engine running inside. If you look at the problem >from this perspective, this problem is serious enough. Can we agree in this so far? Alon? Allon? -- To view, visit http://gerrit.ovirt.org/13090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43338f9d2d5bfb36c220f1fd19810f8c7436a543 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
