Alona Kaplan has posted comments on this change.
Change subject: webadmin: Changed bond name widget to SuggestBox
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
Line 446:
Line 447: @Override
Line 448: public void ExecuteCommand(UICommand command)
{
Line 449: sourceListModel.setConfirmWindow(null);
Line 450: VdsNetworkInterface bond = new
Bond((String) bondPopup.getBond().getSelectedItem(), (VDS) getEntity());
Please make sure that if you use one of the pre-defined bond names, it is
removed from the free bond names.
Line 451: setBondOptions(bond, bondPopup);
Line 452: NetworkInterfaceModel nic1 =
(NetworkInterfaceModel) networkCommand.getOp1();
Line 453: NetworkInterfaceModel nic2 =
(NetworkInterfaceModel) networkCommand.getOp2();
Line 454: List<LogicalNetworkModel> networks =
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java
Line 49: }
Line 50:
Line 51: @UiField(provided = true)
Line 52: @Path(value = "bond.selectedItem")
Line 53: ListModelSuggestBoxEditor bondEditor = new
ListModelSuggestBoxEditor();
The initialization should be in the constructor.
Line 54:
Line 55: @UiField(provided = true)
Line 56: @Path(value = "network.selectedItem")
Line 57: ListModelListBoxEditor<Object> networkEditor;
--
To view, visit http://gerrit.ovirt.org/12531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I130586dc4787abecf81566a8d3b723d093f6fca2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
