Doron Fediuck has posted comments on this change.
Change subject: userportal: Add quota bar tool-tip
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaProgressBar.java
Line 166: CPU,
Line 167: MEM
Line 168: }
Line 169:
Line 170: public SafeHtml getTooltip() {
This is quite beefy...
Can you please break it into 4 methods?
Line 171: switch (type) {
Line 172: case STORAGE:
Line 173: if (quotaUsagePerUser.getStorageLimit() == UNLIMITED) {
Line 174: return EMPTY_HTML;
--
To view, visit http://gerrit.ovirt.org/13134
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb877d23edceaccb8e1cd549bef8ef7d9d044ca7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
