[Engine-patches] Change in ovirt-engine[master]: engine : User is UNKNOWN in async task completion events

2013-01-28 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : User is UNKNOWN in async task completion events .. engine : User is UNKNOWN in async task completion events In async tasks after the user has

[Engine-patches] Change in ovirt-engine[master]: engine : User is UNKNOWN in async task completion events

2013-01-28 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine : User is UNKNOWN in async task completion events .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10896 To

[Engine-patches] Change in ovirt-engine[master]: engine : User is UNKNOWN in async task completion events

2013-01-28 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine : User is UNKNOWN in async task completion events .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/10896 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: ImagesHandler: Remove SD status validation

2013-01-28 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: ImagesHandler: Remove SD status validation .. core: ImagesHandler: Remove SD status validation Extracted the validation of Storage Domain statuses from I

[Engine-patches] Change in ovirt-engine[master]: userportal: redesign for resources tab

2013-01-28 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: userportal: redesign for resources tab .. userportal: redesign for resources tab This patch is a facelift for the User Portal Resources tab. - The basic

[Engine-patches] Change in ovirt-engine[master]: userportal: redesign for resources tab

2013-01-28 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal: redesign for resources tab .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11259 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: frontend: force admin-console only on AdminPortal

2013-01-28 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: frontend: force admin-console only on AdminPortal .. Patch Set 2: Changed according to Daniel's request -- To view, visit http://gerrit.ovirt.org/11484 To unsub

[Engine-patches] Change in ovirt-engine[master]: tools: Don't send events on startup

2013-01-28 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: Don't send events on startup .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11483 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: webadmin: Cleanup of Frontend class

2013-01-28 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: webadmin: Cleanup of Frontend class .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11268 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: engine : User is UNKNOWN in async task completion events

2013-01-28 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine : User is UNKNOWN in async task completion events .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10896 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: userportal: redesign for resources tab

2013-01-28 Thread omasad
ofri masad has posted comments on this change. Change subject: userportal: redesign for resources tab .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/11259 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: engine: Import Cluster with Invalid Password (#894462)

2013-01-28 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Import Cluster with Invalid Password (#894462) .. Patch Set 1: I would prefer that you didn't submit this (5 inline comments) .

[Engine-patches] Change in ovirt-engine[master]: webadmin: Frontend class formatting

2013-01-28 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: webadmin: Frontend class formatting .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11269 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: engine: Extended error for pinned host missing non required ...

2013-01-28 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Extended error for pinned host missing non required network .. Patch Set 5: (3 inline comments) Fil

[Engine-patches] Change in ovirt-engine[master]: core: Add capability check fot Gluster FS.

2013-01-28 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: core: Add capability check fot Gluster FS. .. Patch Set 9: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8964 To uns

[Engine-patches] Change in ovirt-engine[master]: engine: Refactored code into NetworkValidator class

2013-01-28 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: engine: Refactored code into NetworkValidator class .. Patch Set 6: (18 inline comments) File backend/manag

[Engine-patches] Change in ovirt-engine[master]: core: Removal of DNS root from host name

2013-01-28 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Removal of DNS root from host name .. Patch Set 3: (1 inline comment) File backend/manager/modules/u

[Engine-patches] Change in ovirt-engine[master]: engine-config: Adding man page

2013-01-28 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: engine-config: Adding man page .. Patch Set 2: Douglas, sorry but I disagree on the contents part. Most dev's today are unaware of it and most chances are this w

[Engine-patches] Change in ovirt-engine[master]: engine-manage-domains: Adding man page

2013-01-28 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: engine-manage-domains: Adding man page .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11175 To unsubsc

[Engine-patches] Change in ovirt-engine[master]: db: cluster permission query

2013-01-28 Thread gpadgett
Greg Padgett has abandoned this change. Change subject: db: cluster permission query .. Patch Set 1: Abandoned See fix for same issue here (already merged): http://gerrit.ovirt.org/#/c/11411/ -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: frontend: force admin-console only on AdminPortal

2013-01-28 Thread derez
Daniel Erez has posted comments on this change. Change subject: frontend: force admin-console only on AdminPortal .. Patch Set 1: (1 inline comment) File frontend/webadmin/m

[Engine-patches] Change in ovirt-engine[master]: engine : Webadmin won't let user login in second tab

2013-01-28 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine : Webadmin won't let user login in second tab .. Patch Set 1: (1 inline comment) Commit Message Line

[Engine-patches] Change in ovirt-engine[master]: engine : Webadmin won't let user login in second tab

2013-01-28 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine : Webadmin won't let user login in second tab .. Patch Set 1: Ravi, what are the usages of USER_ALREADY_LOGGED_IN message, if you erased it from the cod

[Engine-patches] Change in ovirt-engine[master]: core: handle error when iso domain in maintenance

2013-01-28 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: handle error when iso domain in maintenance .. Patch Set 3: (3 inline comments) File backend/manager/m

[Engine-patches] Change in ovirt-engine[master]: core: handle error when iso domain in maintenance

2013-01-28 Thread abaron
Ayal Baron has posted comments on this change. Change subject: core: handle error when iso domain in maintenance .. Patch Set 3: (3 inline comments) File backend/manager/mod

[Engine-patches] Change in ovirt-engine[master]: webadmin: improve import conflict (for vm) dialog

2013-01-28 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: webadmin: improve import conflict (for vm) dialog .. Patch Set 2: (2 inline comments) File frontend/webadmin/m

[Engine-patches] Change in ovirt-engine[master]: webadmin: improve import conflict (for vm) dialog

2013-01-28 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: webadmin: improve import conflict (for vm) dialog .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/11435 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: webadmin: improve import conflict (for vm) dialogue

2013-01-28 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: webadmin: improve import conflict (for vm) dialogue .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/11435 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: frontend: force admin-console only on AdminPortal

2013-01-28 Thread fkobzik
Frank Kobzik has uploaded a new change for review. Change subject: frontend: force admin-console only on AdminPortal .. frontend: force admin-console only on AdminPortal In RHEV 3.1, the UserPortal discovered to force the AdminC

[Engine-patches] Change in ovirt-engine[master]: engine-config: Adding man page

2013-01-28 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: engine-config: Adding man page .. Patch Set 2: Hi Doron, 1. Fixed, now it bz is open. 2. I agree it may be duplicated, however most sysadmin rely

[Engine-patches] Change in ovirt-engine[master]: webadmin: Application continue polling after logout

2013-01-28 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: Application continue polling after logout .. Patch Set 1: (1 inline comment) File frontend/webad

[Engine-patches] Change in ovirt-engine[master]: webadmin: Application continue polling after logout

2013-01-28 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: Application continue polling after logout .. Patch Set 2: Fixed the indent changes that happened by accident in CommonModel. -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: handle error when iso domain in maintenance

2013-01-28 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: handle error when iso domain in maintenance .. Patch Set 3: (1 inline comment) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: engine-manage-domains: Adding man page

2013-01-28 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: engine-manage-domains: Adding man page .. Patch Set 3: Fixed, the bz is now open. thanks! -- To view, visit http://gerrit.ovirt.org/11175 To unsubs

[Engine-patches] Change in ovirt-engine[master]: core: handle error when iso domain in maintenance

2013-01-28 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: handle error when iso domain in maintenance .. Patch Set 3: (1 inline comment) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: core: block MoveDisks on snapshot preview

2013-01-28 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: core: block MoveDisks on snapshot preview .. Patch Set 3: Verified Verified build (no errors). I trust the logic to be unchanged. -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: tools: Don't send events on startup

2013-01-28 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: tools: Don't send events on startup .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11483 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: engine: Add --first-run option to notifier

2013-01-28 Thread juan . hernandez
Juan Hernandez has abandoned this change. Change subject: engine: Add --first-run option to notifier .. Patch Set 3: Abandoned Replaced by http://gerrit.ovirt.org/11483 . -- To view, visit http://gerrit.ovirt.org/8772 To unsub

[Engine-patches] Change in ovirt-engine[master]: core: handle error when iso domain in maintenance

2013-01-28 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core: handle error when iso domain in maintenance .. Patch Set 3: (4 inline comments) File backend/manager/m

[Engine-patches] Change in ovirt-engine[master]: tools: Don't send events on startup

2013-01-28 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: tools: Don't send events on startup .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11483 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: tools: Don't send events on startup

2013-01-28 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: tools: Don't send events on startup .. tools: Don't send events on startup Currently the event notifier sends all the pending events during startup. This can f

[Engine-patches] Change in ovirt-engine[master]: core: block MoveDisks on snapshot preview

2013-01-28 Thread derez
Daniel Erez has posted comments on this change. Change subject: core: block MoveDisks on snapshot preview .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11340 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: engine-manage-domains: Adding man page

2013-01-28 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: engine-manage-domains: Adding man page .. Patch Set 3: This is old bugzilla, before we launch the source to community. I am trying to open it since

[Engine-patches] Change in ovirt-engine[master]: core: update images size in DB after migration

2013-01-28 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: core: update images size in DB after migration .. core: update images size in DB after migration Images actual size should be updated in db after live disk migrat

[Engine-patches] Change in ovirt-engine[master]: webadmin: Gluster Hooks sub tab in Cluster

2013-01-28 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: Gluster Hooks sub tab in Cluster .. Patch Set 4: (1 inline comment) File frontend/webadmin/modules/

[Engine-patches] Change in ovirt-engine[master]: userportal: redesign for resources tab

2013-01-28 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal: redesign for resources tab .. Patch Set 4: Looks good to me, approved (1 inline comment) File fr

[Engine-patches] Change in ovirt-engine[master]: userportal: Optimize basic view

2013-01-28 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: Optimize basic view .. Patch Set 4: see my last comment in http://gerrit.ovirt.org/#/c/10579/ -- To view, visit http://gerrit.ovirt.org/10509 To unsub

[Engine-patches] Change in ovirt-engine[master]: userportal: set grid's items only on change

2013-01-28 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: set grid's items only on change .. Patch Set 2: [trying again, hopefully gerrit-text formatting will be better this time...] We need to make sure that

[Engine-patches] Change in ovirt-engine[master]: userportal: set grid's items only on change

2013-01-28 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal: set grid's items only on change .. Patch Set 2: We need to make sure that we are refreshing the view whenever it needs to be refreshed. Which means a

[Engine-patches] Change in ovirt-engine[master]: core: Introduce AddGlusterFsStorageDomainCommand.

2013-01-28 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core: Introduce AddGlusterFsStorageDomainCommand. .. Patch Set 8: (1 inline comment) File backend/manager/d

[Engine-patches] Change in ovirt-engine[master]: packaging: suggest path for local storage during AIO setup

2013-01-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: suggest path for local storage during AIO setup .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix priority options not presented bug

2013-01-28 Thread gchaplik
Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix priority options not presented bug .. webadmin: Fix priority options not presented bug When all hosts are down or in maintenance mode the

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix priority options not presented bug

2013-01-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Fix priority options not presented bug .. Patch Set 2: Verified; Looks good to me, approved reviewed. -- To view, visit http://gerrit.ovirt.org/11467

[Engine-patches] Change in ovirt-engine[master]: webadmin: NPE in guideme add disk when quota !disabled

2013-01-28 Thread gchaplik
Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: NPE in guideme add disk when quota !disabled .. webadmin: NPE in guideme add disk when quota !disabled Change-Id: I42b9cffe42b2635ed982924b0e5

[Engine-patches] Change in ovirt-engine[master]: webadmin: NPE in guideme add disk when quota !disabled

2013-01-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: NPE in guideme add disk when quota !disabled .. Patch Set 3: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/11

[Engine-patches] Change in ovirt-engine[master]: webadmin: Frontend class formatting

2013-01-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Frontend class formatting .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11269 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: webadmin: Cleanup of Frontend class

2013-01-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Cleanup of Frontend class .. Patch Set 1: (2 inline comments) File frontend/webadmin/modules/fron

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: implement VM builder

2013-01-28 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: userportal,webadmin: implement VM builder .. Patch Set 4: (1 inline comment) File frontend/webadmin/modules/uic

[Engine-patches] Change in ovirt-engine[master]: webadmin: NPE in guideme add disk when quota !disabled

2013-01-28 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: NPE in guideme add disk when quota !disabled .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11461 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: engine: Fixed VM sorting according to IP

2013-01-28 Thread lvernia
Lior Vernia has posted comments on this change. Change subject: engine: Fixed VM sorting according to IP .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11470 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 3237 - Fixed!

2013-01-28 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/ Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3237/ Build Number: 3237 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine" build number 4,133 - Changes Since

[Engine-patches] Change in ovirt-engine[master]: engine: Fixed sorting VMs by IP address in search

2013-01-28 Thread lvernia
Lior Vernia has abandoned this change. Change subject: engine: Fixed sorting VMs by IP address in search .. Patch Set 2: Abandoned Changed the structure of the fix, and accidentally moved it to another change ID: http://gerrit

[Engine-patches] Change in ovirt-engine[master]: engine: Fixed sorting VMs by IP address in search

2013-01-28 Thread lvernia
Lior Vernia has posted comments on this change. Change subject: engine: Fixed sorting VMs by IP address in search .. Patch Set 2: Still working on measuring the impact on performance. Either way, it only affects sorting by IP

[Engine-patches] Change in ovirt-engine[master]: engine: Fixed VM sorting according by IP

2013-01-28 Thread lvernia
Lior Vernia has uploaded a new change for review. Change subject: engine: Fixed VM sorting according by IP .. engine: Fixed VM sorting according by IP VMs are now sorted numerically rather than lexicographically, by applying the

[Engine-patches] Change in ovirt-engine[master]: engine: Added ability to affect sort order in search

2013-01-28 Thread lvernia
Lior Vernia has uploaded a new change for review. Change subject: engine: Added ability to affect sort order in search .. engine: Added ability to affect sort order in search Added to the search mechanism a generic way for devel

[Engine-patches] Change in ovirt-engine[master]: core: fix monitoring of SetNonOperationalVdsCommand

2013-01-28 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: core: fix monitoring of SetNonOperationalVdsCommand .. core: fix monitoring of SetNonOperationalVdsCommand This patch resolves a bug in which an exceptio

[Engine-patches] Change in ovirt-engine[master]: core: fix monitoring of SetNonOperationalVdsCommand

2013-01-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: fix monitoring of SetNonOperationalVdsCommand .. Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11370 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: restapi: Add support for tunnel migration

2013-01-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: restapi: Add support for tunnel migration .. Patch Set 2: Verified updated template mapper and test -- To view, visit http://gerrit.ovirt.org/11379 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: add support for tunnel migration

2013-01-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: add support for tunnel migration .. Patch Set 5: Verified changed vm dao to support nullable boolean, updated upgrade script number verified - all unit test

[Engine-patches] Change in ovirt-engine[master]: webadmin: improve import conflict (for vm) dialogue

2013-01-28 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: webadmin: improve import conflict (for vm) dialogue .. Patch Set 2: (1 inline comment) File frontend/webadmin/m

[Engine-patches] Change in ovirt-engine[master]: core: fix monitoring of SetNonOperationalVdsCommand

2013-01-28 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: fix monitoring of SetNonOperationalVdsCommand .. Patch Set 7: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11370

[Engine-patches] Change in ovirt-engine[master]: core: fix monitoring of SetNonOperationalVdsCommand

2013-01-28 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: fix monitoring of SetNonOperationalVdsCommand .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/11370 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: webadmin: improve import conflict (for vm) dialogue

2013-01-28 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: webadmin: improve import conflict (for vm) dialogue .. Patch Set 2: Looks good to me, approved (1 inline comment) Minor comment, please refer to it, other than that

[Engine-patches] Change in ovirt-engine[master]: restapi: Support View and Reload of System Configuration

2013-01-28 Thread oliel
Ori Liel has uploaded a new change for review. Change subject: restapi: Support View and Reload of System Configuration .. restapi: Support View and Reload of System Configuration Change-Id: I3d5cf3a09cfbf4bfb7586ba296e13f71386c

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix priority options not presented bug

2013-01-28 Thread omasad
ofri masad has posted comments on this change. Change subject: webadmin: Fix priority options not presented bug .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11467 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: webadmin: NPE in guideme add disk when quota !disabled

2013-01-28 Thread omasad
ofri masad has posted comments on this change. Change subject: webadmin: NPE in guideme add disk when quota !disabled .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/114

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 3236 - Unstable!

2013-01-28 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/ Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3236/ Build Number: 3236 Build Status: Unstable Triggered By: Started by upstream project "ovirt_engine" build number 4,132 - Changes Sin

[Engine-patches] Change in ovirt-engine[master]: webadmin: Show clusters with Virt service enabled only for V...

2013-01-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Show clusters with Virt service enabled only for VM .. Patch Set 2: let's see what others think; I'd add to 'GetDataCe..' and 'GetCluster..' queries 2

[Engine-patches] Change in ovirt-engine[master]: webadmin: Fix priority options not presented bug

2013-01-28 Thread omasad
ofri masad has uploaded a new change for review. Change subject: webadmin: Fix priority options not presented bug .. webadmin: Fix priority options not presented bug When all hosts are down or in maintenance mode the priority op

[Engine-patches] Change in ovirt-engine[master]: core: fix monitoring of SetNonOperationalVdsCommand

2013-01-28 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: fix monitoring of SetNonOperationalVdsCommand .. Patch Set 6: (1 inline comment) File backend/manager/m

[Engine-patches] Change in ovirt-engine[master]: gluster: Improved audit log messages

2013-01-28 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: gluster: Improved audit log messages .. Patch Set 3: Verified Rebased, and modified to pass Map instead of length-2 arrays to logAuditMessage() -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: webadmin: Show clusters with Virt service enabled only for V...

2013-01-28 Thread lspevak
Libor Spevak has posted comments on this change. Change subject: webadmin: Show clusters with Virt service enabled only for VM .. Patch Set 2: I think, this patch influences mostly GUI - 2 dialog boxes - new, edit VM - filters

[Engine-patches] Change in ovirt-engine[master]: gluster: Audit Log Util for gluster

2013-01-28 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: gluster: Audit Log Util for gluster .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11300 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: core: fix monitoring of SetNonOperationalVdsCommand

2013-01-28 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: fix monitoring of SetNonOperationalVdsCommand .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/1137

[Engine-patches] Change in ovirt-engine[master]: gluster: Audit Log Director for gluster

2013-01-28 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: gluster: Audit Log Director for gluster .. Patch Set 1: (1 inline comment) Will rename the class to GlusterAuditLogUtil. I've made it singleton so that it is e

[Engine-patches] Change in ovirt-engine[master]: webadmin: Show clusters with Virt service enabled only for V...

2013-01-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Show clusters with Virt service enabled only for VM .. Patch Set 2: *deeper :) -- To view, visit http://gerrit.ovirt.org/11395 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: fix monitoring of SetNonOperationalVdsCommand

2013-01-28 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: fix monitoring of SetNonOperationalVdsCommand .. Patch Set 4: (1 inline comment) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: core: fix monitoring of SetNonOperationalVdsCommand

2013-01-28 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: fix monitoring of SetNonOperationalVdsCommand .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/11370 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: webadmin: Show clusters with Virt service enabled only for V...

2013-01-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Show clusters with Virt service enabled only for VM .. Patch Set 2: I would prefer that you didn't submit this IMHO there are a lot more places to cove

[Engine-patches] Change in ovirt-engine[master]: webadmin: NPE in guideme add disk when quota disabled

2013-01-28 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: NPE in guideme add disk when quota disabled .. webadmin: NPE in guideme add disk when quota disabled Change-Id: I42b9cffe42b2635ed982924b0e52d0e691620

[Engine-patches] Change in ovirt-engine-sdk-java[master]: codegen: generate delete() overloads using header/url params

2013-01-28 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: codegen: generate delete() overloads using header/url params .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1

[Engine-patches] Change in ovirt-engine-sdk-java[master]: codegen: generate delete() overloads using header/url params

2013-01-28 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: codegen: generate delete() overloads using header/url params .. codegen: generate delete() overloads using header/url params Change-Id: I9bb2b077d68

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add Interface dialog is cropped on chrome.

2013-01-28 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: webadmin: Add Interface dialog is cropped on chrome. .. webadmin: Add Interface dialog is cropped on chrome. The default width of the inner element of mainPanel

[Engine-patches] Change in ovirt-engine[master]: core: handle error when iso domain in maintenance

2013-01-28 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: handle error when iso domain in maintenance .. Patch Set 3: Verified Verified on iso domain when it's active, and then when it's in maintenance. -- To view

[Engine-patches] Change in ovirt-engine[master]: core: handle error when iso domain in maintenance

2013-01-28 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: handle error when iso domain in maintenance .. Patch Set 2: (2 inline comments) File backend/manager/m

[Engine-patches] Change in ovirt-engine[master]: webadmin: 'No No Alerts' shown in 0 alerts + cleanup

2013-01-28 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin: 'No No Alerts' shown in 0 alerts + cleanup .. Patch Set 2: Verified; Looks good to me, but someone else must approve - verified that bottom-gray-alerts-s

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: i18n splash screen.

2013-01-28 Thread awels
Alexander Wels has posted comments on this change. Change subject: core, webadmin: i18n splash screen. .. Patch Set 11: Updated commit message to match correct pattern. -- To view, visit http://gerrit.ovirt.org/10065 To unsubs

[Engine-patches] Change in ovirt-engine[master]: webadmin: enable gzip compression

2013-01-28 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: webadmin: enable gzip compression .. Patch Set 7: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10911 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: webadmin: enable gzip compression

2013-01-28 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: enable gzip compression .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/10911 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[master]: webadmin: enable gzip compression

2013-01-28 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: enable gzip compression .. Patch Set 6: Verified Added application/x-yaml as requested. -- To view, visit http://gerrit.ovirt.org/10911 To unsubscrib

  1   2   3   >