Shireesh Anjal has posted comments on this change.
Change subject: gluster: Audit Log Director for gluster
......................................................................
Patch Set 1: (1 inline comment)
Will rename the class to GlusterAuditLogUtil. I've made it singleton so that it
is easy to mock it in test cases. If we use static methods, then we need to use
static mocking, which slows down the tests. It was decided some time back in
oVirt to not use static mocking in tests.
New patch-set to follow.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/gluster/GlusterAuditLogDirector.java
Line 68: }
Line 69:
Line 70: @Override
Line 71: public Map<String, String> getCustomValues() {
Line 72: Map<String, String> customValuesMap = new
HashMap<String, String>();
Yes, will change the method to accept a map instead of variable number of
length-2 arrays.
Line 73: if (customValues != null) {
Line 74: for (String entry[] : customValues) {
Line 75: if (entry != null && entry.length == 2) {
Line 76: customValuesMap.put(entry[0], entry[1]);
--
To view, visit http://gerrit.ovirt.org/11300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If36dcf305cd6b0ee57cff3bea126f4f6acef740f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
