Lior Vernia has uploaded a new change for review. Change subject: engine: Fixed VM sorting according by IP ......................................................................
engine: Fixed VM sorting according by IP VMs are now sorted numerically rather than lexicographically, by applying the database function fn_get_comparable_ip_list in the search mechanism. Change-Id: Ic555ef3c16e8cd88d53314f2b990861ef301508a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=895468 Signed-off-by: Lior Vernia <lver...@redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/70/11470/1 diff --git a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java index d9261bc..5bdbf0a 100644 --- a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java +++ b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java @@ -84,6 +84,10 @@ mColumnNameDict.put("TYPE", "vm_type"); mColumnNameDict.put("QUOTA", "quota_name"); mColumnNameDict.put("_VM_ID", "vm_guid"); + + // Override field names for purpose of sorting, if needed + mSortableFieldDict.put("IP", StringFormat.format("fn_get_comparable_ip_list(%s)", getDbFieldName("IP"))); + /** */ mNotFreeTextSearchableFieldsList.add("APPS"); @@ -120,7 +124,10 @@ } @Override - public void formatValue(String fieldName, RefObject<String> relations, RefObject<String> value, boolean caseSensitive) { + public void formatValue(String fieldName, + RefObject<String> relations, + RefObject<String> value, + boolean caseSensitive) { if ("APPS".equals(fieldName)) { value.argvalue = StringFormat.format(BaseConditionFieldAutoCompleter.getI18NPrefix() + "'%%%1$s%%'", -- To view, visit http://gerrit.ovirt.org/11470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic555ef3c16e8cd88d53314f2b990861ef301508a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
