Arik Hadas has posted comments on this change.

Change subject: webadmin: improve import conflict (for vm) dialog
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 2474: 
Line 2475:     @DefaultStringValue("Don't import")
Line 2476:     String cloneDontImport();
Line 2477: 
Line 2478:     @DefaultStringValue("Import as 
cloned<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Changing name, MAC addresses, and 
cloning all disks removing all snapshots")
Done
Line 2479:     String cloneImportVm();
Line 2480: 
Line 2481:     @DefaultStringValue("Clone")
Line 2482:     String cloneImportTemplate();


....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportCloneDialogPopupView.java
Line 88:     @Override
Line 89:     public void edit(ImportCloneModel object) {
Line 90:         if (object.getEntity() instanceof VM) {
Line 91:             dialogLabelEditor.setText(constants.sameVmNameExists()
Line 92:                     .replaceFirst("\\$\\{VmName\\}", ((VM) 
object.getEntity()).getVmName())); //$NON-NLS-1$
Done
Line 93:             cloneEditor.setLabel(constants.cloneImportVm());
Line 94:             suffixEditor.setLabel(constants.cloneImportSuffixVm());
Line 95:         } else {
Line 96:             
dialogLabelEditor.setText(constants.sameTemplateNameExists()


--
To view, visit http://gerrit.ovirt.org/11435
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6fe863e52e9bad1d620bce75b8252bca4d0d414
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to