Alissa Bonas has posted comments on this change. Change subject: core: handle error when iso domain in maintenance ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java Line 309: storageDomainId, Line 310: fileTypeExt, Line 311: storagePoolId); Line 312: // set a mock repository file meta data with storage domain id and storage pool id. Line 313: RepoFileMetaData repoFileMetaData = new RepoFileMetaData(); see Allon's comment on previous version of the patch - this is what I understood he wrote and showed in example pseudocode that it should be checked only regarding active domains. Line 314: repoFileMetaData.setStoragePoolId(storagePoolId); Line 315: repoFileMetaData.setRepoDomainId(storageDomainId); Line 316: repoFileMetaData.setFileType(fileTypeExt); Line 317: -- To view, visit http://gerrit.ovirt.org/11449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide53f42c087ffbc9240cccc033e809ff8117ec8c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
